From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbaHDOp5 (ORCPT ); Mon, 4 Aug 2014 10:45:57 -0400 Received: from mail-bl2lp0210.outbound.protection.outlook.com ([207.46.163.210]:4383 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750999AbaHDOp4 convert rfc822-to-8bit (ORCPT ); Mon, 4 Aug 2014 10:45:56 -0400 X-WSS-ID: 0N9SEBU-08-P1M-02 X-M-MSG: Message-ID: <53DF9C88.6060107@amd.com> Date: Mon, 4 Aug 2014 16:45:28 +0200 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Maarten Lankhorst , CC: , , , , , Subject: Re: [PATCH 09/19] drm/radeon: handle lockup in delayed work, v2 References: <20140731153245.15061.63023.stgit@patser> <20140731153342.15061.54264.stgit@patser> <53DBC1EC.1010001@amd.com> <53DBD269.80807@canonical.com> <53DF462B.2060102@amd.com> <53DF4A7D.3040505@canonical.com> <53DF7516.2010408@amd.com> <53DF8BF2.4000309@canonical.com> <53DF9AC4.3010700@amd.com> <53DF9B58.8000403@canonical.com> In-Reply-To: <53DF9B58.8000403@canonical.com> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [10.224.152.188] Content-Transfer-Encoding: 8BIT X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(428002)(199002)(189002)(377424004)(51704005)(81342001)(105586002)(74502001)(76482001)(31966008)(74662001)(95666004)(65956001)(80022001)(65806001)(84676001)(47776003)(20776003)(86362001)(83506001)(77982001)(81542001)(83322001)(85306004)(93886004)(85202003)(106466001)(50466002)(107046002)(21056001)(65816999)(23676002)(97736001)(54356999)(76176999)(87266999)(36756003)(99396002)(50986999)(68736004)(33656002)(87936001)(64126003)(80316001)(46102001)(64706001)(102836001)(101416001)(79102001)(85852003)(83072002)(92726001)(44976005)(92566001)(4396001)(85182001);DIR:OUT;SFP:;SCL:1;SRVR:BLUPR02MB034;H:atltwp02.amd.com;FPR:;MLV:sfv;PTR:InfoDomainNonexistent;MX:1;LANG:en; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID: X-Forefront-PRVS: 0293D40691 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Christian.Koenig@amd.com; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 04.08.2014 um 16:40 schrieb Maarten Lankhorst: > op 04-08-14 16:37, Christian König schreef: >>> It'a pain to deal with gpu reset. >> Yeah, well that's nothing new. >> >>> I've now tried other solutions but that would mean reverting to the old style during gpu lockup recovery, and only running the delayed work when !lockup. >>> But this meant that the timeout was useless to add. I think the cleanest is keeping the v2 patch, because potentially any waiting code can be called during lockup recovery. >> The lockup code itself should never call any waiting code and V2 doesn't seem to handle a couple of cases correctly either. >> >> How about moving the fence waiting out of the reset code? > What cases did I miss then? > > I'm curious how you want to move the fence waiting out of reset, when there are so many places that could potentially wait, like radeon_ib_get can call radeon_sa_bo_new which can do a wait, or radeon_ring_alloc that can wait on radeon_fence_wait_next, etc. The IB test itself doesn't needs to be protected by the exclusive lock. Only everything between radeon_save_bios_scratch_regs and radeon_ring_restore. Christian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [PATCH 09/19] drm/radeon: handle lockup in delayed work, v2 Date: Mon, 4 Aug 2014 16:45:28 +0200 Message-ID: <53DF9C88.6060107@amd.com> References: <20140731153245.15061.63023.stgit@patser> <20140731153342.15061.54264.stgit@patser> <53DBC1EC.1010001@amd.com> <53DBD269.80807@canonical.com> <53DF462B.2060102@amd.com> <53DF4A7D.3040505@canonical.com> <53DF7516.2010408@amd.com> <53DF8BF2.4000309@canonical.com> <53DF9AC4.3010700@amd.com> <53DF9B58.8000403@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <53DF9B58.8000403@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst , airlied@linux.ie Cc: thellstrom@vmware.com, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bskeggs@redhat.com, alexander.deucher@amd.com List-Id: nouveau.vger.kernel.org QW0gMDQuMDguMjAxNCB1bSAxNjo0MCBzY2hyaWViIE1hYXJ0ZW4gTGFua2hvcnN0Ogo+IG9wIDA0 LTA4LTE0IDE2OjM3LCBDaHJpc3RpYW4gS8O2bmlnIHNjaHJlZWY6Cj4+PiBJdCdhIHBhaW4gdG8g ZGVhbCB3aXRoIGdwdSByZXNldC4KPj4gWWVhaCwgd2VsbCB0aGF0J3Mgbm90aGluZyBuZXcuCj4+ Cj4+PiBJJ3ZlIG5vdyB0cmllZCBvdGhlciBzb2x1dGlvbnMgYnV0IHRoYXQgd291bGQgbWVhbiBy ZXZlcnRpbmcgdG8gdGhlIG9sZCBzdHlsZSBkdXJpbmcgZ3B1IGxvY2t1cCByZWNvdmVyeSwgYW5k IG9ubHkgcnVubmluZyB0aGUgZGVsYXllZCB3b3JrIHdoZW4gIWxvY2t1cC4KPj4+IEJ1dCB0aGlz IG1lYW50IHRoYXQgdGhlIHRpbWVvdXQgd2FzIHVzZWxlc3MgdG8gYWRkLiBJIHRoaW5rIHRoZSBj bGVhbmVzdCBpcyBrZWVwaW5nIHRoZSB2MiBwYXRjaCwgYmVjYXVzZSBwb3RlbnRpYWxseSBhbnkg d2FpdGluZyBjb2RlIGNhbiBiZSBjYWxsZWQgZHVyaW5nIGxvY2t1cCByZWNvdmVyeS4KPj4gVGhl IGxvY2t1cCBjb2RlIGl0c2VsZiBzaG91bGQgbmV2ZXIgY2FsbCBhbnkgd2FpdGluZyBjb2RlIGFu ZCBWMiBkb2Vzbid0IHNlZW0gdG8gaGFuZGxlIGEgY291cGxlIG9mIGNhc2VzIGNvcnJlY3RseSBl aXRoZXIuCj4+Cj4+IEhvdyBhYm91dCBtb3ZpbmcgdGhlIGZlbmNlIHdhaXRpbmcgb3V0IG9mIHRo ZSByZXNldCBjb2RlPwo+IFdoYXQgY2FzZXMgZGlkIEkgbWlzcyB0aGVuPwo+Cj4gSSdtIGN1cmlv dXMgaG93IHlvdSB3YW50IHRvIG1vdmUgdGhlIGZlbmNlIHdhaXRpbmcgb3V0IG9mIHJlc2V0LCB3 aGVuIHRoZXJlIGFyZSBzbyBtYW55IHBsYWNlcyB0aGF0IGNvdWxkIHBvdGVudGlhbGx5IHdhaXQs IGxpa2UgcmFkZW9uX2liX2dldCBjYW4gY2FsbCByYWRlb25fc2FfYm9fbmV3IHdoaWNoIGNhbiBk byBhIHdhaXQsIG9yIHJhZGVvbl9yaW5nX2FsbG9jIHRoYXQgY2FuIHdhaXQgb24gcmFkZW9uX2Zl bmNlX3dhaXRfbmV4dCwgZXRjLgoKVGhlIElCIHRlc3QgaXRzZWxmIGRvZXNuJ3QgbmVlZHMgdG8g YmUgcHJvdGVjdGVkIGJ5IHRoZSBleGNsdXNpdmUgbG9jay4gCk9ubHkgZXZlcnl0aGluZyBiZXR3 ZWVuIHJhZGVvbl9zYXZlX2Jpb3Nfc2NyYXRjaF9yZWdzIGFuZCAKcmFkZW9uX3JpbmdfcmVzdG9y ZS4KCkNocmlzdGlhbi4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK