From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEcq6-0008F8-7C for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEcpu-0001sr-0S for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:23:34 -0400 Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]:43635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEcpt-0001sY-QQ for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:23:21 -0400 Received: by mail-we0-f177.google.com with SMTP id w62so845641wes.36 for ; Tue, 05 Aug 2014 04:23:21 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53E0BEA4.40303@redhat.com> Date: Tue, 05 Aug 2014 13:23:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1407229913-16862-1-git-send-email-famz@redhat.com> In-Reply-To: <1407229913-16862-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] scsi: Change device init to realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com Il 05/08/2014 11:11, Fam Zheng ha scritto: > DeviceClass->init is the old interface, let's convert scsi devices to the new > ->realize API. > > A user visible change is the error message shown in qemu-iotests reference > output, but I don't know what's the best way to retain it. So please review if > and how this could be improved. I think the new message is an improvement. Kevin/Stefan, are you taking both patches or can you alternatively ack the first? Paolo > Fam > > Fam Zheng (2): > block: Pass errp in blkconf_geometry > scsi-bus: Convert DeviceClass init to realize > > hw/block/block.c | 18 +++++----- > hw/block/virtio-blk.c | 7 ++-- > hw/ide/qdev.c | 11 ++++-- > hw/scsi/lsi53c895a.c | 2 ++ > hw/scsi/scsi-bus.c | 64 +++++++++++++++++------------------ > hw/scsi/scsi-disk.c | 83 +++++++++++++++++++++++++--------------------- > hw/scsi/scsi-generic.c | 37 ++++++++++----------- > include/hw/block/block.h | 6 ++-- > include/hw/scsi/scsi.h | 7 ++-- > tests/qemu-iotests/051.out | 4 +-- > 10 files changed, 125 insertions(+), 114 deletions(-) >