From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755536AbaHFBEz (ORCPT ); Tue, 5 Aug 2014 21:04:55 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27212 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755503AbaHFBEt (ORCPT ); Tue, 5 Aug 2014 21:04:49 -0400 Message-ID: <53E17F06.30401@oracle.com> Date: Tue, 05 Aug 2014 21:04:06 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Hugh Dickins , Mel Gorman CC: "linux-mm@kvack.org" , Andrew Morton , Dave Jones , LKML , "Kirill A. Shutemov" , Peter Zijlstra , Rik van Riel , Johannes Weiner , Cyrill Gorcunov Subject: Re: mm: BUG in unmap_page_range References: <53DD5F20.8010507@oracle.com> <20140805144439.GW10819@suse.de> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Hugh, Mel. I've added both patches to my local tree and will update tomorrow with the weather. Also: On 08/05/2014 08:42 PM, Hugh Dickins wrote: > One thing I did wonder, though: at first I was reassured by the > VM_BUG_ON(!pte_present(pte)) you add to pte_mknuma(); but then thought > it would be better as VM_BUG_ON(!(val & _PAGE_PRESENT)), being stronger > - asserting that indeed we do not put NUMA hints on PROT_NONE areas. > (But I have not tested, perhaps such a VM_BUG_ON would actually fire.) I've added VM_BUG_ON(!(val & _PAGE_PRESENT)) in just as a curiosity, I'll update how that one looks as well. Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f172.google.com (mail-ob0-f172.google.com [209.85.214.172]) by kanga.kvack.org (Postfix) with ESMTP id 86A276B0035 for ; Tue, 5 Aug 2014 21:04:43 -0400 (EDT) Received: by mail-ob0-f172.google.com with SMTP id wn1so1310963obc.17 for ; Tue, 05 Aug 2014 18:04:43 -0700 (PDT) Received: from userp1040.oracle.com (userp1040.oracle.com. [156.151.31.81]) by mx.google.com with ESMTPS id y11si7790425oep.28.2014.08.05.18.04.42 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 05 Aug 2014 18:04:43 -0700 (PDT) Message-ID: <53E17F06.30401@oracle.com> Date: Tue, 05 Aug 2014 21:04:06 -0400 From: Sasha Levin MIME-Version: 1.0 Subject: Re: mm: BUG in unmap_page_range References: <53DD5F20.8010507@oracle.com> <20140805144439.GW10819@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins , Mel Gorman Cc: "linux-mm@kvack.org" , Andrew Morton , Dave Jones , LKML , "Kirill A. Shutemov" , Peter Zijlstra , Rik van Riel , Johannes Weiner , Cyrill Gorcunov Thanks Hugh, Mel. I've added both patches to my local tree and will update tomorrow with the weather. Also: On 08/05/2014 08:42 PM, Hugh Dickins wrote: > One thing I did wonder, though: at first I was reassured by the > VM_BUG_ON(!pte_present(pte)) you add to pte_mknuma(); but then thought > it would be better as VM_BUG_ON(!(val & _PAGE_PRESENT)), being stronger > - asserting that indeed we do not put NUMA hints on PROT_NONE areas. > (But I have not tested, perhaps such a VM_BUG_ON would actually fire.) I've added VM_BUG_ON(!(val & _PAGE_PRESENT)) in just as a curiosity, I'll update how that one looks as well. Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org