All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Oussama Jabbari <oussama.jabbari@gmail.com>
Cc: gregkh@linuxfoundation.org, sachin.kamat@linaro.org,
	lars@metafoo.de, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: adis16060: Fix coding style problem
Date: Thu, 07 Aug 2014 11:15:48 +0100	[thread overview]
Message-ID: <53E351D4.50103@kernel.org> (raw)
In-Reply-To: <1407344776-2838-1-git-send-email-oussama.jabbari@gmail.com>

On 06/08/14 18:06, Oussama Jabbari wrote:
> This patch fixes a warning from checkpatch.pl script :
> "WARNING: Missing a blank line after declarations"
> 
> Signed-off-by: Oussama Jabbari <oussama.jabbari@gmail.com>
Whilst I find it hard to care about this particular issue,
I'm accepting this mainly to avoid getting the same thing
sometime in the future!

Anyhow, a nicely formatted patch.  The only change I would
have suggested would be in the title which might as be more
specific.

[PATCH] staging:iio:adis16060 Add missing blank line after declaration.

Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.

J
> ---
> The reason of this patch is for completing one task
> of the Eudyptula Challenge.
> 
>  drivers/staging/iio/gyro/adis16060_core.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c
> index d5d395c..4c5869d 100644
> --- a/drivers/staging/iio/gyro/adis16060_core.c
> +++ b/drivers/staging/iio/gyro/adis16060_core.c
> @@ -180,6 +180,7 @@ static int adis16060_w_probe(struct spi_device *spi)
>  	int ret;
>  	struct iio_dev *indio_dev = adis16060_iio_dev;
>  	struct adis16060_state *st;
> +
>  	if (!indio_dev) {
>  		ret =  -ENODEV;
>  		goto error_ret;
> 

      reply	other threads:[~2014-08-07 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06 17:06 [PATCH] staging: iio: adis16060: Fix coding style problem Oussama Jabbari
2014-08-07 10:15 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E351D4.50103@kernel.org \
    --to=jic23@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oussama.jabbari@gmail.com \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.