All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] psplash: Adding support for systemd service files
@ 2014-08-08  9:09 Sujith H
  2014-08-08 18:07 ` Saul Wold
  0 siblings, 1 reply; 7+ messages in thread
From: Sujith H @ 2014-08-08  9:09 UTC (permalink / raw)
  To: openembedded-core; +Cc: Sujith H, Muzaffar Mahmood

From: Sujith H <Sujith_Haridasan@mentor.com>

If the DISTRO_FEATURES has systemd, then its better
to have corresponding service files associated with
the psplash. This change will help to do the same.

Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
---
 meta/recipes-core/psplash/files/psplash-quit.service  | 11 +++++++++++
 meta/recipes-core/psplash/files/psplash-start.service | 11 +++++++++++
 meta/recipes-core/psplash/psplash_git.bb              | 12 +++++++++++-
 3 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/psplash/files/psplash-quit.service
 create mode 100644 meta/recipes-core/psplash/files/psplash-start.service

diff --git a/meta/recipes-core/psplash/files/psplash-quit.service b/meta/recipes-core/psplash/files/psplash-quit.service
new file mode 100644
index 0000000..14bd499
--- /dev/null
+++ b/meta/recipes-core/psplash/files/psplash-quit.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Terminate Psplash Boot Screen
+After=psplash-start.service
+
+[Service]
+Type=oneshot
+ExecStart=/usr/bin/psplash-write QUIT
+TimeoutSec=20
+
+[Install]
+WantedBy=multi-user.target
diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
new file mode 100644
index 0000000..502b150
--- /dev/null
+++ b/meta/recipes-core/psplash/files/psplash-start.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Starts Psplash Boot screen
+Wants=systemd-vconsole-setup.service
+After=systemd-vconsole-setup.service systemd-udev-trigger.service systemd-udevd.service
+DefaultDependencies=no
+
+[Service]
+ExecStart=/usr/bin/psplash
+
+[Install]
+WantedBy=sysinit.target
diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
index 628ced4..16fa0ae 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -11,6 +11,8 @@ PR = "r15"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN} \
            file://psplash-init \
+           file://psplash-start.service \
+           file://psplash-quit.service \
            ${SPLASH_IMAGES}"
 
 SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
@@ -65,11 +67,14 @@ python __anonymous() {
 
 S = "${WORKDIR}/git"
 
-inherit autotools pkgconfig update-rc.d update-alternatives
+inherit autotools pkgconfig update-rc.d update-alternatives systemd
 
 ALTERNATIVE_PRIORITY = "100"
 ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
 
+SYSTEMD_PACKAGES = "${@base_contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
+SYSTEMD_SERVICE_${PN} = "${@base_contains('DISTRO_FEATURES','systemd','psplash-start.service psplash-quit.service','',d)}"
+
 python do_compile () {
     import shutil
 
@@ -103,6 +108,11 @@ do_install_append() {
 		install -m 0755 $i ${D}${bindir}/$i
 	done
 	rm -f ${D}${bindir}/psplash
+
+	if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)}; then
+                install -d ${D}${systemd_unitdir}/system
+                install -m 644 ${WORKDIR}/*.service ${D}/${systemd_unitdir}/system
+        fi
 }
 
 FILES_${PN} += "/mnt/.psplash"
-- 
1.8.4



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] psplash: Adding support for systemd service files
  2014-08-08  9:09 [PATCH] psplash: Adding support for systemd service files Sujith H
@ 2014-08-08 18:07 ` Saul Wold
  2014-08-11 10:00   ` sujith h
  0 siblings, 1 reply; 7+ messages in thread
From: Saul Wold @ 2014-08-08 18:07 UTC (permalink / raw)
  To: Sujith H, openembedded-core; +Cc: Sujith H, Muzaffar Mahmood

On 08/08/2014 02:09 AM, Sujith H wrote:
> From: Sujith H <Sujith_Haridasan@mentor.com>
>
> If the DISTRO_FEATURES has systemd, then its better
> to have corresponding service files associated with
> the psplash. This change will help to do the same.
>
Can you propose a patch to the psplash upstream which is part of the 
Yocto Project (send the patch to yocto@yoctoproject.org) and then we can 
do a psplash upgrade to include these files directly?

Thanks
	Sau!

> Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
> Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
> ---
>   meta/recipes-core/psplash/files/psplash-quit.service  | 11 +++++++++++
>   meta/recipes-core/psplash/files/psplash-start.service | 11 +++++++++++
>   meta/recipes-core/psplash/psplash_git.bb              | 12 +++++++++++-
>   3 files changed, 33 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-core/psplash/files/psplash-quit.service
>   create mode 100644 meta/recipes-core/psplash/files/psplash-start.service
>
> diff --git a/meta/recipes-core/psplash/files/psplash-quit.service b/meta/recipes-core/psplash/files/psplash-quit.service
> new file mode 100644
> index 0000000..14bd499
> --- /dev/null
> +++ b/meta/recipes-core/psplash/files/psplash-quit.service
> @@ -0,0 +1,11 @@
> +[Unit]
> +Description=Terminate Psplash Boot Screen
> +After=psplash-start.service
> +
> +[Service]
> +Type=oneshot
> +ExecStart=/usr/bin/psplash-write QUIT
> +TimeoutSec=20
> +
> +[Install]
> +WantedBy=multi-user.target
> diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
> new file mode 100644
> index 0000000..502b150
> --- /dev/null
> +++ b/meta/recipes-core/psplash/files/psplash-start.service
> @@ -0,0 +1,11 @@
> +[Unit]
> +Description=Starts Psplash Boot screen
> +Wants=systemd-vconsole-setup.service
> +After=systemd-vconsole-setup.service systemd-udev-trigger.service systemd-udevd.service
> +DefaultDependencies=no
> +
> +[Service]
> +ExecStart=/usr/bin/psplash
> +
> +[Install]
> +WantedBy=sysinit.target
> diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
> index 628ced4..16fa0ae 100644
> --- a/meta/recipes-core/psplash/psplash_git.bb
> +++ b/meta/recipes-core/psplash/psplash_git.bb
> @@ -11,6 +11,8 @@ PR = "r15"
>
>   SRC_URI = "git://git.yoctoproject.org/${BPN} \
>              file://psplash-init \
> +           file://psplash-start.service \
> +           file://psplash-quit.service \
>              ${SPLASH_IMAGES}"
>
>   SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
> @@ -65,11 +67,14 @@ python __anonymous() {
>
>   S = "${WORKDIR}/git"
>
> -inherit autotools pkgconfig update-rc.d update-alternatives
> +inherit autotools pkgconfig update-rc.d update-alternatives systemd
>
>   ALTERNATIVE_PRIORITY = "100"
>   ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
>
> +SYSTEMD_PACKAGES = "${@base_contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
> +SYSTEMD_SERVICE_${PN} = "${@base_contains('DISTRO_FEATURES','systemd','psplash-start.service psplash-quit.service','',d)}"
> +
>   python do_compile () {
>       import shutil
>
> @@ -103,6 +108,11 @@ do_install_append() {
>   		install -m 0755 $i ${D}${bindir}/$i
>   	done
>   	rm -f ${D}${bindir}/psplash
> +
> +	if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)}; then
> +                install -d ${D}${systemd_unitdir}/system
> +                install -m 644 ${WORKDIR}/*.service ${D}/${systemd_unitdir}/system
> +        fi
>   }
>
>   FILES_${PN} += "/mnt/.psplash"
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] psplash: Adding support for systemd service files
  2014-08-08 18:07 ` Saul Wold
@ 2014-08-11 10:00   ` sujith h
  2014-10-13  9:05     ` ChenQi
  0 siblings, 1 reply; 7+ messages in thread
From: sujith h @ 2014-08-11 10:00 UTC (permalink / raw)
  To: Saul Wold; +Cc: Sujith H, Muzaffar Mahmood, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 4278 bytes --]

On Fri, Aug 8, 2014 at 11:37 PM, Saul Wold <sgw@linux.intel.com> wrote:

> On 08/08/2014 02:09 AM, Sujith H wrote:
>
>> From: Sujith H <Sujith_Haridasan@mentor.com>
>>
>> If the DISTRO_FEATURES has systemd, then its better
>> to have corresponding service files associated with
>> the psplash. This change will help to do the same.
>>
>>  Can you propose a patch to the psplash upstream which is part of the
> Yocto Project (send the patch to yocto@yoctoproject.org) and then we can
> do a psplash upgrade to include these files directly?
>

Ok then I will submit the same patch to Yocto Project.

Thanks,
Sujith H

>
> Thanks
>         Sau!
>
>
>  Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
>> Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
>> ---
>>   meta/recipes-core/psplash/files/psplash-quit.service  | 11 +++++++++++
>>   meta/recipes-core/psplash/files/psplash-start.service | 11 +++++++++++
>>   meta/recipes-core/psplash/psplash_git.bb              | 12 +++++++++++-
>>   3 files changed, 33 insertions(+), 1 deletion(-)
>>   create mode 100644 meta/recipes-core/psplash/files/psplash-quit.service
>>   create mode 100644 meta/recipes-core/psplash/
>> files/psplash-start.service
>>
>> diff --git a/meta/recipes-core/psplash/files/psplash-quit.service
>> b/meta/recipes-core/psplash/files/psplash-quit.service
>> new file mode 100644
>> index 0000000..14bd499
>> --- /dev/null
>> +++ b/meta/recipes-core/psplash/files/psplash-quit.service
>> @@ -0,0 +1,11 @@
>> +[Unit]
>> +Description=Terminate Psplash Boot Screen
>> +After=psplash-start.service
>> +
>> +[Service]
>> +Type=oneshot
>> +ExecStart=/usr/bin/psplash-write QUIT
>> +TimeoutSec=20
>> +
>> +[Install]
>> +WantedBy=multi-user.target
>> diff --git a/meta/recipes-core/psplash/files/psplash-start.service
>> b/meta/recipes-core/psplash/files/psplash-start.service
>> new file mode 100644
>> index 0000000..502b150
>> --- /dev/null
>> +++ b/meta/recipes-core/psplash/files/psplash-start.service
>> @@ -0,0 +1,11 @@
>> +[Unit]
>> +Description=Starts Psplash Boot screen
>> +Wants=systemd-vconsole-setup.service
>> +After=systemd-vconsole-setup.service systemd-udev-trigger.service
>> systemd-udevd.service
>> +DefaultDependencies=no
>> +
>> +[Service]
>> +ExecStart=/usr/bin/psplash
>> +
>> +[Install]
>> +WantedBy=sysinit.target
>> diff --git a/meta/recipes-core/psplash/psplash_git.bb
>> b/meta/recipes-core/psplash/psplash_git.bb
>> index 628ced4..16fa0ae 100644
>> --- a/meta/recipes-core/psplash/psplash_git.bb
>> +++ b/meta/recipes-core/psplash/psplash_git.bb
>> @@ -11,6 +11,8 @@ PR = "r15"
>>
>>   SRC_URI = "git://git.yoctoproject.org/${BPN}
>> <http://git.yoctoproject.org/$%7BBPN%7D> \
>>              file://psplash-init \
>> +           file://psplash-start.service \
>> +           file://psplash-quit.service \
>>              ${SPLASH_IMAGES}"
>>
>>   SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
>> @@ -65,11 +67,14 @@ python __anonymous() {
>>
>>   S = "${WORKDIR}/git"
>>
>> -inherit autotools pkgconfig update-rc.d update-alternatives
>> +inherit autotools pkgconfig update-rc.d update-alternatives systemd
>>
>>   ALTERNATIVE_PRIORITY = "100"
>>   ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
>>
>> +SYSTEMD_PACKAGES = "${@base_contains('DISTRO_
>> FEATURES','systemd','${PN}','',d)}"
>> +SYSTEMD_SERVICE_${PN} = "${@base_contains('DISTRO_
>> FEATURES','systemd','psplash-start.service psplash-quit.service','',d)}"
>> +
>>   python do_compile () {
>>       import shutil
>>
>> @@ -103,6 +108,11 @@ do_install_append() {
>>                 install -m 0755 $i ${D}${bindir}/$i
>>         done
>>         rm -f ${D}${bindir}/psplash
>> +
>> +       if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)};
>> then
>> +                install -d ${D}${systemd_unitdir}/system
>> +                install -m 644 ${WORKDIR}/*.service
>> ${D}/${systemd_unitdir}/system
>> +        fi
>>   }
>>
>>   FILES_${PN} += "/mnt/.psplash"
>>
>>


-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info

[-- Attachment #2: Type: text/html, Size: 6311 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] psplash: Adding support for systemd service files
  2014-08-11 10:00   ` sujith h
@ 2014-10-13  9:05     ` ChenQi
  0 siblings, 0 replies; 7+ messages in thread
From: ChenQi @ 2014-10-13  9:05 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 5547 bytes --]

Does anybody know what's the current state of this issue?

Thanks,
Chen Qi

On 08/11/2014 06:00 PM, sujith h wrote:
>
>
>
> On Fri, Aug 8, 2014 at 11:37 PM, Saul Wold <sgw@linux.intel.com 
> <mailto:sgw@linux.intel.com>> wrote:
>
>     On 08/08/2014 02:09 AM, Sujith H wrote:
>
>         From: Sujith H <Sujith_Haridasan@mentor.com
>         <mailto:Sujith_Haridasan@mentor.com>>
>
>         If the DISTRO_FEATURES has systemd, then its better
>         to have corresponding service files associated with
>         the psplash. This change will help to do the same.
>
>     Can you propose a patch to the psplash upstream which is part of
>     the Yocto Project (send the patch to yocto@yoctoproject.org
>     <mailto:yocto@yoctoproject.org>) and then we can do a psplash
>     upgrade to include these files directly?
>
>
> Ok then I will submit the same patch to Yocto Project.
>
> Thanks,
> Sujith H
>
>
>     Thanks
>             Sau!
>
>
>         Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com
>         <mailto:muzaffar_mahmood@mentor.com>>
>         Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com
>         <mailto:Sujith_Haridasan@mentor.com>>
>         ---
>           meta/recipes-core/psplash/files/psplash-quit.service  | 11
>         +++++++++++
>           meta/recipes-core/psplash/files/psplash-start.service | 11
>         +++++++++++
>           meta/recipes-core/psplash/psplash_git.bb
>         <http://psplash_git.bb>              | 12 +++++++++++-
>           3 files changed, 33 insertions(+), 1 deletion(-)
>           create mode 100644
>         meta/recipes-core/psplash/files/psplash-quit.service
>           create mode 100644
>         meta/recipes-core/psplash/files/psplash-start.service
>
>         diff --git
>         a/meta/recipes-core/psplash/files/psplash-quit.service
>         b/meta/recipes-core/psplash/files/psplash-quit.service
>         new file mode 100644
>         index 0000000..14bd499
>         --- /dev/null
>         +++ b/meta/recipes-core/psplash/files/psplash-quit.service
>         @@ -0,0 +1,11 @@
>         +[Unit]
>         +Description=Terminate Psplash Boot Screen
>         +After=psplash-start.service
>         +
>         +[Service]
>         +Type=oneshot
>         +ExecStart=/usr/bin/psplash-write QUIT
>         +TimeoutSec=20
>         +
>         +[Install]
>         +WantedBy=multi-user.target
>         diff --git
>         a/meta/recipes-core/psplash/files/psplash-start.service
>         b/meta/recipes-core/psplash/files/psplash-start.service
>         new file mode 100644
>         index 0000000..502b150
>         --- /dev/null
>         +++ b/meta/recipes-core/psplash/files/psplash-start.service
>         @@ -0,0 +1,11 @@
>         +[Unit]
>         +Description=Starts Psplash Boot screen
>         +Wants=systemd-vconsole-setup.service
>         +After=systemd-vconsole-setup.service
>         systemd-udev-trigger.service systemd-udevd.service
>         +DefaultDependencies=no
>         +
>         +[Service]
>         +ExecStart=/usr/bin/psplash
>         +
>         +[Install]
>         +WantedBy=sysinit.target
>         diff --git a/meta/recipes-core/psplash/psplash_git.bb
>         <http://psplash_git.bb>
>         b/meta/recipes-core/psplash/psplash_git.bb <http://psplash_git.bb>
>         index 628ced4..16fa0ae 100644
>         --- a/meta/recipes-core/psplash/psplash_git.bb
>         <http://psplash_git.bb>
>         +++ b/meta/recipes-core/psplash/psplash_git.bb
>         <http://psplash_git.bb>
>         @@ -11,6 +11,8 @@ PR = "r15"
>
>           SRC_URI = "git://git.yoctoproject.org/${BPN}
>         <http://git.yoctoproject.org/$%7BBPN%7D> \
>                      file://psplash-init \
>         +           file://psplash-start.service \
>         +           file://psplash-quit.service \
>                      ${SPLASH_IMAGES}"
>
>           SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
>         @@ -65,11 +67,14 @@ python __anonymous() {
>
>           S = "${WORKDIR}/git"
>
>         -inherit autotools pkgconfig update-rc.d update-alternatives
>         +inherit autotools pkgconfig update-rc.d update-alternatives
>         systemd
>
>           ALTERNATIVE_PRIORITY = "100"
>           ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
>
>         +SYSTEMD_PACKAGES =
>         "${@base_contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
>         +SYSTEMD_SERVICE_${PN} =
>         "${@base_contains('DISTRO_FEATURES','systemd','psplash-start.service
>         psplash-quit.service','',d)}"
>         +
>           python do_compile () {
>               import shutil
>
>         @@ -103,6 +108,11 @@ do_install_append() {
>                         install -m 0755 $i ${D}${bindir}/$i
>                 done
>                 rm -f ${D}${bindir}/psplash
>         +
>         +       if
>         ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)};
>         then
>         +                install -d ${D}${systemd_unitdir}/system
>         +                install -m 644 ${WORKDIR}/*.service
>         ${D}/${systemd_unitdir}/system
>         +        fi
>           }
>
>           FILES_${PN} += "/mnt/.psplash"
>
>
>
>
> -- 
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
>
>


[-- Attachment #2: Type: text/html, Size: 11255 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] psplash: Adding support for systemd service files
  2014-08-12 15:07 ` Saul Wold
@ 2014-08-13  7:02   ` sujith h
  0 siblings, 0 replies; 7+ messages in thread
From: sujith h @ 2014-08-13  7:02 UTC (permalink / raw)
  To: Saul Wold; +Cc: yocto, Sujith H, Muzaffar Mahmood

[-- Attachment #1: Type: text/plain, Size: 4407 bytes --]

On Tue, Aug 12, 2014 at 8:37 PM, Saul Wold <sgw@linux.intel.com> wrote:

>
> Maybe I was not clear about this, this should be a patch to psplash
> upstream, not to the oe-core metadata.  Then once we merge the change to
> psplash we can update the pslash recipes.
>
> So the patch would be to add the 2 service files to psplash upstream.
>
> http://git.yoctoproject.org/cgit/cgit.cgi/psplash/
>
> Make Sense?
>

Yah it makes sense. I will do the same. Thanks for the feedback :)

Sujith H


>
> Sau!
>
>
>
> On 08/11/2014 03:00 AM, Sujith H wrote:
>
>> From: Sujith H <Sujith_Haridasan@mentor.com>
>>
>> If the DISTRO_FEATURES has systemd, then its better
>> to have corresponding service files associated with
>> the psplash. This change will help to do the same.
>>
>> Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
>> Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
>> ---
>>   meta/recipes-core/psplash/files/psplash-quit.service  | 11 +++++++++++
>>   meta/recipes-core/psplash/files/psplash-start.service | 11 +++++++++++
>>   meta/recipes-core/psplash/psplash_git.bb              | 12 +++++++++++-
>>   3 files changed, 33 insertions(+), 1 deletion(-)
>>   create mode 100644 meta/recipes-core/psplash/files/psplash-quit.service
>>   create mode 100644 meta/recipes-core/psplash/
>> files/psplash-start.service
>>
>> diff --git a/meta/recipes-core/psplash/files/psplash-quit.service
>> b/meta/recipes-core/psplash/files/psplash-quit.service
>> new file mode 100644
>> index 0000000..14bd499
>> --- /dev/null
>> +++ b/meta/recipes-core/psplash/files/psplash-quit.service
>> @@ -0,0 +1,11 @@
>> +[Unit]
>> +Description=Terminate Psplash Boot Screen
>> +After=psplash-start.service
>> +
>> +[Service]
>> +Type=oneshot
>> +ExecStart=/usr/bin/psplash-write QUIT
>> +TimeoutSec=20
>> +
>> +[Install]
>> +WantedBy=multi-user.target
>> diff --git a/meta/recipes-core/psplash/files/psplash-start.service
>> b/meta/recipes-core/psplash/files/psplash-start.service
>> new file mode 100644
>> index 0000000..502b150
>> --- /dev/null
>> +++ b/meta/recipes-core/psplash/files/psplash-start.service
>> @@ -0,0 +1,11 @@
>> +[Unit]
>> +Description=Starts Psplash Boot screen
>> +Wants=systemd-vconsole-setup.service
>> +After=systemd-vconsole-setup.service systemd-udev-trigger.service
>> systemd-udevd.service
>> +DefaultDependencies=no
>> +
>> +[Service]
>> +ExecStart=/usr/bin/psplash
>> +
>> +[Install]
>> +WantedBy=sysinit.target
>> diff --git a/meta/recipes-core/psplash/psplash_git.bb
>> b/meta/recipes-core/psplash/psplash_git.bb
>> index 628ced4..16fa0ae 100644
>> --- a/meta/recipes-core/psplash/psplash_git.bb
>> +++ b/meta/recipes-core/psplash/psplash_git.bb
>> @@ -11,6 +11,8 @@ PR = "r15"
>>
>>   SRC_URI = "git://git.yoctoproject.org/${BPN}
>> <http://git.yoctoproject.org/$%7BBPN%7D> \
>>              file://psplash-init \
>> +           file://psplash-start.service \
>> +           file://psplash-quit.service \
>>              ${SPLASH_IMAGES}"
>>
>>   SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
>> @@ -65,11 +67,14 @@ python __anonymous() {
>>
>>   S = "${WORKDIR}/git"
>>
>> -inherit autotools pkgconfig update-rc.d update-alternatives
>> +inherit autotools pkgconfig update-rc.d update-alternatives systemd
>>
>>   ALTERNATIVE_PRIORITY = "100"
>>   ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
>>
>> +SYSTEMD_PACKAGES = "${@base_contains('DISTRO_
>> FEATURES','systemd','${PN}','',d)}"
>> +SYSTEMD_SERVICE_${PN} = "${@base_contains('DISTRO_
>> FEATURES','systemd','psplash-start.service psplash-quit.service','',d)}"
>> +
>>   python do_compile () {
>>       import shutil
>>
>> @@ -103,6 +108,11 @@ do_install_append() {
>>                 install -m 0755 $i ${D}${bindir}/$i
>>         done
>>         rm -f ${D}${bindir}/psplash
>> +
>> +       if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)};
>> then
>> +                install -d ${D}${systemd_unitdir}/system
>> +                install -m 644 ${WORKDIR}/*.service
>> ${D}/${systemd_unitdir}/system
>> +        fi
>>   }
>>
>>   FILES_${PN} += "/mnt/.psplash"
>>
>>


-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info

[-- Attachment #2: Type: text/html, Size: 6344 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] psplash: Adding support for systemd service files
  2014-08-11 10:00 Sujith H
@ 2014-08-12 15:07 ` Saul Wold
  2014-08-13  7:02   ` sujith h
  0 siblings, 1 reply; 7+ messages in thread
From: Saul Wold @ 2014-08-12 15:07 UTC (permalink / raw)
  To: Sujith H, yocto; +Cc: Sujith H, Muzaffar Mahmood


Maybe I was not clear about this, this should be a patch to psplash 
upstream, not to the oe-core metadata.  Then once we merge the change to 
psplash we can update the pslash recipes.

So the patch would be to add the 2 service files to psplash upstream.

http://git.yoctoproject.org/cgit/cgit.cgi/psplash/

Make Sense?

Sau!


On 08/11/2014 03:00 AM, Sujith H wrote:
> From: Sujith H <Sujith_Haridasan@mentor.com>
>
> If the DISTRO_FEATURES has systemd, then its better
> to have corresponding service files associated with
> the psplash. This change will help to do the same.
>
> Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
> Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
> ---
>   meta/recipes-core/psplash/files/psplash-quit.service  | 11 +++++++++++
>   meta/recipes-core/psplash/files/psplash-start.service | 11 +++++++++++
>   meta/recipes-core/psplash/psplash_git.bb              | 12 +++++++++++-
>   3 files changed, 33 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-core/psplash/files/psplash-quit.service
>   create mode 100644 meta/recipes-core/psplash/files/psplash-start.service
>
> diff --git a/meta/recipes-core/psplash/files/psplash-quit.service b/meta/recipes-core/psplash/files/psplash-quit.service
> new file mode 100644
> index 0000000..14bd499
> --- /dev/null
> +++ b/meta/recipes-core/psplash/files/psplash-quit.service
> @@ -0,0 +1,11 @@
> +[Unit]
> +Description=Terminate Psplash Boot Screen
> +After=psplash-start.service
> +
> +[Service]
> +Type=oneshot
> +ExecStart=/usr/bin/psplash-write QUIT
> +TimeoutSec=20
> +
> +[Install]
> +WantedBy=multi-user.target
> diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
> new file mode 100644
> index 0000000..502b150
> --- /dev/null
> +++ b/meta/recipes-core/psplash/files/psplash-start.service
> @@ -0,0 +1,11 @@
> +[Unit]
> +Description=Starts Psplash Boot screen
> +Wants=systemd-vconsole-setup.service
> +After=systemd-vconsole-setup.service systemd-udev-trigger.service systemd-udevd.service
> +DefaultDependencies=no
> +
> +[Service]
> +ExecStart=/usr/bin/psplash
> +
> +[Install]
> +WantedBy=sysinit.target
> diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
> index 628ced4..16fa0ae 100644
> --- a/meta/recipes-core/psplash/psplash_git.bb
> +++ b/meta/recipes-core/psplash/psplash_git.bb
> @@ -11,6 +11,8 @@ PR = "r15"
>
>   SRC_URI = "git://git.yoctoproject.org/${BPN} \
>              file://psplash-init \
> +           file://psplash-start.service \
> +           file://psplash-quit.service \
>              ${SPLASH_IMAGES}"
>
>   SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
> @@ -65,11 +67,14 @@ python __anonymous() {
>
>   S = "${WORKDIR}/git"
>
> -inherit autotools pkgconfig update-rc.d update-alternatives
> +inherit autotools pkgconfig update-rc.d update-alternatives systemd
>
>   ALTERNATIVE_PRIORITY = "100"
>   ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
>
> +SYSTEMD_PACKAGES = "${@base_contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
> +SYSTEMD_SERVICE_${PN} = "${@base_contains('DISTRO_FEATURES','systemd','psplash-start.service psplash-quit.service','',d)}"
> +
>   python do_compile () {
>       import shutil
>
> @@ -103,6 +108,11 @@ do_install_append() {
>   		install -m 0755 $i ${D}${bindir}/$i
>   	done
>   	rm -f ${D}${bindir}/psplash
> +
> +	if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)}; then
> +                install -d ${D}${systemd_unitdir}/system
> +                install -m 644 ${WORKDIR}/*.service ${D}/${systemd_unitdir}/system
> +        fi
>   }
>
>   FILES_${PN} += "/mnt/.psplash"
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] psplash: Adding support for systemd service files
@ 2014-08-11 10:00 Sujith H
  2014-08-12 15:07 ` Saul Wold
  0 siblings, 1 reply; 7+ messages in thread
From: Sujith H @ 2014-08-11 10:00 UTC (permalink / raw)
  To: yocto; +Cc: Sujith H, Muzaffar Mahmood

From: Sujith H <Sujith_Haridasan@mentor.com>

If the DISTRO_FEATURES has systemd, then its better
to have corresponding service files associated with
the psplash. This change will help to do the same.

Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
---
 meta/recipes-core/psplash/files/psplash-quit.service  | 11 +++++++++++
 meta/recipes-core/psplash/files/psplash-start.service | 11 +++++++++++
 meta/recipes-core/psplash/psplash_git.bb              | 12 +++++++++++-
 3 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/psplash/files/psplash-quit.service
 create mode 100644 meta/recipes-core/psplash/files/psplash-start.service

diff --git a/meta/recipes-core/psplash/files/psplash-quit.service b/meta/recipes-core/psplash/files/psplash-quit.service
new file mode 100644
index 0000000..14bd499
--- /dev/null
+++ b/meta/recipes-core/psplash/files/psplash-quit.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Terminate Psplash Boot Screen
+After=psplash-start.service
+
+[Service]
+Type=oneshot
+ExecStart=/usr/bin/psplash-write QUIT
+TimeoutSec=20
+
+[Install]
+WantedBy=multi-user.target
diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
new file mode 100644
index 0000000..502b150
--- /dev/null
+++ b/meta/recipes-core/psplash/files/psplash-start.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Starts Psplash Boot screen
+Wants=systemd-vconsole-setup.service
+After=systemd-vconsole-setup.service systemd-udev-trigger.service systemd-udevd.service
+DefaultDependencies=no
+
+[Service]
+ExecStart=/usr/bin/psplash
+
+[Install]
+WantedBy=sysinit.target
diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
index 628ced4..16fa0ae 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -11,6 +11,8 @@ PR = "r15"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN} \
            file://psplash-init \
+           file://psplash-start.service \
+           file://psplash-quit.service \
            ${SPLASH_IMAGES}"
 
 SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
@@ -65,11 +67,14 @@ python __anonymous() {
 
 S = "${WORKDIR}/git"
 
-inherit autotools pkgconfig update-rc.d update-alternatives
+inherit autotools pkgconfig update-rc.d update-alternatives systemd
 
 ALTERNATIVE_PRIORITY = "100"
 ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
 
+SYSTEMD_PACKAGES = "${@base_contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
+SYSTEMD_SERVICE_${PN} = "${@base_contains('DISTRO_FEATURES','systemd','psplash-start.service psplash-quit.service','',d)}"
+
 python do_compile () {
     import shutil
 
@@ -103,6 +108,11 @@ do_install_append() {
 		install -m 0755 $i ${D}${bindir}/$i
 	done
 	rm -f ${D}${bindir}/psplash
+
+	if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)}; then
+                install -d ${D}${systemd_unitdir}/system
+                install -m 644 ${WORKDIR}/*.service ${D}/${systemd_unitdir}/system
+        fi
 }
 
 FILES_${PN} += "/mnt/.psplash"
-- 
1.8.4



^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-10-13  9:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-08  9:09 [PATCH] psplash: Adding support for systemd service files Sujith H
2014-08-08 18:07 ` Saul Wold
2014-08-11 10:00   ` sujith h
2014-10-13  9:05     ` ChenQi
2014-08-11 10:00 Sujith H
2014-08-12 15:07 ` Saul Wold
2014-08-13  7:02   ` sujith h

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.