From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH net v2 1/3] xen-netback: move NAPI
 add/remove calls
Date: Mon, 11 Aug 2014 14:59:52 +0100
Message-ID: <53E8CC58.10904__23726.9975049005$1407765707$gmane$org@citrix.com>
References: <1407515833-2550-1-git-send-email-wei.liu2@citrix.com>	<1407515833-2550-2-git-send-email-wei.liu2@citrix.com>	<53E8B874.8070906@citrix.com>
	<53E8BBCB.50308@citrix.com>	<53E8BE92.5070606@citrix.com>
	<53E8C1A8.4050302@citrix.com>
	<20140811134322.GE3249@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140811134322.GE3249@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: netdev@vger.kernel.org, xen-devel@lists.xen.org, Ian Campbell <ian.campbell@citrix.com>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 11/08/14 14:43, Wei Liu wrote:
> In short, there's no need to reorder disconnect logic and no need have a
> dedicated loop for netif_napi_del.

Not for now.  But I would prefer it if it was re-ordered.  And similarly
in xenvif_down(), irq_disable() should be before napi_disable().

David