From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 15 Aug 2014 11:29:24 -0600 Subject: [U-Boot] [PATCH v4 14/15] tegra: dts: Add serial port details In-Reply-To: References: <1407770874-12749-1-git-send-email-sjg@chromium.org> <1407770874-12749-15-git-send-email-sjg@chromium.org> <53EE3F14.1010804@wwwdotorg.org> Message-ID: <53EE4374.3080509@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/15/2014 11:25 AM, Simon Glass wrote: > Hi Stephen, > > On 15 August 2014 11:10, Stephen Warren wrote: >> On 08/11/2014 09:27 AM, Simon Glass wrote: >>> >>> Some Tegra device tree files do not include information about the serial >>> ports. Add this and also add information about the input clock speed. >>> >>> The console alias needs to be set up to indicate which port is used for >>> the console. >>> >>> Also add a binding file since this is missing. >> >> >>> diff --git a/arch/arm/dts/tegra114-dalmore.dts >>> b/arch/arm/dts/tegra114-dalmore.dts >> >> >>> aliases { >>> + console = &uart_d; >> >> >> Did the use of "console" get OK'd on the devicetree mailing list then? > > No, not yet. I copied on you the thread. I'm not necessarily expecting > a response. > >> >> I know we have this bug in the kernel DTs, but let's fix it here: phandle >> values should have <> around them: >> >> console = <&uart_d>; > > This is not a phandle though. Are you wanting to change that? The & syntax is a phandle isn't it? Or does plain &label expand to a string? If it does, then ignore my comment.