Re: [Qemu-devel] [Qemu-trivial] [PATCH v6 09/10] tcg: check return value of fopen()

From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: Richard Henderson <rth@twiddle.net>
Cc: kwolf@redhat.com, lkurusa@redhat.com,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-trivial@nongnu.org, jan.kiszka@siemens.com,
	riku.voipio@iki.fi, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, lcapitulino@redhat.com,
	stefanha@redhat.com, Li Liu <john.liuli@huawei.com>,
	luonengjun@huawei.com, pbonzini@redhat.com,
	peter.huangpeng@huawei.com, alex.bennee@linaro.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v6 09/10] tcg: check return value of fopen()
Date: Mon, 18 Aug 2014 14:21:32 +0800	[thread overview]
Message-ID: <53F19B6C.7070907@huawei.com> (raw)
In-Reply-To: <53EE3AFF.8020005@twiddle.net>

On 2014/8/16 0:53, Richard Henderson wrote:
> On 08/15/2014 05:03 AM, Michael Tokarev wrote:
>>>>       f = fopen("/tmp/op.log", "w");
>>
>> Gosh.  So why are we still use fixed filenames in /tmp?????
>> Every such use is a potential security holw... :(  Ughm.
>>
>> Can't we get rid of this somehow, by requiring a filename
>> parameter for example?
>
> It's in code that isn't compiled in by default.
>
> Better than taking a parameter, or doing something else one-off, I think it'd
> be best to dump this to the normal log file.  I.e. use qemu_log instead of fprintf.
>

Hmm, i agreed. I will get rid of this, and use qemu_log instead.
Thanks.:)