From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [Qemu-devel] [PATCH v3 1/2] contrib: add ivshmem client and server Date: Mon, 18 Aug 2014 14:09:42 +0200 Message-ID: <53F1ED06.9020408@6wind.com> References: <1407488118-11245-1-git-send-email-david.marchand@6wind.com> <1407488118-11245-2-git-send-email-david.marchand@6wind.com> <20140808145132.GC13382@stefanha-thinkpad.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Olivier Matz , kvm@vger.kernel.org, claudio.fontana@huawei.com, armbru@redhat.com, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca To: Stefan Hajnoczi Return-path: Received: from mail-wi0-f176.google.com ([209.85.212.176]:61178 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbaHRMJv (ORCPT ); Mon, 18 Aug 2014 08:09:51 -0400 Received: by mail-wi0-f176.google.com with SMTP id bs8so3593924wib.9 for ; Mon, 18 Aug 2014 05:09:50 -0700 (PDT) In-Reply-To: <20140808145132.GC13382@stefanha-thinkpad.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/08/2014 04:51 PM, Stefan Hajnoczi wrote: > On Fri, Aug 08, 2014 at 10:55:17AM +0200, David Marchand wrote: > > Looks good, a few minor comments: > >> diff --git a/contrib/ivshmem-client/Makefile b/contrib/ivshmem-client/Makefile >> new file mode 100644 >> index 0000000..eee97c6 >> --- /dev/null >> +++ b/contrib/ivshmem-client/Makefile >> @@ -0,0 +1,29 @@ > > CCed Peter Maydell for a second opinion, I'd suggest hooking up to > QEMU's top-level ./Makefile. QEMU does not do recursive make. > > The advantages of hooking up QEMU's Makefile are: > > 1. So that ivshmem client/server code is built by default (on supported > host platforms) and bitrot is avoided. > > 2. So that you don't have to duplicate rules.mak or any other build > infrastructure. > Ok, done. But in this case, should we really keep the files in contrib/ ? I used this directory but I am not too sure about this. Maybe hw/misc/ivshmem/ would be better ? The rest of your comments have been integrated in my tree. Is it preferred to send fixes aside the original patches ? or should I send a squashed version ? (I suppose the former is better as it is easier to read). Thanks Stefan. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJLl9-0003LY-Kc for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:10:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJLl2-0008JA-4l for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:09:59 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:40356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJLl1-0008J4-VF for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:09:52 -0400 Received: by mail-wi0-f174.google.com with SMTP id d1so3600259wiv.1 for ; Mon, 18 Aug 2014 05:09:50 -0700 (PDT) Message-ID: <53F1ED06.9020408@6wind.com> Date: Mon, 18 Aug 2014 14:09:42 +0200 From: David Marchand MIME-Version: 1.0 References: <1407488118-11245-1-git-send-email-david.marchand@6wind.com> <1407488118-11245-2-git-send-email-david.marchand@6wind.com> <20140808145132.GC13382@stefanha-thinkpad.redhat.com> In-Reply-To: <20140808145132.GC13382@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/2] contrib: add ivshmem client and server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Olivier Matz , kvm@vger.kernel.org, claudio.fontana@huawei.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca On 08/08/2014 04:51 PM, Stefan Hajnoczi wrote: > On Fri, Aug 08, 2014 at 10:55:17AM +0200, David Marchand wrote: > > Looks good, a few minor comments: > >> diff --git a/contrib/ivshmem-client/Makefile b/contrib/ivshmem-client/Makefile >> new file mode 100644 >> index 0000000..eee97c6 >> --- /dev/null >> +++ b/contrib/ivshmem-client/Makefile >> @@ -0,0 +1,29 @@ > > CCed Peter Maydell for a second opinion, I'd suggest hooking up to > QEMU's top-level ./Makefile. QEMU does not do recursive make. > > The advantages of hooking up QEMU's Makefile are: > > 1. So that ivshmem client/server code is built by default (on supported > host platforms) and bitrot is avoided. > > 2. So that you don't have to duplicate rules.mak or any other build > infrastructure. > Ok, done. But in this case, should we really keep the files in contrib/ ? I used this directory but I am not too sure about this. Maybe hw/misc/ivshmem/ would be better ? The rest of your comments have been integrated in my tree. Is it preferred to send fixes aside the original patches ? or should I send a squashed version ? (I suppose the former is better as it is easier to read). Thanks Stefan. -- David Marchand