From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kishon Vijay Abraham I <kishon@ti.com>
Date: Tue, 19 Aug 2014 21:08:00 +0530
Subject: [U-Boot] [UBOOT RFC PATCH 07/13] usb: gadget: g_dnl: Explicitly
 set the max packet size in descriptor
In-Reply-To: <20140818165646.4487059c@amdc2363>
References: <1408372115-4570-1-git-send-email-kishon@ti.com>
	<1408372115-4570-8-git-send-email-kishon@ti.com>
	<20140818143856.GF9662@saruman.home>
	<20140818165646.4487059c@amdc2363>
Message-ID: <53F36F58.7060308@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



On Monday 18 August 2014 08:26 PM, Lukasz Majewski wrote:
> Hi Kishon,
> 
>>> Explicity set the max packet size in the device descriptor to 0x40
>>> as specified in the device class specification for device firmware
>>> upgrade. Also changed debug to printf to explicitly notify the user
>>> if the device has been enumerated.
> 
> It seems like this patch slipped without my attention ...
> 
> Hence, I'd like to ask why you must hardcode the packet size here?

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU
Mode Device Descriptor), specifies the bMaxPacketSize0 can be  8,16,32,64. And
the value we get from gadget is 512. So hard coded it.

Thanks
Kishon