From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XJmJo-0007ZB-Ly
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 12:31:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XJmJh-0002vw-6W
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 12:31:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XJmJg-0002vd-Tp
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 12:31:25 -0400
Message-ID: <53F37BD6.4020200@redhat.com>
Date: Tue, 19 Aug 2014 12:31:18 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1408399520-12778-1-git-send-email-jsnow@redhat.com>
	<20140819161248.GI2383@work-vm>
In-Reply-To: <20140819161248.GI2383@work-vm>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 0/4] Adding -cdrom,
 -hd[abcd] and -drive file=... to Q35
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: kwolf@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com



On 08/19/2014 12:12 PM, Dr. David Alan Gilbert wrote:
> * John Snow (jsnow@redhat.com) wrote:
>
> <snip>
>
>> The changes appear to work well, but where I'd like some feedback
>> is what should happen if people do something like:
>>
>> qemu -M q35 -drive if=3Dide,file=3Dfedora.qcow2
>>
>> The code as presented here is not going to look for or attempt to
>> connect IDE devices, because it is now looking for /AHCI/ devices.
>
> What happens if you try it - does it just silently ignore that -drive?
> The ideal would be for something to moan about unused drives so people
> realise why it's broken; but I seem to remember form a previous discuss=
ion
> it's hard to do on all platforms.

With this patch, piix would continue to ignore AHCI and Q35 would ignore=20
IDE. piix and Q35 both can be corrected to look for either/or IDE/AHCI=20
and whine if you mix them. Q35 and piix both could be made to throw an=20
error if you specify drives that the board doesn't pick up (AHCI in the=20
case of piix if you have not specified that device, legacy IDE in the=20
case of Q35 until we add legacy mode support and the user specifies that=20
mode.)

I suggested to Markus in a different reply that I could add a little=20
flag to the drive list to help identify if any drives don't get picked=20
up at board spin-up time... But it sounds like it might not be quite so=20
simple.

I will wait to add error handling modes until there is perhaps some=20
consensus that the basic approach here is desirable.

--=20
=97js