From: "Jan Beulich" <jbeulich@suse.com>
To: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
mukesh.rathor@oracle.com
Cc: keir@xen.org, Aravind.Gopalakrishnan@amd.com,
suravee.suthikulpanit@amd.com
Subject: Re: [V0 PATCH 4/6] AMD-PVH: Do not get/set vlapic TPR
Date: Wed, 20 Aug 2014 13:11:50 +0100 [thread overview]
Message-ID: <53F49E9602000078000BAD79@mail.emea.novell.com> (raw)
In-Reply-To: <53F2A588.7080407@oracle.com>
>>> Boris Ostrovsky <boris.ostrovsky@oracle.com> 08/19/14 3:17 AM >>>
>On 08/15/2014 09:53 PM, Mukesh Rathor wrote:
>> --- a/xen/arch/x86/hvm/svm/svm.c
>> +++ b/xen/arch/x86/hvm/svm/svm.c
>> @@ -1052,7 +1052,7 @@ static void noreturn svm_do_resume(struct vcpu *v)
>> hvm_asid_flush_vcpu(v);
>> }
>>
>> - if ( !vcpu_guestmode )
>> + if ( !vcpu_guestmode && vcpu_vlapic(v)->regs )
>
>I think checking explicitly for PVH (i.e. is_pvh_domain()) would be
>better. Here and below, obviously.
Yeah, I guess so for now, as it'll make it easier to locate the place when
ultimately changing to more fine grained checks.
Jan
next prev parent reply other threads:[~2014-08-20 12:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 1:53 [V0 PATCH 0/6] AMD-PVH: xen domU support Mukesh Rathor
2014-08-16 1:53 ` [V0 PATCH 1/6] AMD-PVH: construct vmcb changes Mukesh Rathor
2014-08-18 9:10 ` Roger Pau Monné
2014-08-18 23:46 ` Mukesh Rathor
2014-08-19 0:59 ` Boris Ostrovsky
2014-08-19 1:10 ` Mukesh Rathor
2014-08-22 9:39 ` Jan Beulich
2014-08-16 1:53 ` [V0 PATCH 2/6] AMD-PVH: cpuid intercept Mukesh Rathor
2014-08-16 1:53 ` [V0 PATCH 3/6] AMD-PVH: call hvm_emulate_one instead of handle_mmio Mukesh Rathor
2014-08-22 9:50 ` Jan Beulich
2014-08-22 18:52 ` Mukesh Rathor
2014-08-25 7:10 ` Jan Beulich
2014-08-26 1:53 ` Mukesh Rathor
2014-08-26 7:17 ` Jan Beulich
2014-08-28 1:07 ` Mukesh Rathor
2014-08-28 7:09 ` Jan Beulich
2014-08-16 1:53 ` [V0 PATCH 4/6] AMD-PVH: Do not get/set vlapic TPR Mukesh Rathor
2014-08-19 1:16 ` Boris Ostrovsky
2014-08-20 12:11 ` Jan Beulich [this message]
2014-08-22 9:52 ` Jan Beulich
2014-08-16 1:53 ` [V0 PATCH 5/6] AMD-PVH: Support TSC_MODE_NEVER_EMULATE for PVH Mukesh Rathor
2014-08-19 1:38 ` Boris Ostrovsky
2014-08-19 1:43 ` Boris Ostrovsky
2014-08-19 1:43 ` Mukesh Rathor
2014-08-16 1:53 ` [V0 PATCH 6/6] AMD-PVH: enable pvh if requirements met Mukesh Rathor
2014-09-30 16:04 ` [V0 PATCH 0/6] AMD-PVH: xen domU support Roger Pau Monné
2014-09-30 21:38 ` Mukesh Rathor
2014-09-30 21:49 ` Mukesh Rathor
2014-12-13 2:58 [AMD PVH]: Partial/domU xen patches Mukesh Rathor
2014-12-13 2:58 ` [V0 PATCH 4/6] AMD-PVH: Do not get/set vlapic TPR Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F49E9602000078000BAD79@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=keir@xen.org \
--cc=mukesh.rathor@oracle.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.