From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBHN-0007Ar-Lx for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKBHI-0000Yk-NR for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:10:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBHI-0000Yc-7m for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:10:36 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJAX8b002280 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 15:10:35 -0400 Message-ID: <53F4F2A8.3010009@redhat.com> Date: Wed, 20 Aug 2014 13:10:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408557576-14574-1-git-send-email-mreitz@redhat.com> <1408557576-14574-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1408557576-14574-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="33XfQxpmNFTqQlBKOnV7CGpQ8gNeoblaC" Subject: Re: [Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --33XfQxpmNFTqQlBKOnV7CGpQ8gNeoblaC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/20/2014 11:59 AM, Max Reitz wrote: > Currently, the QemuOpts object opts is leaked if anything fails from it= s > creation up to and including the image repair block. Fix this by freein= g > that object in the fail path. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --33XfQxpmNFTqQlBKOnV7CGpQ8gNeoblaC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT9PKoAAoJEKeha0olJ0NqE5UH/iGmoD1y8EKn17kb/hyoELkx cheUOdAViMqePHsbz8tjRgVD6KgmbNr9lZVD084jZDKb9IBhbAlScqoTj4v7vTKG BxhRlCj6wRjHCWLQBW5jHNoYAXjmFzY0Z8nneRC+E6RJOcFTFG42S/Tr111P6BGq lSJ6UYL9QvzW+xfpbC/n2FD7WuOWQUw2ENplifoc9isqv6YoExlYtrQxvmUo2soi kFcyfhEH12m1jMZyr9i5c536liq1zE3IJ471c0GN2WLmF+KbBBzWaA6uVWTZfOtl oU8ztqbQQT2B2c/v723fviPw/ltHZEkaFX5PW84wIh7H2jp613bFoqTYsCAdf54= =HT4T -----END PGP SIGNATURE----- --33XfQxpmNFTqQlBKOnV7CGpQ8gNeoblaC--