From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBXe-00017O-DT for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:27:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKBXZ-0006MC-CE for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:27:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBXZ-0006Lr-4g for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:27:25 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJRO9s021785 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 15:27:24 -0400 Message-ID: <53F4F69B.8050306@redhat.com> Date: Wed, 20 Aug 2014 13:27:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408557576-14574-1-git-send-email-mreitz@redhat.com> <1408557576-14574-4-git-send-email-mreitz@redhat.com> <53F4F58C.1050205@redhat.com> In-Reply-To: <53F4F58C.1050205@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Vedda6xal6RTP2OUn4usv9p2m5e1sMicA" Subject: Re: [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Vedda6xal6RTP2OUn4usv9p2m5e1sMicA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/20/2014 01:22 PM, Eric Blake wrote: > On 08/20/2014 11:59 AM, Max Reitz wrote: >> Being able to set the overlap-check option to a string and then refine= >> it via the overlap-check.* options is a nice idea for the command line= >> but does not work so well for non-flattened dicts. In that case, one c= an >> only specify either but not both, so add a field to overlap-check.* >> which does the same as directly specifying overlap-check but can be us= ed >> in conjunction with the other fields in non-flattened dicts. >> >> Signed-off-by: Max Reitz >> --- >> block/qcow2.c | 24 ++++++++++++++++++++++-- >> block/qcow2.h | 1 + >> 2 files changed, 23 insertions(+), 2 deletions(-) >=20 > Okay, I see where this is headed. The QMP will allow either > 'overlap-check':'all' (resolve all defaults according to a template > name), or 'overlap-check':{'template':'all','inactive-l1':'none'} (that= > is, a struct, where the struct also sets a default but also provides > per-item overrides). It took me a couple of reads of this in tandem > with 4/4, but it looks correct. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Vedda6xal6RTP2OUn4usv9p2m5e1sMicA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT9PabAAoJEKeha0olJ0Nqd7UIAI63fjc+kju1Pk5j22BCEDWE dwkfBXGxmNAB0C2cATN187VFr5AYnzH2/aqx3+ip4a4U/r8CW0XmAdKFBDEaox04 fiFnJOhrBeICyHjYUcFE3R94Y574jsEkmXGjBC3AOLxm4Im3B5okfkG8uNcMz9Qv rced4HXEBDPJ7PyGEsTJoBeZObxNWpBNPbjgaYSJ3iVoBMpy0RbRZwqxJzxB5SzG W8g3/q1mguiPgdn69fqBxOZS9Ze18DqUWzlmm5VrQNitBXf5YW1362WEXgbAaIzr D8DWDZUWBiifTFS+CxJONCwBOPGMhkXksOn0A6MfvMW/FbOJGHEaq6Wtrq+x40I= =CVYB -----END PGP SIGNATURE----- --Vedda6xal6RTP2OUn4usv9p2m5e1sMicA--