From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option
Date: Wed, 20 Aug 2014 21:30:51 +0200 [thread overview]
Message-ID: <53F4F76B.3050805@redhat.com> (raw)
In-Reply-To: <53F4F58C.1050205@redhat.com>
On 20.08.2014 21:22, Eric Blake wrote:
> On 08/20/2014 11:59 AM, Max Reitz wrote:
>> Being able to set the overlap-check option to a string and then refine
>> it via the overlap-check.* options is a nice idea for the command line
>> but does not work so well for non-flattened dicts. In that case, one can
>> only specify either but not both, so add a field to overlap-check.*
>> which does the same as directly specifying overlap-check but can be used
>> in conjunction with the other fields in non-flattened dicts.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> block/qcow2.c | 24 ++++++++++++++++++++++--
>> block/qcow2.h | 1 +
>> 2 files changed, 23 insertions(+), 2 deletions(-)
>>
>> diff --git a/block/qcow2.c b/block/qcow2.c
>> index c64d611..c6099b5 100644
>> --- a/block/qcow2.c
>> +++ b/block/qcow2.c
>> @@ -403,6 +403,12 @@ static QemuOptsList qcow2_runtime_opts = {
>> "templates (none, constant, cached, all)",
>> },
>> {
>> + .name = QCOW2_OPT_OVERLAP_TEMPLATE,
>> + .type = QEMU_OPT_STRING,
>> + .help = "Selects which overlap checks to perform from a range of "
>> + "templates (none, constant, cached, all)",
>> + },
>> + {
> Okay, I see where this is headed. The QMP will allow either
> 'overlap-check':'all' (resolve all defaults according to a template
> name), or 'overlap-check':{'template':'all','inactive-l1':'none'} (that
> is, a struct, where the struct also sets a default but also provides
> per-item overrides).
Yes, it's my fault for not thinking about how well the second case would
work for non-flattened dicts when I originally introduced these options.
Max
> It took me a couple of reads of this in tandem
> with 4/4, but it looks correct.
next prev parent reply other threads:[~2014-08-20 19:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 17:59 [Qemu-devel] [PATCH 0/4] qapi/block-core: Add "new" qcow2 options Max Reitz
2014-08-20 17:59 ` [Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open() Max Reitz
2014-08-20 19:10 ` Eric Blake
2014-08-21 17:54 ` Benoît Canet
2014-08-20 17:59 ` [Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions Max Reitz
2014-08-20 19:15 ` Eric Blake
2014-08-20 17:59 ` [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option Max Reitz
2014-08-20 19:22 ` Eric Blake
2014-08-20 19:27 ` Eric Blake
2014-08-20 19:30 ` Max Reitz [this message]
2014-08-20 17:59 ` [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options Max Reitz
2014-08-20 19:36 ` Eric Blake
2014-08-20 19:38 ` Max Reitz
2014-08-20 19:45 ` Eric Blake
2014-09-17 13:12 ` [Qemu-devel] [PATCH 0/4] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4F76B.3050805@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.