From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBgP-0000fy-TJ for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:36:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKBgK-0000so-V0 for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:36:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBgK-0000sk-Le for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:36:28 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJaRaJ011116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 15:36:28 -0400 Message-ID: <53F4F8BB.8050105@redhat.com> Date: Wed, 20 Aug 2014 13:36:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408557576-14574-1-git-send-email-mreitz@redhat.com> <1408557576-14574-5-git-send-email-mreitz@redhat.com> In-Reply-To: <1408557576-14574-5-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QIjFU3nCPOMIB60PvrLTB1n3mrjmlvv0W" Subject: Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QIjFU3nCPOMIB60PvrLTB1n3mrjmlvv0W Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/20/2014 11:59 AM, Max Reitz wrote: > qcow2 supports more than four options by now, add the new options > (overlap check mode and metadata cache size) >=20 > Signed-off-by: Max Reitz > --- > qapi/block-core.json | 79 ++++++++++++++++++++++++++++++++++++++++++++= +++++++- > 1 file changed, 78 insertions(+), 1 deletion(-) >=20 > +## > +# @Qcow2OverlapCheckFlags > +# > +# Structure of flags for each metadata structure. Setting a field to '= true' > +# makes qemu guard that structure against unintended overwriting. The = default > +# value is chosen according to the template given. > +# > +# @template: Specifies a template mode which can be adjusted using the= other > +# flags, defaults to 'cached' > +# Might be worth mentioning the other fields by name, but that's minor. > +{ 'union': 'Qcow2OverlapChecks', > + 'discriminator': {}, > + 'data': { 'flags': 'Qcow2OverlapCheckFlags', > + 'mode': 'Qcow2OverlapCheckMode' } } > + Slick :) So patch 3/4 added a new commandline option overlap-check.template=3Dstr which behaves identically to overlap-check=3Dstr; the short form is the enum branch of this union, the= long form is the struct form. The command line parser has to deal with both options being given (and errors out if they don't match), while QMP does not. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QIjFU3nCPOMIB60PvrLTB1n3mrjmlvv0W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT9Pi7AAoJEKeha0olJ0NqOn8H/i9AfRE4P5o9ajT9W5iSnCrN YiRwNv00Yza28+T6Ah8N6uoKcMXFXcV0cGAPBJlApLHphqTR0QNcjf+3Kv8aIisY I+YCkkNNnAkP3JcLx4lbQRDYDofzZ5KscEdU4Ip+pHG2VdUVM3NNWxaW+ETrNUYv 6hOzCGhO0gZ9tnQ1jOAz3lZdLkbXQNqSuJ/mR+Frs+byi+xnDo0usHp4w3T8gYfc OrQxWgjY43xB7rUfcLZJ1RUFImRbiPl94Rfh/O/k2WdYAlwkQveoBQPvDrtXcqPv CHWYUX6NLCxF4q4HR7FJP5snfxDNklF66lFIzR9pv/bJG1xra7TJfTWXmuYnZcY= =m72T -----END PGP SIGNATURE----- --QIjFU3nCPOMIB60PvrLTB1n3mrjmlvv0W--