From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBpc-00060b-L1 for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:46:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKBpX-0003eg-Lr for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:46:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBpX-0003ea-Cr for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:45:59 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJjwxH030262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 15:45:58 -0400 Message-ID: <53F4FAF6.3020702@redhat.com> Date: Wed, 20 Aug 2014 13:45:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408557576-14574-1-git-send-email-mreitz@redhat.com> <1408557576-14574-5-git-send-email-mreitz@redhat.com> <53F4F8BB.8050105@redhat.com> <53F4F94E.1050909@redhat.com> In-Reply-To: <53F4F94E.1050909@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e5xndk3taVglJo2WFK5vl9LHVOnfTDGuu" Subject: Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e5xndk3taVglJo2WFK5vl9LHVOnfTDGuu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/20/2014 01:38 PM, Max Reitz wrote: >>> +# Structure of flags for each metadata structure. Setting a field to= >>> 'true' >>> +# makes qemu guard that structure against unintended overwriting. >>> The default >>> +# value is chosen according to the template given. >>> +# >>> +# @template: Specifies a template mode which can be adjusted using >>> the other >>> +# flags, defaults to 'cached' >>> +# >> Might be worth mentioning the other fields by name, but that's minor. >=20 > Well, there were so many and it would've just been "X: Prevent > unintended writes to X". Bike-shedding ahead: maybe avoid the duplication by listing things in a list, such as: # @template: #optional Specify the template that controls the defaults for all other fields (defaults to 'cached') # @main-header, @active-l1, @active-l2, ...: #optional Specify a specific override of whether to prevent unintended writes to that data section (defaults determined by @template) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --e5xndk3taVglJo2WFK5vl9LHVOnfTDGuu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT9Pr2AAoJEKeha0olJ0NqPo0H/RwD3AcX7laAGrNU0yNF8UPd rSV1vxB5VSBJYk/JW986oDkaOjhM8vyHGEu92/r+wtZ0ylYXfV8wpQUrDCGEmcJJ VGlZNBsdyF2K019xxJeDWosdukYW3wugw5heh8rE1Mg0eaRw58eMcv4ka7Tq8lSP JQGQOqW7Fup8UuHS+w4jaVbL73APHuwcqPoijpa8c0kMeM+dpoRcmMh8mBM0tNXt +s++CDSgZfjdPBXBmUGIOfsFLqriHd+ohMtlI7V6AQL+G2xZc9jyNjPpScVTEyGV AzG0416vW74nPHHoH1w8oQ3Ma/PgHz2r1U+ZzWPnh6DwA7W/AHBK6Tt0opusy80= =F6P3 -----END PGP SIGNATURE----- --e5xndk3taVglJo2WFK5vl9LHVOnfTDGuu--