From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755234AbaHUNoz (ORCPT ); Thu, 21 Aug 2014 09:44:55 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:44248 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755084AbaHUNox (ORCPT ); Thu, 21 Aug 2014 09:44:53 -0400 Message-ID: <53F5F7BF.6040809@ti.com> Date: Thu, 21 Aug 2014 16:44:31 +0300 From: Tero Kristo User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Nishanth Menon , Mike Turquette CC: , , Subject: Re: [PATCH 0/2] clk: ti: Fix up error checks in set_rate (and div 0 error) References: <1408381015-16042-1-git-send-email-nm@ti.com> In-Reply-To: <1408381015-16042-1-git-send-email-nm@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2014 07:56 PM, Nishanth Menon wrote: > Hi, > The following patches are based on v3.17-rc1 > Prior to this series: http://slexy.org/view/s20QH6PW4x (notice the /0 div error spam at initial boot log) > After this series: http://slexy.org/view/s20tPNXPf4 Yeah, valid findings. However, you did not root-cause the problem, just added a bandaid for the most obvious errors. I will queue these patches for 3.17-rc fixes anyway, but will post an actual fix in a bit. -Tero > > Nishanth Menon (2): > clk: ti: divider: Provide error check for incoming parameters in > set_rate > clk: ti: dra7-atl: Provide error check for incoming parameters in > set_rate > > drivers/clk/ti/clk-dra7-atl.c | 6 +++++- > drivers/clk/ti/divider.c | 7 ++++++- > 2 files changed, 11 insertions(+), 2 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCH 0/2] clk: ti: Fix up error checks in set_rate (and div 0 error) Date: Thu, 21 Aug 2014 16:44:31 +0300 Message-ID: <53F5F7BF.6040809@ti.com> References: <1408381015-16042-1-git-send-email-nm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1408381015-16042-1-git-send-email-nm@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Nishanth Menon , Mike Turquette Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 08/18/2014 07:56 PM, Nishanth Menon wrote: > Hi, > The following patches are based on v3.17-rc1 > Prior to this series: http://slexy.org/view/s20QH6PW4x (notice the /0 div error spam at initial boot log) > After this series: http://slexy.org/view/s20tPNXPf4 Yeah, valid findings. However, you did not root-cause the problem, just added a bandaid for the most obvious errors. I will queue these patches for 3.17-rc fixes anyway, but will post an actual fix in a bit. -Tero > > Nishanth Menon (2): > clk: ti: divider: Provide error check for incoming parameters in > set_rate > clk: ti: dra7-atl: Provide error check for incoming parameters in > set_rate > > drivers/clk/ti/clk-dra7-atl.c | 6 +++++- > drivers/clk/ti/divider.c | 7 ++++++- > 2 files changed, 11 insertions(+), 2 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: t-kristo@ti.com (Tero Kristo) Date: Thu, 21 Aug 2014 16:44:31 +0300 Subject: [PATCH 0/2] clk: ti: Fix up error checks in set_rate (and div 0 error) In-Reply-To: <1408381015-16042-1-git-send-email-nm@ti.com> References: <1408381015-16042-1-git-send-email-nm@ti.com> Message-ID: <53F5F7BF.6040809@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/18/2014 07:56 PM, Nishanth Menon wrote: > Hi, > The following patches are based on v3.17-rc1 > Prior to this series: http://slexy.org/view/s20QH6PW4x (notice the /0 div error spam at initial boot log) > After this series: http://slexy.org/view/s20tPNXPf4 Yeah, valid findings. However, you did not root-cause the problem, just added a bandaid for the most obvious errors. I will queue these patches for 3.17-rc fixes anyway, but will post an actual fix in a bit. -Tero > > Nishanth Menon (2): > clk: ti: divider: Provide error check for incoming parameters in > set_rate > clk: ti: dra7-atl: Provide error check for incoming parameters in > set_rate > > drivers/clk/ti/clk-dra7-atl.c | 6 +++++- > drivers/clk/ti/divider.c | 7 ++++++- > 2 files changed, 11 insertions(+), 2 deletions(-) >