[Buildroot] [PATCH 1/1] package/ltris: fix linking with intl

[Buildroot] [PATCH 1/1] package/ltris: fix linking with intl

[Romain Naour]

ltris doen't build with (e)glibc toolchain since commit 454a41016f2f074b69e2c677f4749c213c653e86
when gettext package is selected.

With (e)glibc libintl is provided by the libc whereas with uClibc it's provided by gettext.

Linking with intl is only needed if the toolchain needs gettext and locale is set.

Fixes:
http://autobuild.buildroot.net/results/821/82128cb9f5cd6ae2595a8302462f1b5719dad9f7/build-end.log

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/ltris/ltris.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ltris/ltris.mk b/package/ltris/ltris.mk
index 75b6ad0..c9fe5c7 100644
--- a/package/ltris/ltris.mk
+++ b/package/ltris/ltris.mk
@@ -21,7 +21,7 @@ else
 LTRIS_CONF_OPT += --disable-audio
 endif
 
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
+ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 LTRIS_DEPENDENCIES += gettext
 LTRIS_CONF_ENV += LIBS=-lintl
 endif
-- 
1.9.3

[Buildroot] [PATCH 1/1] package/ltris: fix linking with intl

[Thomas Petazzoni]

Dear Romain Naour,

On Tue, 19 Aug 2014 19:43:56 +0200, Romain Naour wrote:
> ltris doen't build with (e)glibc toolchain since commit 454a41016f2f074b69e2c677f4749c213c653e86
> when gettext package is selected.
> 
> With (e)glibc libintl is provided by the libc whereas with uClibc it's provided by gettext.
> 
> Linking with intl is only needed if the toolchain needs gettext and locale is set.
> 
> Fixes:
> http://autobuild.buildroot.net/results/821/82128cb9f5cd6ae2595a8302462f1b5719dad9f7/build-end.log
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/ltris/ltris.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks. However, it would be good if your commit logs were
wrapped to a more reasonable length.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] package/ltris: fix linking with intl

[Romain Naour]

Hi Thomas,

Le 21/08/2014 15:36, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
> 
> On Tue, 19 Aug 2014 19:43:56 +0200, Romain Naour wrote:
>> ltris doen't build with (e)glibc toolchain since commit 454a41016f2f074b69e2c677f4749c213c653e86
>> when gettext package is selected.
>>
>> With (e)glibc libintl is provided by the libc whereas with uClibc it's provided by gettext.
>>
>> Linking with intl is only needed if the toolchain needs gettext and locale is set.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/821/82128cb9f5cd6ae2595a8302462f1b5719dad9f7/build-end.log
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>>  package/ltris/ltris.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks. However, it would be good if your commit logs were
> wrapped to a more reasonable length.
> 
Sorry for that, I'll be more careful.

Also xscreensaver and procps-ng have the same problem, I'll send a patch for them.

Best regards,
Romain