From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [v4][PATCH 2/9] xen:x86: define a new hypercall to
 get RMRR mappings
Date: Fri, 22 Aug 2014 12:36:45 +0100
Message-ID: <53F7476D020000780002CB06@mail.emea.novell.com>
References: <1408702186-24432-1-git-send-email-tiejun.chen@intel.com>
	<1408702186-24432-3-git-send-email-tiejun.chen@intel.com>
	<53F7212A.2030003@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53F7212A.2030003@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, ian.campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, kevin.tian@intel.com, Tiejun Chen <tiejun.chen@intel.com>, yang.z.zhang@intel.com
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>> On 22.08.14 at 12:53, <andrew.cooper3@citrix.com> wrote:
> On 22/08/14 11:09, Tiejun Chen wrote:
>> +    /* PFN of the current mapping of the page. */
>> +    xen_pfn_t pfn;
>> +    /* Number of the current mapping pages. */
>> +    xen_ulong_t count;
>> +};
> 
> This struct marks a range, but the fields don't make it clear.  I would
> suggest "start" and "nr_frames" as names.

Perhaps "start_pfn" to be even more explicit (and not just
depend on the field's type), and then maybe also "nr_pfns"
or "nr_pages".

Jan