From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLXZ0-00068g-Bh for qemu-devel@nongnu.org; Sun, 24 Aug 2014 09:10:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLXYv-0006ih-2Q for qemu-devel@nongnu.org; Sun, 24 Aug 2014 09:10:30 -0400 Message-ID: <53F9E43D.2020103@msgid.tls.msk.ru> Date: Sun, 24 Aug 2014 17:10:21 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1408537634-3812-1-git-send-email-ben@xrsa.net> <53F9D55D.6060804@msgid.tls.msk.ru> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman Cc: qemu-trivial@nongnu.org, Tamir Shomer , qemu-devel@nongnu.org, Ben Draper , Stefan Hajnoczi , Yan Vugenfirer 24.08.2014 16:28, Dmitry Fleytman wrote: > Hi Michael, >=20 > I=92m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC=92= ing me. Maybe you can add yourself to MAINTAINERS file as well? :) I dunno if that's actually needed, but at least this should stop "strain" patches like this to be sent to -trivial alone... ;) > I think this patch is correct and needed. >=20 > As we saw a few times already on different operating systems, > vmware drivers expect short packets to be padded as required > by corresponding RFC. Therefore this patch fixes a real bug. Okay, since there's no entry for vmxnet in MAINTAINERS, and with your blessing, and since this is a rather specific device which is not in common use, I'll apply it to -trivial, for now, unless you want to pick it up and send a pull request for it. Given your description, I think it should be Cc: qemu-stable@. > Reviewed-by: Dmitry Fleytman Thanks, /mjt