From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v4][PATCH 2/9] xen:x86: define a new hypercall to get RMRR mappings Date: Mon, 25 Aug 2014 19:03:45 +0800 Message-ID: <53FB1811.6080204@intel.com> References: <1408702186-24432-1-git-send-email-tiejun.chen@intel.com> <1408702186-24432-3-git-send-email-tiejun.chen@intel.com> <53F7212A.2030003@citrix.com> <53F7476D020000780002CB06@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53F7476D020000780002CB06@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Andrew Cooper , ian.campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, kevin.tian@intel.com, yang.z.zhang@intel.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 2014/8/22 19:36, Jan Beulich wrote: >>>> On 22.08.14 at 12:53, wrote: >> On 22/08/14 11:09, Tiejun Chen wrote: >>> + /* PFN of the current mapping of the page. */ >>> + xen_pfn_t pfn; >>> + /* Number of the current mapping pages. */ >>> + xen_ulong_t count; >>> +}; >> >> This struct marks a range, but the fields don't make it clear. I would >> suggest "start" and "nr_frames" as names. > > Perhaps "start_pfn" to be even more explicit (and not just > depend on the field's type), and then maybe also "nr_pfns" > or "nr_pages". > Okay, I will go this combo, 'start_pfn' and 'nr_pages'. Thanks Tiejun