From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Sander Eikelenboom <linux@eikelenboom.it>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Xen-unstable: Regression (on AMD) host boot stuck on (XEN) testing the IO APIC.......................
Date: Tue, 26 Aug 2014 08:45:17 +0100 [thread overview]
Message-ID: <53FC572D020000780002D781@mail.emea.novell.com> (raw)
In-Reply-To: <53FC54A6020000780002D776@mail.emea.novell.com>
>>> On 26.08.14 at 09:34, <JBeulich@suse.com> wrote:
> Considering how early this is, the only theory I have is that
> rcu_pending() may end up constantly returning true, thus always
> causing RCU_SOFTIRQ to get raised, not allowing the loop in
> __do_softirq() to ever exit. If that's the case, we seem to have
> two options:
> - pass into __print_IO_APIC() whether it's being called from a key
> handler
> - only call process_pending_softirqs() when system_state >=
> SYS_STATE_smp_boot
>
> Personally I'd prefer the former option.
So here's a patch implementing that (the issue clearly isn't limited
to AMD).
Jan
x86/IO-APIC: don't process softirqs during early boot
Commit e13b320399 ("x86/irq: process softirqs in irq keyhandlers")
made this unconditional, but the boot time use of __print_IO_APIC()
(when "apic_verbosity=debug" was given) can't tolerate that.
Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -1092,7 +1092,7 @@ static inline void UNEXPECTED_IO_APIC(vo
{
}
-static void /*__init*/ __print_IO_APIC(void)
+static void /*__init*/ __print_IO_APIC(bool_t boot)
{
int apic, i;
union IO_APIC_reg_00 reg_00;
@@ -1113,7 +1113,8 @@ static void /*__init*/ __print_IO_APIC(v
printk(KERN_INFO "testing the IO APIC.......................\n");
for (apic = 0; apic < nr_ioapics; apic++) {
- process_pending_softirqs();
+ if ( !boot )
+ process_pending_softirqs();
if (!nr_ioapic_entries[apic])
continue;
@@ -1219,7 +1220,7 @@ static void /*__init*/ __print_IO_APIC(v
for (i = 0; i < nr_irqs_gsi; i++) {
struct irq_pin_list *entry = irq_2_pin + i;
- if ( !(i & 0x1f) )
+ if ( !boot && !(i & 0x1f) )
process_pending_softirqs();
if (entry->pin < 0)
@@ -1242,12 +1243,12 @@ static void /*__init*/ __print_IO_APIC(v
static void __init print_IO_APIC(void)
{
if (apic_verbosity != APIC_QUIET)
- __print_IO_APIC();
+ __print_IO_APIC(1);
}
static void _print_IO_APIC_keyhandler(unsigned char key)
{
- __print_IO_APIC();
+ __print_IO_APIC(0);
}
static struct keyhandler print_IO_APIC_keyhandler = {
.diagnostic = 1,
next prev parent reply other threads:[~2014-08-26 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 17:12 Xen-unstable: Regression (on AMD) host boot stuck on (XEN) testing the IO APIC Sander Eikelenboom
2014-08-25 17:54 ` Andrew Cooper
2014-08-25 18:25 ` Sander Eikelenboom
2014-08-26 7:34 ` Jan Beulich
2014-08-26 7:45 ` Jan Beulich [this message]
2014-08-26 9:32 ` Andrew Cooper
2014-08-26 10:29 ` Sander Eikelenboom
2014-08-26 9:00 ` Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC572D020000780002D781@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.