From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757443AbaHZKwO (ORCPT ); Tue, 26 Aug 2014 06:52:14 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:54985 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754359AbaHZKwM (ORCPT ); Tue, 26 Aug 2014 06:52:12 -0400 Message-ID: <53FC66CD.8040800@ti.com> Date: Tue, 26 Aug 2014 13:51:57 +0300 From: Tomi Valkeinen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Geert Uytterhoeven , Julia Lawall CC: Thomas Winischhofer , Joe Perches , "kernel-janitors@vger.kernel.org" , Jean-Christophe Plagniol-Villard , Linux Fbdev development list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment References: <1408818808-18850-1-git-send-email-Julia.Lawall@lip6.fr> <1408818808-18850-7-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24/08/14 21:21, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall wr= ote: >> --- >> The patches in this series do not depend on each other. >> >> This changes the semantics of the code and is not tested. >=20 > Hence I think you should change the subject of the patch, so it's obvio= us > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Well, to me "fix double assignment" sounds the same as "delete double assignment". Looking at the code, I think what's done here is "fix 1280x768 panel timings". I can apply this and do the change to subject, if nobody complains. Tomi --T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT/GbNAAoJEPo9qoy8lh71lGAP/Rcvke/rHdDgVTiB688BVQZe R/2N8CI8g62eAgmQs7vQOh78tchDDy+1Yw3VM/hUTR/Y0pM9FHSl2w5GuDvphotG Ez7cYMWl3iPafrsSh+y4tCypKPLGW2NZeayID4DsoX6PKpa8HRgnbGNDW6pQMpZs wWxhQz30qJ+TBglPp9uHrkzC5N2xOb/mhA7DynmiX57SFiq+zHNAY/Dgo1JFwZRH lSiLBqnHaFMklz9Cag5BgZecss09nGzZH6Hgd3n5V84hIoYkcmLTb1qt+vS8/QPu pYdhRRF+ZT23p8Dh6RO4U6h+Jzzsc3s+DgjdTd7gJ3wDZJtZoAleIPfMwa1mAi3f dUpE2HYCOLZ60XuARtG0hkz3/SlJLNa4lxQeipZgbeHNJwfckXibohytzTvB2yvx flYz0eU7ICZiCaF/waf2xe5rzVDN615X9C6o4saUya0hoeNe55+WlmQ67Z2U19EI KP4kkZK5aur2t1cKVuRnN5YWIsI7NrAfu7BgnSvurFsTyymv23+Jo24lLezUDcG/ KnzBFB+HYlgBnp3oFzFB0X4RcnO7zxpQv34rJxABdsfLCmNV+ugjmzK4gircutHv D2gCcs71RziZpNPqBrLqKR+06Ao3k5TAgu2lxOYq55F2LHqWz3M6IsJbs2drnz73 f3w1Q4gxb7AI4Bx25rm9 =LHS9 -----END PGP SIGNATURE----- --T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Tue, 26 Aug 2014 10:51:57 +0000 Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment Message-Id: <53FC66CD.8040800@ti.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf" List-Id: References: <1408818808-18850-1-git-send-email-Julia.Lawall@lip6.fr> <1408818808-18850-7-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: To: Geert Uytterhoeven , Julia Lawall Cc: Thomas Winischhofer , Joe Perches , "kernel-janitors@vger.kernel.org" , Jean-Christophe Plagniol-Villard , Linux Fbdev development list , "linux-kernel@vger.kernel.org" --T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24/08/14 21:21, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall wr= ote: >> --- >> The patches in this series do not depend on each other. >> >> This changes the semantics of the code and is not tested. >=20 > Hence I think you should change the subject of the patch, so it's obvio= us > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Well, to me "fix double assignment" sounds the same as "delete double assignment". Looking at the code, I think what's done here is "fix 1280x768 panel timings". I can apply this and do the change to subject, if nobody complains. Tomi --T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT/GbNAAoJEPo9qoy8lh71lGAP/Rcvke/rHdDgVTiB688BVQZe R/2N8CI8g62eAgmQs7vQOh78tchDDy+1Yw3VM/hUTR/Y0pM9FHSl2w5GuDvphotG Ez7cYMWl3iPafrsSh+y4tCypKPLGW2NZeayID4DsoX6PKpa8HRgnbGNDW6pQMpZs wWxhQz30qJ+TBglPp9uHrkzC5N2xOb/mhA7DynmiX57SFiq+zHNAY/Dgo1JFwZRH lSiLBqnHaFMklz9Cag5BgZecss09nGzZH6Hgd3n5V84hIoYkcmLTb1qt+vS8/QPu pYdhRRF+ZT23p8Dh6RO4U6h+Jzzsc3s+DgjdTd7gJ3wDZJtZoAleIPfMwa1mAi3f dUpE2HYCOLZ60XuARtG0hkz3/SlJLNa4lxQeipZgbeHNJwfckXibohytzTvB2yvx flYz0eU7ICZiCaF/waf2xe5rzVDN615X9C6o4saUya0hoeNe55+WlmQ67Z2U19EI KP4kkZK5aur2t1cKVuRnN5YWIsI7NrAfu7BgnSvurFsTyymv23+Jo24lLezUDcG/ KnzBFB+HYlgBnp3oFzFB0X4RcnO7zxpQv34rJxABdsfLCmNV+ugjmzK4gircutHv D2gCcs71RziZpNPqBrLqKR+06Ao3k5TAgu2lxOYq55F2LHqWz3M6IsJbs2drnz73 f3w1Q4gxb7AI4Bx25rm9 =LHS9 -----END PGP SIGNATURE----- --T2Q2smw8R0tGaR5Wc58vTFK68lTM1xOCf--