From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMFz3-0007vv-CC for qemu-devel@nongnu.org; Tue, 26 Aug 2014 08:36:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMFyv-0006mb-RF for qemu-devel@nongnu.org; Tue, 26 Aug 2014 08:36:21 -0400 Message-ID: <53FC7F3C.6070708@suse.de> Date: Tue, 26 Aug 2014 14:36:12 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1408407718-10835-1-git-send-email-mdroth@linux.vnet.ibm.com> <1408407718-10835-13-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1408407718-10835-13-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/12] spapr_pci: emit hotplug add/remove events during hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: aik@ozlabs.ru, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com On 19.08.14 02:21, Michael Roth wrote: > From: Tyrel Datwyler > > This uses extension of existing EPOW interrupt/event mechanism > to notify userspace tools like librtas/drmgr to handle > in-guest configuration/cleanup operations in response to > device_add/device_del. > > Userspace tools that don't implement this extension will need > to be run manually in response/advance of device_add/device_del, > respectively. Couldn't they use the pull event mechanism you implement in the previous patch? > > Signed-off-by: Tyrel Datwyler > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 23864ab..17d37c0 100644 > --- a/hw/ppc/spapr_pci.c > +++ b/hw/ppc/spapr_pci.c > @@ -944,6 +944,18 @@ static int spapr_device_hotplug_add(DeviceState *qdev, PCIDevice *dev) > drc_entry_slot->state &= ~(uint32_t)INDICATOR_ENTITY_SENSE_MASK; > drc_entry_slot->state |= encoded; /* and the slot */ > > + /* reliable unplug requires we wait for a transition from > + * UNISOLATED->ISOLATED prior to device removal/deletion. > + * However, slots populated by devices at boot-time will not > + * have ever been set by guest tools to an UNISOLATED/populated > + * state, so set this manually in the case of coldplug devices > + */ > + if (!DEVICE(dev)->hotplugged) { > + drc_entry_slot->state |= ENCODE_DRC_STATE(1, > + INDICATOR_ISOLATION_MASK, > + INDICATOR_ISOLATION_SHIFT); I think as a general scheme we would like to have the PHB call DRC (which it knows from a qom link) which raises a qemu_irq to notify the EPOW device that an event happened. If the EPOW interface is too complex, I guess we can live with a link and function call too. Alex