From: "Jan Beulich" <JBeulich@suse.com>
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
yang.z.zhang@intel.com
Subject: Re: [v5][PATCH 03/10] xen:x86: define a new hypercall to get RMRR mappings
Date: Tue, 26 Aug 2014 13:37:37 +0100 [thread overview]
Message-ID: <53FC9BB1020000780002D986@mail.emea.novell.com> (raw)
In-Reply-To: <53FC774D.8000501@citrix.com>
>>> On 26.08.14 at 14:02, <andrew.cooper3@citrix.com> wrote:
> On 26/08/14 12:02, Tiejun Chen wrote:
>> + case XENMEM_reserved_device_memory_map:
>> + {
>> + struct xen_mem_reserved_device_memory_map map;
>> + XEN_GUEST_HANDLE(xen_mem_reserved_device_memory_t) buffer;
>> + XEN_GUEST_HANDLE_PARAM(xen_mem_reserved_device_memory_t) buffer_param;
>> + unsigned int i = 0;
>> + static struct xen_mem_reserved_device_memory rmrr_map;
>
> This absolutely must not be static, as I have indicated twice before.
Indeed, you should be reading what you're being told, and not
submit new patch versions without having addressed (by altering
the patch or addressing the comment verbally) previous comments.
For example, I had also asked you to adjust your patch titles, yet
they still come in the same bogus form (namely with colons rather
than slashes as prefix separators - this ones should e.g. start with
"xen/x86:", albeit I personally dislike the xen/ prefix and tend to
strip it).
It is for that reason that I didn't comment on the last two or so
iterations of your patch series - the effort the repeated pointing
out of issues causes just makes it sit at the very end of the list of
things needing looking at).
Jan
next prev parent reply other threads:[~2014-08-26 12:37 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 11:02 [v5][PATCH 0/10] xen: reserve RMRR to avoid conflicting MMIO/RAM Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 01/10] xen:vtd:rmrr: export acpi_rmrr_units Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 02/10] xen:vtd:rmrr: introduce acpi_rmrr_unit_entries Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 03/10] xen:x86: define a new hypercall to get RMRR mappings Tiejun Chen
2014-08-26 12:02 ` Andrew Cooper
2014-08-26 12:37 ` Jan Beulich [this message]
2014-08-27 1:37 ` Chen, Tiejun
2014-08-27 6:51 ` Jan Beulich
2014-08-27 7:21 ` Chen, Tiejun
2014-08-28 2:24 ` Chen, Tiejun
2014-08-28 6:50 ` Jan Beulich
2014-08-28 7:09 ` Chen, Tiejun
2014-08-28 7:19 ` Chen, Tiejun
2014-08-28 7:29 ` Chen, Tiejun
2014-08-28 7:44 ` Jan Beulich
2014-08-29 3:02 ` Chen, Tiejun
2014-08-29 9:18 ` Jan Beulich
2014-09-01 9:44 ` Chen, Tiejun
2014-09-01 10:29 ` Jan Beulich
2014-09-02 9:59 ` Chen, Tiejun
2014-09-02 10:15 ` Jan Beulich
2014-09-02 11:10 ` Chen, Tiejun
2014-09-02 13:15 ` Jan Beulich
2014-09-03 1:45 ` Chen, Tiejun
2014-09-03 8:31 ` Chen, Tiejun
2014-09-03 8:41 ` Jan Beulich
2014-09-03 8:59 ` Chen, Tiejun
2014-09-03 9:01 ` Chen, Tiejun
2014-09-03 9:54 ` Chen, Tiejun
2014-09-03 12:54 ` Jan Beulich
2014-09-04 1:15 ` Chen, Tiejun
2014-09-03 8:35 ` Jan Beulich
2014-08-27 1:15 ` Chen, Tiejun
2014-09-02 8:25 ` Jan Beulich
2014-08-26 11:02 ` [v5][PATCH 04/10] tools:libxc: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 05/10] tools:libxc: check if mmio BAR is out of RMRR mappings Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 06/10] hvm_info_table: introduce nr_reserved_device_memory_map Tiejun Chen
2014-09-02 8:34 ` Jan Beulich
2014-09-04 2:07 ` Chen, Tiejun
2014-09-04 6:32 ` Jan Beulich
2014-09-04 6:55 ` Chen, Tiejun
[not found] ` <54082E3B0200007800030BCB@mail.emea.novell.com>
2014-09-09 6:40 ` Chen, Tiejun
2014-08-26 11:02 ` [v5][PATCH 07/10] xen:x86:: support xc_reserved_device_memory_map in compat case Tiejun Chen
2014-09-02 8:35 ` Jan Beulich
2014-09-04 2:13 ` Chen, Tiejun
2014-08-26 11:02 ` [v5][PATCH 08/10] tools:firmware:hvmloader: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-09-02 8:37 ` Jan Beulich
2014-08-26 11:02 ` [v5][PATCH 09/10] tools:firmware:hvmloader: check to reserve RMRR mappings in e820 Tiejun Chen
2014-09-02 8:47 ` Jan Beulich
2014-09-04 3:04 ` Chen, Tiejun
2014-09-04 4:32 ` Chen, Tiejun
2014-09-04 6:36 ` Jan Beulich
2014-08-26 11:03 ` [v5][PATCH 10/10] xen:vtd: make USB RMRR mapping safe Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC9BB1020000780002D986@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tiejun.chen@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.