From: Chris Mason <clm@fb.com>
To: Eric Sandeen <sandeen@redhat.com>, <dsterba@suse.cz>,
Goffredo Baroncelli <kreijack@libero.it>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning
Date: Tue, 26 Aug 2014 10:53:52 -0400 [thread overview]
Message-ID: <53FC9F80.6070608@fb.com> (raw)
In-Reply-To: <53FC9EFE.8050105@redhat.com>
On 08/26/2014 10:51 AM, Eric Sandeen wrote:
> On 8/26/14, 5:55 AM, David Sterba wrote:
>> On Thu, Aug 21, 2014 at 08:08:57PM +0200, Goffredo Baroncelli wrote:
>>> Of course I (we) don't care cdrom and/or floppy, but this raises
>>> the question: are there other block devices which aren't showed in
>>> proc/partitions ?
>>
>> cdrom appears as /dev/sr0, floppy is /dev/fd0 if the respective modules
>> are loaded, no breakage here.
>>
>>> I am thinking to some less common hardware like
>>> NON USB sd disk (I saw this kind of hardware, but now I don't have
>>> it in my hands....).
>>
>> A block device whose driver calls register_blkdev should appear in
>> proc/partitions, if not then I think it's a bug or a very non-standard
>> interface.
>>
>> I don't know about any other cases where full /dev scan would reveal
>> something that /proc/partitions not, so I guess it's safe to remove it.
>
> Yesterday, Chris did mention <something something mumble> about /dev/mapper/*
>
> [12:57] <cmason> I got inconsistent results from /proc/partitions
> [12:57] <cmason> this was 3 years ago now
> [12:58] <cmason> it didn't find everything for dm devices, yeah
> [12:58] <cmason> especially dm multipath got really confused
>
> and I'll be honest, I didn't test with devicemapper devices, much
> less dm multipath, so I suppose that's warranted prior to removal.
>
> I'll see what I can do.
>
> If there's a problem, I bet there's a solution that doesn't involve
> scanning everything under /dev ...
That's definitely the problem I hit, but it was years ago. I'm willing
to bet we're safe to keep /proc/partitions now.
-chris
next prev parent reply other threads:[~2014-08-26 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 22:21 [PATCH 0/3] btrfs-progs: remove full /dev scanning Eric Sandeen
2014-08-20 22:22 ` [PATCH 1/3] btrfs-progs: scan /proc/partitions not all of /dev with "-d" Eric Sandeen
2014-08-26 8:27 ` Anand Jain
2014-08-20 22:23 ` [PATCH 2/3] btrfs-progs: don't fall back to recursive /dev scan Eric Sandeen
2014-08-26 8:27 ` Anand Jain
2014-08-20 22:24 ` [PATCH 3/3] btrfs-progs: remove BTRFS_SCAN_DEV and btrfs_scan_one_dir Eric Sandeen
2014-08-26 8:29 ` Anand Jain
2014-08-21 8:44 ` [PATCH 0/3] btrfs-progs: remove full /dev scanning Anand Jain
2014-08-21 14:29 ` Eric Sandeen
2014-08-26 8:24 ` Anand Jain
2014-08-26 11:08 ` David Sterba
2014-08-21 18:08 ` Goffredo Baroncelli
2014-08-26 10:55 ` David Sterba
2014-08-26 14:51 ` Eric Sandeen
2014-08-26 14:53 ` Chris Mason [this message]
2014-08-26 22:56 ` Anand Jain
2014-08-26 9:52 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC9F80.6070608@fb.com \
--to=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.