All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>,
	Kevin Tian <kevin.tian@intel.com>, Tim Deegan <tim@xen.org>
Cc: "ian.campbell@citrix.com" <ian.campbell@citrix.com>,
	"stefano.stabellini@eu.citrix.com"
	<stefano.stabellini@eu.citrix.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	Eddie Dong <eddie.dong@intel.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Jun Nakajima <jun.nakajima@intel.com>,
	"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH RFC V7 4/5] xen, libxc: Request page fault injection via libxc
Date: Wed, 27 Aug 2014 07:58:42 +0100	[thread overview]
Message-ID: <53FD9DC2020000780002DF0B@mail.emea.novell.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D12604CF57@SHSMSX101.ccr.corp.intel.com>

>>> On 27.08.14 at 02:54, <kevin.tian@intel.com> wrote:
> From code seems this info is a condition for PF injection, instead of
> recording VCPU faulting information. So it looks OK to be a per-domain
> structure, but the structure name 'fault_info' is too generic...

Not really, because it also makes assumptions about the guest OS.
Which I'd consider okay for a particular end product like the one
BitDefender is creating, but not for an interface. In particular here
the assumption is that you can inject a fault on an arbitrary vCPU
to achieve a certain goal, which certainly isn't valid without knowing
how the OS works.

But yes, with the naming changed to reflect the special purpose,
this might become less of an issue. Pretending (or making appear)
something to be general purpose when it isn't, however, would
only be setting us up for future problems.

An alternative might be to design the external interface in a way
being vCPU-centric, with a way to specify a "wildcard" to serve the
particular purpose here.

Jan

  reply	other threads:[~2014-08-27  6:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 15:28 [PATCH RFC V7 1/5] xen: Emulate with no writes Razvan Cojocaru
2014-08-13 15:28 ` [PATCH RFC V7 2/5] xen: Optimize introspection access to guest state Razvan Cojocaru
2014-08-13 15:28 ` [PATCH RFC V7 3/5] xen, libxc: Force-enable relevant MSR events Razvan Cojocaru
2014-08-26 14:05   ` Jan Beulich
2014-08-13 15:28 ` [PATCH RFC V7 4/5] xen, libxc: Request page fault injection via libxc Razvan Cojocaru
2014-08-26 14:13   ` Jan Beulich
2014-08-26 14:24     ` Razvan Cojocaru
2014-08-26 14:44       ` Jan Beulich
2014-08-26 14:56         ` Razvan Cojocaru
2014-08-26 15:49           ` Jan Beulich
2014-08-26 16:59             ` Razvan Cojocaru
2014-08-27  0:54               ` Tian, Kevin
2014-08-27  6:58                 ` Jan Beulich [this message]
2014-08-28 13:15             ` Tim Deegan
2014-08-28 13:19               ` Razvan Cojocaru
2014-08-27 11:54     ` Razvan Cojocaru
2014-08-27 12:10       ` Jan Beulich
2014-08-27 12:15         ` Razvan Cojocaru
2014-08-13 15:28 ` [PATCH RFC V7 5/5] xen: Handle resumed instruction based on previous mem_event reply Razvan Cojocaru
2014-08-26 13:56 ` [PATCH RFC V7 1/5] xen: Emulate with no writes Jan Beulich
2014-08-26 14:01   ` Razvan Cojocaru
2014-08-26 14:19     ` Jan Beulich
2014-08-26 14:30       ` Razvan Cojocaru
2014-08-26 14:40         ` Jan Beulich
2014-08-26 14:45           ` Razvan Cojocaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FD9DC2020000780002DF0B@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.