From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH RFC V10 5/5] xen: Handle resumed instruction
 based on previous mem_event reply
Date: Thu, 28 Aug 2014 16:36:42 +0300
Message-ID: <53FF306A.1040601@bitdefender.com>
References: <1409231421-18444-1-git-send-email-rcojocaru@bitdefender.com>	<1409231421-18444-5-git-send-email-rcojocaru@bitdefender.com>
	<53FF4B67020000780002EBED@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <rcojocaru@bitdefender.com>) id 1XMzsK-0004vA-GW
	for xen-devel@lists.xenproject.org; Thu, 28 Aug 2014 13:36:28 +0000
In-Reply-To: <53FF4B67020000780002EBED@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, eddie.dong@intel.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, jun.nakajima@intel.com, xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 08/28/2014 04:31 PM, Jan Beulich wrote:
>>>> On 28.08.14 at 15:10, <rcojocaru@bitdefender.com> wrote:
>> +static bool_t vmx_exited_by_nested_pagefault(void)
>> +{
>> +    unsigned long exit_qualification;
>> +
>> +#ifndef NDEBUG
>> +    unsigned long exit_reason;
>> +    __vmread(VM_EXIT_REASON, &exit_reason);
>> +    ASSERT(exit_reason == EXIT_REASON_EPT_VIOLATION);
>> +#endif
> 
> This #ifdef-ery is pointless afaict.

I thought I'd save a __vmread() call if Xen is not being compiled in
debug mode. I'll remove it.


Thanks,
Razvan Cojocaru