All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com,
	stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
	eddie.dong@intel.com, tim@xen.org, jun.nakajima@intel.com,
	xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com
Subject: Re: [PATCH RFC V10 5/5] xen: Handle resumed instruction based on previous mem_event reply
Date: Thu, 28 Aug 2014 14:55:47 +0100	[thread overview]
Message-ID: <53FF5103020000780002EC18@mail.emea.novell.com> (raw)
In-Reply-To: <53FF306A.1040601@bitdefender.com>

>>> On 28.08.14 at 15:36, <rcojocaru@bitdefender.com> wrote:
> On 08/28/2014 04:31 PM, Jan Beulich wrote:
>>>>> On 28.08.14 at 15:10, <rcojocaru@bitdefender.com> wrote:
>>> +static bool_t vmx_exited_by_nested_pagefault(void)
>>> +{
>>> +    unsigned long exit_qualification;
>>> +
>>> +#ifndef NDEBUG
>>> +    unsigned long exit_reason;
>>> +    __vmread(VM_EXIT_REASON, &exit_reason);
>>> +    ASSERT(exit_reason == EXIT_REASON_EPT_VIOLATION);
>>> +#endif
>> 
>> This #ifdef-ery is pointless afaict.
> 
> I thought I'd save a __vmread() call if Xen is not being compiled in
> debug mode. I'll remove it.

Yeah, we ought to reconsider the volatile-s on those asm()-s, to
allow the compiler to eliminate such. At least on the vmread this
would seem okay to me.

Jan

  reply	other threads:[~2014-08-28 13:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 13:10 [PATCH RFC V10 1/5] xen: Emulate with no writes Razvan Cojocaru
2014-08-28 13:10 ` [PATCH RFC V10 2/5] xen: Optimize introspection access to guest state Razvan Cojocaru
2014-08-28 13:10 ` [PATCH RFC V10 3/5] xen, libxc: Force-enable relevant MSR events Razvan Cojocaru
2014-08-28 13:10 ` [PATCH RFC V10 4/5] xen, libxc: Request page fault injection via libxc Razvan Cojocaru
2014-08-28 13:31   ` Jan Beulich
2014-08-28 13:32     ` Razvan Cojocaru
2014-08-28 13:10 ` [PATCH RFC V10 5/5] xen: Handle resumed instruction based on previous mem_event reply Razvan Cojocaru
2014-08-28 13:31   ` Jan Beulich
2014-08-28 13:36     ` Razvan Cojocaru
2014-08-28 13:55       ` Jan Beulich [this message]
2014-09-02 15:29 [PATCH RFC V10 1/5] xen: Emulate with no writes Razvan Cojocaru
2014-09-02 15:29 ` [PATCH RFC V10 5/5] xen: Handle resumed instruction based on previous mem_event reply Razvan Cojocaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FF5103020000780002EC18@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.