All of lore.kernel.org
 help / color / mirror / Atom feed
From: akolli@codeaurora.org
To: Sven Eckelmann <sven@narfation.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Sathishkumar Muruganandam <murugana@codeaurora.org>
Subject: Re: [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters
Date: Mon, 05 Mar 2018 16:16:21 +0530	[thread overview]
Message-ID: <53a3580c002d7af01668f4716aae56bd@codeaurora.org> (raw)
In-Reply-To: <1974303.3lPsqGCgIZ@bentobox>

On 2018-03-05 13:12, Sven Eckelmann wrote:
> On Montag, 5. März 2018 12:29:08 CET Anilkumar Kolli wrote:
>> @@ -496,6 +497,8 @@ struct ath10k_debug {
>>         u32 reg_addr;
>>         u32 nf_cal_period;
>>         void *cal_data;
>> +       u32 fw_test_param_id;
>> +       u32 fw_test_param_value;
>>  };
> 
> Why is it necessary to have these two values in ath10k_debug? They seem 
> to be
> used only in the context of ath10k_write_fw_test().
> 
Yes. it is not reused, will remove this.

> Where can we find the documentation of the possible param_id and 
> param_values?
> 
All these parameters are for experimentation purpose.

Thanks,
Anil.

WARNING: multiple messages have this Message-ID (diff)
From: akolli@codeaurora.org
To: Sven Eckelmann <sven@narfation.org>
Cc: Sathishkumar Muruganandam <murugana@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters
Date: Mon, 05 Mar 2018 16:16:21 +0530	[thread overview]
Message-ID: <53a3580c002d7af01668f4716aae56bd@codeaurora.org> (raw)
In-Reply-To: <1974303.3lPsqGCgIZ@bentobox>

On 2018-03-05 13:12, Sven Eckelmann wrote:
> On Montag, 5. März 2018 12:29:08 CET Anilkumar Kolli wrote:
>> @@ -496,6 +497,8 @@ struct ath10k_debug {
>>         u32 reg_addr;
>>         u32 nf_cal_period;
>>         void *cal_data;
>> +       u32 fw_test_param_id;
>> +       u32 fw_test_param_value;
>>  };
> 
> Why is it necessary to have these two values in ath10k_debug? They seem 
> to be
> used only in the context of ath10k_write_fw_test().
> 
Yes. it is not reused, will remove this.

> Where can we find the documentation of the possible param_id and 
> param_values?
> 
All these parameters are for experimentation purpose.

Thanks,
Anil.


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-03-05 10:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05  6:59 [PATCH 0/2] FWTEST command support in debugfs Anilkumar Kolli
2018-03-05  6:59 ` Anilkumar Kolli
2018-03-05  6:59 ` [PATCH 1/2] ath10k: Add WMI FWTEST command support Anilkumar Kolli
2018-03-05  6:59   ` Anilkumar Kolli
2018-03-05 18:48   ` Peter Oh
2018-03-05 18:48     ` Peter Oh
2018-03-05 19:31     ` Sebastian Gottschall
2018-03-05 19:31       ` Sebastian Gottschall
2018-03-05  6:59 ` [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters Anilkumar Kolli
2018-03-05  6:59   ` Anilkumar Kolli
2018-03-05  7:42   ` Sven Eckelmann
2018-03-05  7:42     ` Sven Eckelmann
2018-03-05 10:46     ` akolli [this message]
2018-03-05 10:46       ` akolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53a3580c002d7af01668f4716aae56bd@codeaurora.org \
    --to=akolli@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=murugana@codeaurora.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.