Re: [PATCH v5 2/2] m68k: add kernel seccomp support

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Geert,

Am 26.06.2021 um 06:42 schrieb Michael Schmitz:
> Hi Geert,
>
> Am 25.06.2021 um 19:31 schrieb Geert Uytterhoeven:
>> Hi Michael,
>>
>> On Thu, Jun 24, 2021 at 11:20 PM Michael Schmitz
>> <schmitzmic@gmail.com> wrote:
>>> On 23/06/21 7:35 pm, Geert Uytterhoeven wrote:
>>>> BTW, there was also "[PATCH] [WIP] selftests/seccomp: Add m68k support"
>>>> https://lore.kernel.org/linux-m68k/alpine.DEB.2.21.2008261315050.25325@ramsan.of.borg/
>>>>
>>>>
>>>> I kept on up-porting it, but haven't exercised it recently.
>>>
>>> See attached for test results on my ARAnyM image (Laurent's qemu image,
>>> essentially).
>>>
>>> Is that any different from what you got in your earlier tests?
>>
>> Fortunately lore has a better memory than I do ;-)
>>
>> https://lore.kernel.org/linux-m68k/alpine.DEB.2.21.2008261612360.2926@ramsan.of.borg/
>>
>>
>> mine: FAILED: 35 / 86 tests passed
>> yours: FAILED: 35 / 87 tests passed
>>
>> So one new test, and it fails?
>
> Looks like it. I must be missing some mail in my mail archive, can't
> recall ever seeing that one.
>
> There's one new test added after your mail was sent - KILL_unknown. I
> suppose it's that one.
>
> Anyway, both much better than without seccomp support. And going back
> over the archive, I found your patch where you added seccomp.h - and
> added a line in Kbuild as well, which I forgot. Will fix that.

Hmm - after that change, I get:

   SYSHDR  arch/m68k/include/generated/uapi/asm/unistd_32.h
   SYSTBL  arch/m68k/include/generated/asm/syscall_table.h
   UPD     include/config/kernel.release
scripts/Makefile.asm-generic:25: redundant generic-y found in 
arch/m68k/include/asm/Kbuild: seccomp.h
   WRAP    arch/m68k/include/generated/asm/seccomp.h
   UPD     include/generated/utsrelease.h

in the build log.

None of the other archs do add seccomp.h to their include/asm/Kbuild 
script. I'll leave it at v6 then.

Cheers,

	Michael