From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0BCC433B4 for ; Wed, 7 Apr 2021 10:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38AA56139B for ; Wed, 7 Apr 2021 10:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346633AbhDGKFX (ORCPT ); Wed, 7 Apr 2021 06:05:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:39484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350508AbhDGKDx (ORCPT ); Wed, 7 Apr 2021 06:03:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 062EF6139C; Wed, 7 Apr 2021 10:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617789824; bh=U2Q8yQRaIx4QiUDT92JbWKR5p2N8Pmme+7zcvnbeJJ0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=D2H4UEtHja2iIv2loa+fuuitQ959MN2FGakHGD8VX07eZKsavECG1occPJR8NZ+iw syCag3ZhloduOHJ+yp6Le+QJENnSEuMZqR5GbzOES4ZpFa42BJgZbhbEnRrAuqnWar EVGT8td4AqmWmQqfnuY4wOdlnLFki+xiAvxvxKlS1mesefU/1v0wUgcdRY0bh4SIsZ n7Yv0VJpeH4MZw32BL2wIBGrHRG/Kw4LPc6QlePUA2WjVRCIqHb1+bpS6iVGM2H6sB moflSRRRevnPCGjCAOAwOqW112u/0PAHVJOdUV8SSOd/jHlT3TOoAnV++GhUKmduTT Nec2+miWZIEUg== Subject: Re: [PATCH] clk: exynos7: Mark aclk_fsys1_200 as critical To: =?UTF-8?Q?Pawe=c5=82_Chmiel?= Cc: s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kgene@kernel.org, krzk@kernel.org, mturquette@baylibre.com, sboyd@kernel.org References: <20201024154346.9589-1-pawel.mikolaj.chmiel@gmail.com> From: Sylwester Nawrocki Message-ID: <53be0d9d-a64a-9108-85f0-40ac360757c4@kernel.org> Date: Wed, 7 Apr 2021 12:03:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20201024154346.9589-1-pawel.mikolaj.chmiel@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.10.2020 17:43, Paweł Chmiel wrote: > This clock must be always enabled to allow access to any registers in > fsys1 CMU. Until proper solution based on runtime PM is applied > (similar to what was done for Exynos5433), mark that clock as critical > so it won't be disabled. > > It was observed on Samsung Galaxy S6 device (based on Exynos7420), where > UFS module is probed before pmic used to power that device. > In this case defer probe was happening and that clock was disabled by > UFS driver, causing whole boot to hang on next CMU access. > > Signed-off-by: Paweł Chmiel > --- > drivers/clk/samsung/clk-exynos7.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos7.c b/drivers/clk/samsung/clk-exynos7.c > index c1ff715e960c..1048d83f097b 100644 > --- a/drivers/clk/samsung/clk-exynos7.c > +++ b/drivers/clk/samsung/clk-exynos7.c > @@ -538,7 +538,8 @@ static const struct samsung_gate_clock top1_gate_clks[] __initconst = { > ENABLE_ACLK_TOP13, 28, CLK_SET_RATE_PARENT | > CLK_IS_CRITICAL, 0), As this patch can be backported up to the commit that introduced regression I have applied it instead of your v3, with a comment as below. + /* + * This clock is required for the CMU_FSYS1 registers access, keep it + * enabled permanently until proper runtime PM support is added. + */ > GATE(CLK_ACLK_FSYS1_200, "aclk_fsys1_200", "dout_aclk_fsys1_200", > - ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT, 0), > + ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT | > + CLK_IS_CRITICAL, 0), > > GATE(CLK_SCLK_PHY_FSYS1_26M, "sclk_phy_fsys1_26m", > "dout_sclk_phy_fsys1_26m", ENABLE_SCLK_TOP1_FSYS11, -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B2F3C433ED for ; Wed, 7 Apr 2021 10:06:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7600E61382 for ; Wed, 7 Apr 2021 10:06:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7600E61382 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bzx7qY0ZuaZYseUtLzh/KUCNQz9XjNWCP4q7VFTCxvE=; b=dHz7gyBi2XJP2qJjfXSESh7pV Netap6BxwCo9wduO3Ug/T+V1pihxdcaG55O+YQSq+2HggHqp3+F5v1VMaNWKl9BYP7MOacBkXjj+a 32eHB5lDo7gSjI1MCn/rsRR2gwvRa4wNc7uQ+rwQ9qrcyRzg2lnKJ4stRmSTPOal6msiQD4Xk41AP 2vTNc/Ihbp0+b4AucnNNM2Yt5l05UpNd237gKuleKsadnq7rD2DO7aoeLBgqWPWDupnW+dIxlNCkX lsuFZ74soHoBG8IY0eXT2uZchJadup/nMFmoFo5dlLVHQzV3PwU6j1cXbC51h/fYzwR1gncEryajf KBccZfBoA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lU52P-004gNF-GX; Wed, 07 Apr 2021 10:03:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lU52J-004gM6-UT for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 10:03:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 062EF6139C; Wed, 7 Apr 2021 10:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617789824; bh=U2Q8yQRaIx4QiUDT92JbWKR5p2N8Pmme+7zcvnbeJJ0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=D2H4UEtHja2iIv2loa+fuuitQ959MN2FGakHGD8VX07eZKsavECG1occPJR8NZ+iw syCag3ZhloduOHJ+yp6Le+QJENnSEuMZqR5GbzOES4ZpFa42BJgZbhbEnRrAuqnWar EVGT8td4AqmWmQqfnuY4wOdlnLFki+xiAvxvxKlS1mesefU/1v0wUgcdRY0bh4SIsZ n7Yv0VJpeH4MZw32BL2wIBGrHRG/Kw4LPc6QlePUA2WjVRCIqHb1+bpS6iVGM2H6sB moflSRRRevnPCGjCAOAwOqW112u/0PAHVJOdUV8SSOd/jHlT3TOoAnV++GhUKmduTT Nec2+miWZIEUg== Subject: Re: [PATCH] clk: exynos7: Mark aclk_fsys1_200 as critical To: =?UTF-8?Q?Pawe=c5=82_Chmiel?= Cc: s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kgene@kernel.org, krzk@kernel.org, mturquette@baylibre.com, sboyd@kernel.org References: <20201024154346.9589-1-pawel.mikolaj.chmiel@gmail.com> From: Sylwester Nawrocki Message-ID: <53be0d9d-a64a-9108-85f0-40ac360757c4@kernel.org> Date: Wed, 7 Apr 2021 12:03:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20201024154346.9589-1-pawel.mikolaj.chmiel@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_110348_283894_7B70FD54 X-CRM114-Status: GOOD ( 20.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjQuMTAuMjAyMCAxNzo0MywgUGF3ZcWCIENobWllbCB3cm90ZToKPiBUaGlzIGNsb2NrIG11 c3QgYmUgYWx3YXlzIGVuYWJsZWQgdG8gYWxsb3cgYWNjZXNzIHRvIGFueSByZWdpc3RlcnMgaW4K PiBmc3lzMSBDTVUuIFVudGlsIHByb3BlciBzb2x1dGlvbiBiYXNlZCBvbiBydW50aW1lIFBNIGlz IGFwcGxpZWQKPiAoc2ltaWxhciB0byB3aGF0IHdhcyBkb25lIGZvciBFeHlub3M1NDMzKSwgbWFy ayB0aGF0IGNsb2NrIGFzIGNyaXRpY2FsCj4gc28gaXQgd29uJ3QgYmUgZGlzYWJsZWQuCj4gCj4g SXQgd2FzIG9ic2VydmVkIG9uIFNhbXN1bmcgR2FsYXh5IFM2IGRldmljZSAoYmFzZWQgb24gRXh5 bm9zNzQyMCksIHdoZXJlCj4gVUZTIG1vZHVsZSBpcyBwcm9iZWQgYmVmb3JlIHBtaWMgdXNlZCB0 byBwb3dlciB0aGF0IGRldmljZS4KPiBJbiB0aGlzIGNhc2UgZGVmZXIgcHJvYmUgd2FzIGhhcHBl bmluZyBhbmQgdGhhdCBjbG9jayB3YXMgZGlzYWJsZWQgYnkKPiBVRlMgZHJpdmVyLCBjYXVzaW5n IHdob2xlIGJvb3QgdG8gaGFuZyBvbiBuZXh0IENNVSBhY2Nlc3MuCj4gCj4gU2lnbmVkLW9mZi1i eTogUGF3ZcWCIENobWllbCA8cGF3ZWwubWlrb2xhai5jaG1pZWxAZ21haWwuY29tPgo+IC0tLQo+ ICAgZHJpdmVycy9jbGsvc2Ftc3VuZy9jbGstZXh5bm9zNy5jIHwgMyArKy0KPiAgIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9jbGsvc2Ftc3VuZy9jbGstZXh5bm9zNy5jIGIvZHJpdmVycy9jbGsvc2Ftc3VuZy9j bGstZXh5bm9zNy5jCj4gaW5kZXggYzFmZjcxNWU5NjBjLi4xMDQ4ZDgzZjA5N2IgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9jbGsvc2Ftc3VuZy9jbGstZXh5bm9zNy5jCj4gKysrIGIvZHJpdmVycy9j bGsvc2Ftc3VuZy9jbGstZXh5bm9zNy5jCj4gQEAgLTUzOCw3ICs1MzgsOCBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IHNhbXN1bmdfZ2F0ZV9jbG9jayB0b3AxX2dhdGVfY2xrc1tdIF9faW5pdGNvbnN0 ID0gewo+ICAgCQlFTkFCTEVfQUNMS19UT1AxMywgMjgsIENMS19TRVRfUkFURV9QQVJFTlQgfAo+ ICAgCQlDTEtfSVNfQ1JJVElDQUwsIDApLAoKQXMgdGhpcyBwYXRjaCBjYW4gYmUgYmFja3BvcnRl ZCB1cCB0byB0aGUgY29tbWl0IHRoYXQgaW50cm9kdWNlZCByZWdyZXNzaW9uCkkgaGF2ZSBhcHBs aWVkIGl0IGluc3RlYWQgb2YgeW91ciB2Mywgd2l0aCBhIGNvbW1lbnQgYXMgYmVsb3cuCgorICAg ICAgIC8qCisgICAgICAgICogVGhpcyBjbG9jayBpcyByZXF1aXJlZCBmb3IgdGhlIENNVV9GU1lT MSByZWdpc3RlcnMgYWNjZXNzLCBrZWVwIGl0CisgICAgICAgICogZW5hYmxlZCBwZXJtYW5lbnRs eSB1bnRpbCBwcm9wZXIgcnVudGltZSBQTSBzdXBwb3J0IGlzIGFkZGVkLgorICAgICAgICAqLwoK PiAgIAlHQVRFKENMS19BQ0xLX0ZTWVMxXzIwMCwgImFjbGtfZnN5czFfMjAwIiwgImRvdXRfYWNs a19mc3lzMV8yMDAiLAo+IC0JCUVOQUJMRV9BQ0xLX1RPUDEzLCAyNCwgQ0xLX1NFVF9SQVRFX1BB UkVOVCwgMCksCj4gKwkJRU5BQkxFX0FDTEtfVE9QMTMsIDI0LCBDTEtfU0VUX1JBVEVfUEFSRU5U IHwKPiArCQlDTEtfSVNfQ1JJVElDQUwsIDApLAo+ICAgCj4gICAJR0FURShDTEtfU0NMS19QSFlf RlNZUzFfMjZNLCAic2Nsa19waHlfZnN5czFfMjZtIiwKPiAgIAkJImRvdXRfc2Nsa19waHlfZnN5 czFfMjZtIiwgRU5BQkxFX1NDTEtfVE9QMV9GU1lTMTEsCiAgCi0tClJlZ2FyZHMsClN5bHdlc3Rl cgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=