From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j41Iv-00049f-GN for mharc-grub-devel@gnu.org; Tue, 18 Feb 2020 06:44:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60926) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j41Is-00046u-Qr for grub-devel@gnu.org; Tue, 18 Feb 2020 06:44:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j41Ir-0003vf-2E for grub-devel@gnu.org; Tue, 18 Feb 2020 06:44:37 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:52935 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j41Iq-0003ux-SF for grub-devel@gnu.org; Tue, 18 Feb 2020 06:44:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582026275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CHKE2HimeGvOGai/xrcCABcvUmQYpK1vw4p0rSVQqS8=; b=epoYhWChsMBCVJx4HjFBTWRtGex3Xyx6xieQbdtz1WK7Z55UKqc2jOGJnj/dVS/FfnQbNo c5/0YInm3CWQGuWxykAbf6eP2LPNZgHWzcieOCtBgwQzUo9E9GEPdkz0g3/fTaey9c/JGL cwEZwKUdV8J25BkwsE8mwcmqykNB1s4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-laz60ZUNPHi0B3lrpB0syw-1; Tue, 18 Feb 2020 06:44:33 -0500 Received: by mail-wr1-f71.google.com with SMTP id d15so10669791wru.1 for ; Tue, 18 Feb 2020 03:44:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CHKE2HimeGvOGai/xrcCABcvUmQYpK1vw4p0rSVQqS8=; b=sbBjA9bh62oAv9BnwvhBjzuyzwoRrGAuH1VOxHQg8AKwRkna8yqNNy2JfeA9Aab9qR QLSKmyzbRDgxEMC2dtFE1HOEmCUfH15fEhBaObEJRtbi4xeiSIHgAhnn7XjHstcB/aMX 67Gnf7k2AkUSqZaY+xDk17LhxyvKnSkIleTS7RSy0/m8Atq9pa9iyrsPpk7WFDYD31O7 MWvkN46VRL/MX0R7M9cV/gKVKPuEpMCBW8ouHLZFTiHAM3APVsRgyZEwKWSDsbql4MsH MdcWs3g4mmU4Sl0OBSZo7pEJ5jE70zgRB+0k8IOhTTg5HspyN6B1O4xCgK354vTl+QXW 4eXw== X-Gm-Message-State: APjAAAX0vUwvHJUuVgSIMb0SrXMvKJVm+jNL+tCoCM6vG87dQ96Pgrts 6zZ7vAl51S9XY3mLmI9hzArAvN2WQLMXwDlHj1FpitJFL2D0V96qVd/l4wvqFMiwEPtwmHhyXDy TRNdnd74px1M= X-Received: by 2002:adf:df0f:: with SMTP id y15mr28082515wrl.26.1582026272516; Tue, 18 Feb 2020 03:44:32 -0800 (PST) X-Google-Smtp-Source: APXvYqwIyMFatKtQCuaV4+sP6M8P6GdCqpYyK7kyJ5jJ+QBYK7s6sHRZNcs4bFufoT+tW6C3Cy+hNQ== X-Received: by 2002:adf:df0f:: with SMTP id y15mr28082492wrl.26.1582026272302; Tue, 18 Feb 2020 03:44:32 -0800 (PST) Received: from ?IPv6:2a01:c50f:ab80:6700:527f:85b3:5615:ff0b? ([2a01:c50f:ab80:6700:527f:85b3:5615:ff0b]) by smtp.gmail.com with ESMTPSA id i16sm5530801wrr.71.2020.02.18.03.44.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2020 03:44:31 -0800 (PST) Subject: Re: [PATCH] verifiers: fix calling uninitialized function pointer To: The development of GNU GRUB , Michael Chang References: <20200218100818.28840-1-mchang@suse.com> From: Javier Martinez Canillas Message-ID: <53c2377c-90bb-40bf-c661-cf9cf41db466@redhat.com> Date: Tue, 18 Feb 2020 12:44:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200218100818.28840-1-mchang@suse.com> Content-Language: en-US X-MC-Unique: laz60ZUNPHi0B3lrpB0syw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Feb 2020 11:44:40 -0000 On 2/18/20 11:08 AM, Michael Chang wrote: > The necessary check for null before use of function ver->close is not > taking place in the failure path. This patch simply adds the missing > check and fixes the problem that grub hangs indefinitely after booting > rogue image without valid signature if secure boot turned on. > > Now it displays like this for booting rogue uefi image. > > error: bad shim signature > error: you need to load the kernel first > > Press any key to continue... > > and then you can go back to boot menu by pressing any key or after a few > seconds expired. > > Signed-off-by: Michael Chang > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier