From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbdGGMFl (ORCPT ); Fri, 7 Jul 2017 08:05:41 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36689 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbdGGMFF (ORCPT ); Fri, 7 Jul 2017 08:05:05 -0400 From: Pratyush Anand To: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, Will Deacon Cc: huawei.libin@huawei.com, Pratyush Anand , linux-kernel@vger.kernel.org Subject: [PATCH V2 2/4] arm64: use hw_breakpoint_needs_single_step() to decide if step is needed Date: Fri, 7 Jul 2017 17:33:58 +0530 Message-Id: <53c57967c400d44bb0b3b3622d8dbe0108642247.1499416107.git.panand@redhat.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently we use is_default_overflow_handler() to decide whether a "step" will be needed or not. However, is_default_overflow_handler() is true only for perf implementation. There can be some custom kernel module tests like samples/hw_breakpoint/data_breakpoint.c which can rely on default step handler. hw_breakpoint_needs_single_step() will be true if any hw_breakpoint user wants to use default step handler and sets step_needed in attribute. Signed-off-by: Pratyush Anand --- arch/arm64/kernel/hw_breakpoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/hw_breakpoint.c b/arch/arm64/kernel/hw_breakpoint.c index 749f81779420..9a73f85ab9ad 100644 --- a/arch/arm64/kernel/hw_breakpoint.c +++ b/arch/arm64/kernel/hw_breakpoint.c @@ -661,7 +661,7 @@ static int breakpoint_handler(unsigned long unused, unsigned int esr, perf_bp_event(bp, regs); /* Do we need to handle the stepping? */ - if (is_default_overflow_handler(bp)) + if (hw_breakpoint_needs_single_step(bp)) step = 1; unlock: rcu_read_unlock(); @@ -789,7 +789,7 @@ static int watchpoint_handler(unsigned long addr, unsigned int esr, perf_bp_event(wp, regs); /* Do we need to handle the stepping? */ - if (is_default_overflow_handler(wp)) + if (hw_breakpoint_needs_single_step(wp)) step = 1; } if (min_dist > 0 && min_dist != -1) { @@ -800,7 +800,7 @@ static int watchpoint_handler(unsigned long addr, unsigned int esr, perf_bp_event(wp, regs); /* Do we need to handle the stepping? */ - if (is_default_overflow_handler(wp)) + if (hw_breakpoint_needs_single_step(wp)) step = 1; } rcu_read_unlock(); -- 2.9.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: panand@redhat.com (Pratyush Anand) Date: Fri, 7 Jul 2017 17:33:58 +0530 Subject: [PATCH V2 2/4] arm64: use hw_breakpoint_needs_single_step() to decide if step is needed In-Reply-To: References: Message-ID: <53c57967c400d44bb0b3b3622d8dbe0108642247.1499416107.git.panand@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Currently we use is_default_overflow_handler() to decide whether a "step" will be needed or not. However, is_default_overflow_handler() is true only for perf implementation. There can be some custom kernel module tests like samples/hw_breakpoint/data_breakpoint.c which can rely on default step handler. hw_breakpoint_needs_single_step() will be true if any hw_breakpoint user wants to use default step handler and sets step_needed in attribute. Signed-off-by: Pratyush Anand --- arch/arm64/kernel/hw_breakpoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/hw_breakpoint.c b/arch/arm64/kernel/hw_breakpoint.c index 749f81779420..9a73f85ab9ad 100644 --- a/arch/arm64/kernel/hw_breakpoint.c +++ b/arch/arm64/kernel/hw_breakpoint.c @@ -661,7 +661,7 @@ static int breakpoint_handler(unsigned long unused, unsigned int esr, perf_bp_event(bp, regs); /* Do we need to handle the stepping? */ - if (is_default_overflow_handler(bp)) + if (hw_breakpoint_needs_single_step(bp)) step = 1; unlock: rcu_read_unlock(); @@ -789,7 +789,7 @@ static int watchpoint_handler(unsigned long addr, unsigned int esr, perf_bp_event(wp, regs); /* Do we need to handle the stepping? */ - if (is_default_overflow_handler(wp)) + if (hw_breakpoint_needs_single_step(wp)) step = 1; } if (min_dist > 0 && min_dist != -1) { @@ -800,7 +800,7 @@ static int watchpoint_handler(unsigned long addr, unsigned int esr, perf_bp_event(wp, regs); /* Do we need to handle the stepping? */ - if (is_default_overflow_handler(wp)) + if (hw_breakpoint_needs_single_step(wp)) step = 1; } rcu_read_unlock(); -- 2.9.3