From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8629EC43461 for ; Thu, 17 Sep 2020 08:38:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 520192075E for ; Thu, 17 Sep 2020 08:38:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="FBQFyK3B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbgIQIih (ORCPT ); Thu, 17 Sep 2020 04:38:37 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:4134 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgIQIie (ORCPT ); Thu, 17 Sep 2020 04:38:34 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 17 Sep 2020 01:37:43 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 17 Sep 2020 01:38:27 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 17 Sep 2020 01:38:27 -0700 Received: from [10.26.74.242] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 17 Sep 2020 08:38:24 +0000 Subject: Re: [Patch 2/2] cpufreq: tegra194: Fix unlisted boot freq warning To: Sumit Gupta , , , , , , , CC: , References: <1600276277-7290-1-git-send-email-sumitg@nvidia.com> <1600276277-7290-3-git-send-email-sumitg@nvidia.com> From: Jon Hunter Message-ID: <53d4513d-0232-0287-9610-3e9ed8888273@nvidia.com> Date: Thu, 17 Sep 2020 09:38:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1600276277-7290-3-git-send-email-sumitg@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600331863; bh=MA+kzDOpgaIasV/XTrUbK7Y5E/jn4WxvrvnA0rc5sJY=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=FBQFyK3BmMYcCS+AMC+d6rzOHscx6Cx871gJjyu9gktzGPEPSHBN1E0NPmUV+xws9 JSsI34zBL1Zmcm6ouTAxhmm09wIiTwC6/beMhPgu2LMg/kz4/POeY10s91TozWXHq5 R3gqmP2BWPtNSSY7YV0hTih6RsbIHeyQgTSdeDAnTRG9naAzgOwzjeFY3SmihwL6nw T/jtEReI2WHmixMSfuQXyuCDTpYh4zYZNN/GUOAFRU6geHQCJJ8mm9C/FqTH+XQvmv blS7uo2czX2lh4LIeA8ARFN8+P/bLBO6sKHRgt0iokxCFOh2D9X4zWASTFnkTVOBMv V/Jm7tkOWJ6NQ== Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 16/09/2020 18:11, Sumit Gupta wrote: > Warning coming during boot because the boot freq set by bootloader > gets filtered out due to big freq steps while creating freq_table. > Fixing this by setting closest ndiv value from freq_table. > Warning: > cpufreq: cpufreq_online: CPU0: Running at unlisted freq > cpufreq: cpufreq_online: CPU0: Unlisted initial frequency changed > > Also, added change in init to wait till current frequency becomes > equal or near to the previously requested frequency. This is done > because it takes some time to restore the previous frequency while > turning-on non-boot cores during exit from SC7(Suspend-to-RAM). Same here ... Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver") > > Signed-off-by: Sumit Gupta Reviewed-by: Jon Hunter Tested-by: Jon Hunter Viresh, this is also needed for v5.9. Thanks Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25649C43461 for ; Thu, 17 Sep 2020 08:39:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B841D20715 for ; Thu, 17 Sep 2020 08:39:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MP04HgXc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="FBQFyK3B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B841D20715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RSWBfzuTsiYvwK2hgd2CdpSsSHiyY0jY/hIjuEJsDsg=; b=MP04HgXcRn1l71e3mjbXpMZcW Hz4FP2kG59CMyvoZcgrMoUERTmpRZhxrv4cG03kTjbfnzajBLiVDgiGzqGIAx3OXP+8s/sq8vHLcj wrXmeAZI2kDLSynzxlNb0IErVwRalTp2eIPHGpyuYUQSSMZe3/rl/+cUsjYBwj/WsfCUVSwgahjRW WS+MlsAYOvSQ1riprutQN1igyCDwQHENlsR6I9AxqYJ6eQXZSFhxXMvV6fox3tI++zhH9wwMWAUcl xrotBbAbZ/+oSKBEXI6sCA+3snRgvltLYiZ1wZq4vqib7L9pzsFjHbxB0vtcsMFfwWyUqVWxGpnwp azvm1FhkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIpR2-0001DW-03; Thu, 17 Sep 2020 08:38:32 +0000 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIpQy-0001BI-M9 for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 08:38:29 +0000 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 17 Sep 2020 01:37:43 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 17 Sep 2020 01:38:27 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 17 Sep 2020 01:38:27 -0700 Received: from [10.26.74.242] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 17 Sep 2020 08:38:24 +0000 Subject: Re: [Patch 2/2] cpufreq: tegra194: Fix unlisted boot freq warning To: Sumit Gupta , , , , , , , References: <1600276277-7290-1-git-send-email-sumitg@nvidia.com> <1600276277-7290-3-git-send-email-sumitg@nvidia.com> From: Jon Hunter Message-ID: <53d4513d-0232-0287-9610-3e9ed8888273@nvidia.com> Date: Thu, 17 Sep 2020 09:38:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1600276277-7290-3-git-send-email-sumitg@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600331863; bh=MA+kzDOpgaIasV/XTrUbK7Y5E/jn4WxvrvnA0rc5sJY=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=FBQFyK3BmMYcCS+AMC+d6rzOHscx6Cx871gJjyu9gktzGPEPSHBN1E0NPmUV+xws9 JSsI34zBL1Zmcm6ouTAxhmm09wIiTwC6/beMhPgu2LMg/kz4/POeY10s91TozWXHq5 R3gqmP2BWPtNSSY7YV0hTih6RsbIHeyQgTSdeDAnTRG9naAzgOwzjeFY3SmihwL6nw T/jtEReI2WHmixMSfuQXyuCDTpYh4zYZNN/GUOAFRU6geHQCJJ8mm9C/FqTH+XQvmv blS7uo2czX2lh4LIeA8ARFN8+P/bLBO6sKHRgt0iokxCFOh2D9X4zWASTFnkTVOBMv V/Jm7tkOWJ6NQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_043828_835476_DD237256 X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ksitaraman@nvidia.com, bbasu@nvidia.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/09/2020 18:11, Sumit Gupta wrote: > Warning coming during boot because the boot freq set by bootloader > gets filtered out due to big freq steps while creating freq_table. > Fixing this by setting closest ndiv value from freq_table. > Warning: > cpufreq: cpufreq_online: CPU0: Running at unlisted freq > cpufreq: cpufreq_online: CPU0: Unlisted initial frequency changed > > Also, added change in init to wait till current frequency becomes > equal or near to the previously requested frequency. This is done > because it takes some time to restore the previous frequency while > turning-on non-boot cores during exit from SC7(Suspend-to-RAM). Same here ... Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver") > > Signed-off-by: Sumit Gupta Reviewed-by: Jon Hunter Tested-by: Jon Hunter Viresh, this is also needed for v5.9. Thanks Jon -- nvpublic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel