From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B68BC433FE for ; Mon, 21 Nov 2022 17:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbiKURFt (ORCPT ); Mon, 21 Nov 2022 12:05:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229947AbiKURFg (ORCPT ); Mon, 21 Nov 2022 12:05:36 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD25C6D01; Mon, 21 Nov 2022 09:05:35 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id i64-20020a1c3b43000000b003d016c21100so3671367wma.3; Mon, 21 Nov 2022 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=aMKwG0neuXdoNBJBy55LDxor41lGbfQMps+JlNnHqgoiOxjrPOtxdSE4RsHOecn/zZ UL8K7CG/gfcDLfDwRG2eluolShQ/8EH+mKVLF9yhV+Jd76lhsOyTqeJbI2W5X9IPIxh1 yHRkJ91sF/u07+Rj0pUzoR3KynwVymat66kmdiUHqPs2Xti/MrOj4ll60J/uCVSR4XnX R42niY3I8FM6vWjMH6Wkrj8eqfXqLhk5K0GEyQqhQJVxTKkRONnDELnEBjspckBt68hg 0Ts0diRaHbiI/L+6P9aSduy/8I64EiyzVkMPsay2JUloz4KcNoCs3RphVpBxd18f8h0D xaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=G/MHEG00U1g2ZeXtVicB8Lgv4+votxpygOOWJAlLjjdUumMucgKlUd5EEWLalykHzo FhI0DBQNorI1bFryhRVKrYk9TEgf344Fr2JLHZx5Wti7FjewHNgYzaNsIzwXK2WX6q6d IYV8h8r1mvZaD/d9dhkt8rMMovHZgVFZD1WMvwauR/YHYFQmsNAt62qzRaGr7Cvv29LL WdbZXlHs4JuoHC60j9YsnvaJvdm98ggZiOF/ItMIEHOW9mWic3aSeDB1xWJ48EdtTkZI sHFQYKidjSCT76EzFLUBoO6ubKVXnjsGrNZ0fLjaYmdP9TNLdsF457A6NRwzG76DIaqF 991g== X-Gm-Message-State: ANoB5pmL8A4HKpRHSglpeggApjecHe9g6FfcuJvMOvYZt+3nX16Grojl UT1TSXJcPJUVRt5fH47E+QQ= X-Google-Smtp-Source: AA0mqf6071ld2DQr5qO+/kKEHgogUnSmTC4vQ9vKrpj5EJuxP+w5Y+6e1Xaod0BnpQlAlpY4LP+xlw== X-Received: by 2002:a05:600c:6012:b0:3cf:cb16:f242 with SMTP id az18-20020a05600c601200b003cfcb16f242mr5063589wmb.82.1669050334101; Mon, 21 Nov 2022 09:05:34 -0800 (PST) Received: from [192.168.1.131] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id w19-20020adfbad3000000b00241c6729c2bsm8621083wrg.26.2022.11.21.09.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 09:05:32 -0800 (PST) Message-ID: <53d6f1a2-86c8-409e-6b4a-d4e0f181adde@gmail.com> Date: Mon, 21 Nov 2022 18:05:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 04/11] dt-bindings: PCI: mediatek-gen3: add SoC based clock config Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, Rob Herring , AngeloGioacchino Del Regno References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-5-linux@fw-web.de> From: Matthias Brugger In-Reply-To: <20221118190126.100895-5-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/2022 20:01, Frank Wunderlich wrote: > From: Frank Wunderlich > > The PCIe driver covers different SOC which needing different clock > configs. Define them based on compatible. > > Signed-off-by: Frank Wunderlich > Reviewed-by: Rob Herring > Acked-by: Jianjun Wang > Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger > --- > v2: > - fix typo in mediatek,mt8192-pcie > v3: > - remove contains to match only if compatible is no fallback > tested with series "Add driver nodes for MT8195 SoC" and mt7986 > pcie-nodes, dtbs_check is now clean > --- > .../bindings/pci/mediatek-pcie-gen3.yaml | 47 ++++++++++++++----- > 1 file changed, 35 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index c00be39af64e..5d7369debff2 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -43,9 +43,6 @@ description: |+ > each set has its own address for MSI message, and supports 32 MSI vectors > to generate interrupt. > > -allOf: > - - $ref: /schemas/pci/pci-bus.yaml# > - > properties: > compatible: > oneOf: > @@ -84,15 +81,7 @@ properties: > maxItems: 6 > > clock-names: > - items: > - - const: pl_250m > - - const: tl_26m > - - const: tl_96m > - - const: tl_32k > - - const: peri_26m > - - enum: > - - top_133m # for MT8192 > - - peri_mem # for MT8188/MT8195 > + maxItems: 6 > > assigned-clocks: > maxItems: 1 > @@ -138,6 +127,40 @@ required: > - '#interrupt-cells' > - interrupt-controller > > +allOf: > + - $ref: /schemas/pci/pci-bus.yaml# > + - if: > + properties: > + compatible: > + const: mediatek,mt8192-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: top_133m > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8188-pcie > + - mediatek,mt8195-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: peri_mem > + > unevaluatedProperties: false > > examples: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FE91C43219 for ; Mon, 21 Nov 2022 17:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=tiMqnd+ceuVNtd Lr32vw54CE9MSCXXBnEY/e4tFAkYKbV2afaEps3S76O/VPSQhK2yRAc8QXokv3aghHuIhqScWyiRd BuKpeg2OE3p5oWaDxXEKc5DjWNrPzazv34f9riJICC2hZdKZrPm8TRP+qmiBEYM3aYjmz8RTC21xT QCEFNoBM2MZ2WU+B3VKhmFxwVKGZ75MNb/8sNctryLRKZE6hZQXa8BqAyyuAh4nqe2gGTwfdvM8zf 4pHZE+fHRbHnoS4sjhaKquUReXY2ynbIzAwY/gSPsHz4bKa9nsWJ45Yq9BVgwkse76yqN/YCsSrAy rGaUfuZRwuZVD8k3Uktg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxAEn-00G9Bt-N4; Mon, 21 Nov 2022 17:05:41 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxAEk-00G97G-G9; Mon, 21 Nov 2022 17:05:39 +0000 Received: by mail-wm1-x335.google.com with SMTP id r10-20020a1c440a000000b003d0283bf132so509481wma.4; Mon, 21 Nov 2022 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=aMKwG0neuXdoNBJBy55LDxor41lGbfQMps+JlNnHqgoiOxjrPOtxdSE4RsHOecn/zZ UL8K7CG/gfcDLfDwRG2eluolShQ/8EH+mKVLF9yhV+Jd76lhsOyTqeJbI2W5X9IPIxh1 yHRkJ91sF/u07+Rj0pUzoR3KynwVymat66kmdiUHqPs2Xti/MrOj4ll60J/uCVSR4XnX R42niY3I8FM6vWjMH6Wkrj8eqfXqLhk5K0GEyQqhQJVxTKkRONnDELnEBjspckBt68hg 0Ts0diRaHbiI/L+6P9aSduy/8I64EiyzVkMPsay2JUloz4KcNoCs3RphVpBxd18f8h0D xaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=d3JgbUQZsPTscRuUs6EWE4DP/hqBowXIB+lxPx/uEYTBdxh2IFr9bg6sjRRtoAjK/0 1TYx6lw9VEGqKuLQQyE52AwoHnC9A2PHz182y9/FrNiqhQshCsRfD9/mkqYN6HJLn+l2 ykTQmHlEp4SUYCZDwkqKK4ybtDiY276i8SAOIkRAMjDjKde2/S2KQzVZVSaeVE9xF84Q 2yuRHOd1T0v9Sfog9VUmk7hT4LdUbpOVx1XtKzbKCP4YoqZLdrmGJhrocosDZH7bLL5r BLCN7WYtwpk65d8on1BN+HEL9Qi/ZiGFkxBEFpXl0+Q/XFKkEgXVtweOkbhx5l4dZl5b GzxA== X-Gm-Message-State: ANoB5pmE1Ub9j64f5mFhuOpgNyhyTOT1wSIdTvYBQT2RtQ/C86ar3Z7f x10Z0rr5cVyoeu/GaOmnzpc= X-Google-Smtp-Source: AA0mqf6071ld2DQr5qO+/kKEHgogUnSmTC4vQ9vKrpj5EJuxP+w5Y+6e1Xaod0BnpQlAlpY4LP+xlw== X-Received: by 2002:a05:600c:6012:b0:3cf:cb16:f242 with SMTP id az18-20020a05600c601200b003cfcb16f242mr5063589wmb.82.1669050334101; Mon, 21 Nov 2022 09:05:34 -0800 (PST) Received: from [192.168.1.131] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id w19-20020adfbad3000000b00241c6729c2bsm8621083wrg.26.2022.11.21.09.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 09:05:32 -0800 (PST) Message-ID: <53d6f1a2-86c8-409e-6b4a-d4e0f181adde@gmail.com> Date: Mon, 21 Nov 2022 18:05:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 04/11] dt-bindings: PCI: mediatek-gen3: add SoC based clock config Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-5-linux@fw-web.de> From: Matthias Brugger In-Reply-To: <20221118190126.100895-5-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_090538_585349_BE18F3CC X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ryder Lee , Bo Jiao , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Kishon Vijay Abraham I , Jianjun Wang , Chunfeng Yun , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-pci@vger.kernel.org, Bjorn Helgaas , Paolo Abeni , Lorenzo Bianconi , Rob Herring , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 18/11/2022 20:01, Frank Wunderlich wrote: > From: Frank Wunderlich > > The PCIe driver covers different SOC which needing different clock > configs. Define them based on compatible. > > Signed-off-by: Frank Wunderlich > Reviewed-by: Rob Herring > Acked-by: Jianjun Wang > Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger > --- > v2: > - fix typo in mediatek,mt8192-pcie > v3: > - remove contains to match only if compatible is no fallback > tested with series "Add driver nodes for MT8195 SoC" and mt7986 > pcie-nodes, dtbs_check is now clean > --- > .../bindings/pci/mediatek-pcie-gen3.yaml | 47 ++++++++++++++----- > 1 file changed, 35 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index c00be39af64e..5d7369debff2 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -43,9 +43,6 @@ description: |+ > each set has its own address for MSI message, and supports 32 MSI vectors > to generate interrupt. > > -allOf: > - - $ref: /schemas/pci/pci-bus.yaml# > - > properties: > compatible: > oneOf: > @@ -84,15 +81,7 @@ properties: > maxItems: 6 > > clock-names: > - items: > - - const: pl_250m > - - const: tl_26m > - - const: tl_96m > - - const: tl_32k > - - const: peri_26m > - - enum: > - - top_133m # for MT8192 > - - peri_mem # for MT8188/MT8195 > + maxItems: 6 > > assigned-clocks: > maxItems: 1 > @@ -138,6 +127,40 @@ required: > - '#interrupt-cells' > - interrupt-controller > > +allOf: > + - $ref: /schemas/pci/pci-bus.yaml# > + - if: > + properties: > + compatible: > + const: mediatek,mt8192-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: top_133m > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8188-pcie > + - mediatek,mt8195-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: peri_mem > + > unevaluatedProperties: false > > examples: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C037C433FE for ; Mon, 21 Nov 2022 17:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M1zzupju6cs6TwOqjeIVADwLWbMd667/ltTZKQK+Sdk=; b=XY8grJ2AhL69B9 oApx7t6r1EKUWKPMj9P7HSUQG7qDbB32txtK/xl8x8b7pLbuUfaB8cKQ2ytPK6tvXlqrY+UTlghwD crlG/pOj30qVnU+hoPUDAb8uULP7PCa5mme+8YqNiMQvIM/SbXTqfbOQKaUu+ZIw6P8f/kcRm/UpM mK5j+UN5WMHZJ87viubIWXUB81AJTQt0WI8ZFxf96mM0cfFZN4KjzNGRnplmlIfUkGPQcv3Xe5L2N zkKp4HM0j9PVIV3uKJAVCsA6aUVDJFvvh5TN5jpiPcgGVBaAHFpSlVQAQht85q12ETf48ZqJo9eWV jqIFybrGmQBt8nCw3mUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxAFE-00G9PG-P1; Mon, 21 Nov 2022 17:06:08 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxAEk-00G97G-G9; Mon, 21 Nov 2022 17:05:39 +0000 Received: by mail-wm1-x335.google.com with SMTP id r10-20020a1c440a000000b003d0283bf132so509481wma.4; Mon, 21 Nov 2022 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=aMKwG0neuXdoNBJBy55LDxor41lGbfQMps+JlNnHqgoiOxjrPOtxdSE4RsHOecn/zZ UL8K7CG/gfcDLfDwRG2eluolShQ/8EH+mKVLF9yhV+Jd76lhsOyTqeJbI2W5X9IPIxh1 yHRkJ91sF/u07+Rj0pUzoR3KynwVymat66kmdiUHqPs2Xti/MrOj4ll60J/uCVSR4XnX R42niY3I8FM6vWjMH6Wkrj8eqfXqLhk5K0GEyQqhQJVxTKkRONnDELnEBjspckBt68hg 0Ts0diRaHbiI/L+6P9aSduy/8I64EiyzVkMPsay2JUloz4KcNoCs3RphVpBxd18f8h0D xaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=d3JgbUQZsPTscRuUs6EWE4DP/hqBowXIB+lxPx/uEYTBdxh2IFr9bg6sjRRtoAjK/0 1TYx6lw9VEGqKuLQQyE52AwoHnC9A2PHz182y9/FrNiqhQshCsRfD9/mkqYN6HJLn+l2 ykTQmHlEp4SUYCZDwkqKK4ybtDiY276i8SAOIkRAMjDjKde2/S2KQzVZVSaeVE9xF84Q 2yuRHOd1T0v9Sfog9VUmk7hT4LdUbpOVx1XtKzbKCP4YoqZLdrmGJhrocosDZH7bLL5r BLCN7WYtwpk65d8on1BN+HEL9Qi/ZiGFkxBEFpXl0+Q/XFKkEgXVtweOkbhx5l4dZl5b GzxA== X-Gm-Message-State: ANoB5pmE1Ub9j64f5mFhuOpgNyhyTOT1wSIdTvYBQT2RtQ/C86ar3Z7f x10Z0rr5cVyoeu/GaOmnzpc= X-Google-Smtp-Source: AA0mqf6071ld2DQr5qO+/kKEHgogUnSmTC4vQ9vKrpj5EJuxP+w5Y+6e1Xaod0BnpQlAlpY4LP+xlw== X-Received: by 2002:a05:600c:6012:b0:3cf:cb16:f242 with SMTP id az18-20020a05600c601200b003cfcb16f242mr5063589wmb.82.1669050334101; Mon, 21 Nov 2022 09:05:34 -0800 (PST) Received: from [192.168.1.131] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id w19-20020adfbad3000000b00241c6729c2bsm8621083wrg.26.2022.11.21.09.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 09:05:32 -0800 (PST) Message-ID: <53d6f1a2-86c8-409e-6b4a-d4e0f181adde@gmail.com> Date: Mon, 21 Nov 2022 18:05:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 04/11] dt-bindings: PCI: mediatek-gen3: add SoC based clock config Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, Rob Herring , AngeloGioacchino Del Regno References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-5-linux@fw-web.de> From: Matthias Brugger In-Reply-To: <20221118190126.100895-5-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_090538_585349_BE18F3CC X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 18/11/2022 20:01, Frank Wunderlich wrote: > From: Frank Wunderlich > > The PCIe driver covers different SOC which needing different clock > configs. Define them based on compatible. > > Signed-off-by: Frank Wunderlich > Reviewed-by: Rob Herring > Acked-by: Jianjun Wang > Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger > --- > v2: > - fix typo in mediatek,mt8192-pcie > v3: > - remove contains to match only if compatible is no fallback > tested with series "Add driver nodes for MT8195 SoC" and mt7986 > pcie-nodes, dtbs_check is now clean > --- > .../bindings/pci/mediatek-pcie-gen3.yaml | 47 ++++++++++++++----- > 1 file changed, 35 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index c00be39af64e..5d7369debff2 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -43,9 +43,6 @@ description: |+ > each set has its own address for MSI message, and supports 32 MSI vectors > to generate interrupt. > > -allOf: > - - $ref: /schemas/pci/pci-bus.yaml# > - > properties: > compatible: > oneOf: > @@ -84,15 +81,7 @@ properties: > maxItems: 6 > > clock-names: > - items: > - - const: pl_250m > - - const: tl_26m > - - const: tl_96m > - - const: tl_32k > - - const: peri_26m > - - enum: > - - top_133m # for MT8192 > - - peri_mem # for MT8188/MT8195 > + maxItems: 6 > > assigned-clocks: > maxItems: 1 > @@ -138,6 +127,40 @@ required: > - '#interrupt-cells' > - interrupt-controller > > +allOf: > + - $ref: /schemas/pci/pci-bus.yaml# > + - if: > + properties: > + compatible: > + const: mediatek,mt8192-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: top_133m > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8188-pcie > + - mediatek,mt8195-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: peri_mem > + > unevaluatedProperties: false > > examples: -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49AE3C47089 for ; Mon, 21 Nov 2022 17:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dUq0ka+odDi/D6ioBt7eL9rjIEGoPVweZK1LL/6t69o=; b=x8q6WaSqhe9lfM 5lwyZhz+FVQxQKd2TJOsdmmz+I9EmDM5VafE/kIFvAw+GkyIyrF/Z65NqLCpvSAu3ILU37G3OGhNT 6DpXRdx/OAzLjcw3lLUV1g0DtVNTaFYpL5xIIFnLs7o/1/uzFWeNkY5AMH4M8KgYGMVvCDkoSAQWJ /iD/W2w7bocKIFBgdqDEIAy+TomIKj+acX4FLOKd8m04l9KC6hh5Khqbqp4OMk8q4bw0M6I4T0elR 08ZkuD2pBV1YX7eu+4KsyX1aLhL7ibT0h4p+V7gYFF697yXIey/TWfTigYk6+mG0hcXCbSTKMpyUk BHlIjCZQ/5JY4KXfweqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxAEp-00G9CU-HA; Mon, 21 Nov 2022 17:05:43 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxAEk-00G97G-G9; Mon, 21 Nov 2022 17:05:39 +0000 Received: by mail-wm1-x335.google.com with SMTP id r10-20020a1c440a000000b003d0283bf132so509481wma.4; Mon, 21 Nov 2022 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=aMKwG0neuXdoNBJBy55LDxor41lGbfQMps+JlNnHqgoiOxjrPOtxdSE4RsHOecn/zZ UL8K7CG/gfcDLfDwRG2eluolShQ/8EH+mKVLF9yhV+Jd76lhsOyTqeJbI2W5X9IPIxh1 yHRkJ91sF/u07+Rj0pUzoR3KynwVymat66kmdiUHqPs2Xti/MrOj4ll60J/uCVSR4XnX R42niY3I8FM6vWjMH6Wkrj8eqfXqLhk5K0GEyQqhQJVxTKkRONnDELnEBjspckBt68hg 0Ts0diRaHbiI/L+6P9aSduy/8I64EiyzVkMPsay2JUloz4KcNoCs3RphVpBxd18f8h0D xaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wQ34R1ClvRJ30zGsVGp2RiEaSuUp9nthQZpzgznhpr8=; b=d3JgbUQZsPTscRuUs6EWE4DP/hqBowXIB+lxPx/uEYTBdxh2IFr9bg6sjRRtoAjK/0 1TYx6lw9VEGqKuLQQyE52AwoHnC9A2PHz182y9/FrNiqhQshCsRfD9/mkqYN6HJLn+l2 ykTQmHlEp4SUYCZDwkqKK4ybtDiY276i8SAOIkRAMjDjKde2/S2KQzVZVSaeVE9xF84Q 2yuRHOd1T0v9Sfog9VUmk7hT4LdUbpOVx1XtKzbKCP4YoqZLdrmGJhrocosDZH7bLL5r BLCN7WYtwpk65d8on1BN+HEL9Qi/ZiGFkxBEFpXl0+Q/XFKkEgXVtweOkbhx5l4dZl5b GzxA== X-Gm-Message-State: ANoB5pmE1Ub9j64f5mFhuOpgNyhyTOT1wSIdTvYBQT2RtQ/C86ar3Z7f x10Z0rr5cVyoeu/GaOmnzpc= X-Google-Smtp-Source: AA0mqf6071ld2DQr5qO+/kKEHgogUnSmTC4vQ9vKrpj5EJuxP+w5Y+6e1Xaod0BnpQlAlpY4LP+xlw== X-Received: by 2002:a05:600c:6012:b0:3cf:cb16:f242 with SMTP id az18-20020a05600c601200b003cfcb16f242mr5063589wmb.82.1669050334101; Mon, 21 Nov 2022 09:05:34 -0800 (PST) Received: from [192.168.1.131] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id w19-20020adfbad3000000b00241c6729c2bsm8621083wrg.26.2022.11.21.09.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 09:05:32 -0800 (PST) Message-ID: <53d6f1a2-86c8-409e-6b4a-d4e0f181adde@gmail.com> Date: Mon, 21 Nov 2022 18:05:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 04/11] dt-bindings: PCI: mediatek-gen3: add SoC based clock config Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, Rob Herring , AngeloGioacchino Del Regno References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-5-linux@fw-web.de> From: Matthias Brugger In-Reply-To: <20221118190126.100895-5-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_090538_585349_BE18F3CC X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/11/2022 20:01, Frank Wunderlich wrote: > From: Frank Wunderlich > > The PCIe driver covers different SOC which needing different clock > configs. Define them based on compatible. > > Signed-off-by: Frank Wunderlich > Reviewed-by: Rob Herring > Acked-by: Jianjun Wang > Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger > --- > v2: > - fix typo in mediatek,mt8192-pcie > v3: > - remove contains to match only if compatible is no fallback > tested with series "Add driver nodes for MT8195 SoC" and mt7986 > pcie-nodes, dtbs_check is now clean > --- > .../bindings/pci/mediatek-pcie-gen3.yaml | 47 ++++++++++++++----- > 1 file changed, 35 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index c00be39af64e..5d7369debff2 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -43,9 +43,6 @@ description: |+ > each set has its own address for MSI message, and supports 32 MSI vectors > to generate interrupt. > > -allOf: > - - $ref: /schemas/pci/pci-bus.yaml# > - > properties: > compatible: > oneOf: > @@ -84,15 +81,7 @@ properties: > maxItems: 6 > > clock-names: > - items: > - - const: pl_250m > - - const: tl_26m > - - const: tl_96m > - - const: tl_32k > - - const: peri_26m > - - enum: > - - top_133m # for MT8192 > - - peri_mem # for MT8188/MT8195 > + maxItems: 6 > > assigned-clocks: > maxItems: 1 > @@ -138,6 +127,40 @@ required: > - '#interrupt-cells' > - interrupt-controller > > +allOf: > + - $ref: /schemas/pci/pci-bus.yaml# > + - if: > + properties: > + compatible: > + const: mediatek,mt8192-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: top_133m > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8188-pcie > + - mediatek,mt8195-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: tl_96m > + - const: tl_32k > + - const: peri_26m > + - const: peri_mem > + > unevaluatedProperties: false > > examples: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel