All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	x86@kernel.org
Cc: boris.ostrovsky@oracle.com, hpa@zytor.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, Waiman.Long@hp.com,
	peterz@infradead.org
Subject: Re: [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
Date: Tue, 9 Oct 2018 16:52:28 +0200	[thread overview]
Message-ID: <53dc092d-a09c-beb4-f81f-399286da0ecd@suse.com> (raw)
In-Reply-To: <762802a4b8ff21e43e59e222e472ab9b23fc43cd.camel@infradead.org>

On 09/10/2018 16:40, David Woodhouse wrote:
> On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote:
>> The Xen specific queue spinlock wait function has two issues which
>> could result in a hanging system.
>>
>> They have a similar root cause of clearing a pending wakeup of a
>> waiting vcpu and later going to sleep waiting for the just cleared
>> wakeup event, which of course won't ever happen.
>>
>> Juergen Gross (2):
>>   xen: fix race in xen_qlock_wait()
>>   xen: make xen_qlock_wait() nestable
>>
>>  arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
>>  1 file changed, 12 insertions(+), 21 deletions(-)
>>
>> Cc: Waiman.Long@hp.com
>> Cc: peterz@infradead.org
> 
> LGTM. Both these should be Cc:stable@vger.kernel.org, yes?

Yes, they are.

I have them already queued in the Xen tree. As the bug is rather
old I didn't want to rush the patches in so late in the rc phase of
4.19.


Juergen

  parent reply	other threads:[~2018-10-09 14:52 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01  7:16 [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling Juergen Gross
2018-10-01  7:16 ` [PATCH 1/2] xen: fix race in xen_qlock_wait() Juergen Gross
2018-10-01  7:37   ` Juergen Gross
2018-10-01  7:37   ` Juergen Gross
2018-10-01  8:54   ` Jan Beulich
2018-10-01  8:54   ` [Xen-devel] " Jan Beulich
2018-10-01  7:16 ` Juergen Gross
2018-10-01  7:16 ` [PATCH 2/2] xen: make xen_qlock_wait() nestable Juergen Gross
2018-10-01  7:16 ` Juergen Gross
2018-10-01  7:38   ` Juergen Gross
2018-10-01  7:38   ` Juergen Gross
2018-10-01  8:57   ` Jan Beulich
2018-10-01  8:57   ` [Xen-devel] " Jan Beulich
     [not found]   ` <5BB1E18802000078001ED127@suse.com>
2018-10-01  9:03     ` Juergen Gross
2018-10-01  9:18       ` Jan Beulich
2018-10-01  9:18       ` Jan Beulich
2018-10-10 11:53   ` David Woodhouse
2018-10-10 12:30     ` Thomas Gleixner
2018-10-10 12:30     ` Thomas Gleixner
2018-10-10 12:44       ` David Woodhouse
2018-10-10 12:47         ` Thomas Gleixner
2018-10-10 12:47         ` Thomas Gleixner
2018-10-10 13:38           ` Juergen Gross
2018-10-10 13:53             ` David Woodhouse
2018-10-10 13:53             ` David Woodhouse
2018-10-10 13:38           ` Juergen Gross
2018-10-10 12:44       ` David Woodhouse
2018-10-10 11:53   ` David Woodhouse
2018-10-01  7:37 ` [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling Juergen Gross
2018-10-01  7:37 ` Juergen Gross
2018-10-09 14:40 ` David Woodhouse
2018-10-09 14:52   ` Juergen Gross
2018-10-09 14:52   ` Juergen Gross [this message]
2018-10-09 14:40 ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2018-10-01  7:16 Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53dc092d-a09c-beb4-f81f-399286da0ecd@suse.com \
    --to=jgross@suse.com \
    --cc=Waiman.Long@hp.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.