All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] fdt: Allow indicating a node is for U-Boot proper only
Date: Tue, 5 Feb 2019 09:54:44 +0100	[thread overview]
Message-ID: <53f1641f-7c55-9a34-8655-7bc41bc01d26@denx.de> (raw)
In-Reply-To: <CAPnjgZ02cTKAp5GNPMGEMUPkhw74dFF620-4Z3MLS_ADhpcf6g@mail.gmail.com>

On 2/4/19 3:40 PM, Simon Glass wrote:
> On Mon, 4 Feb 2019 at 03:15, Patrick Delaunay <patrick.delaunay@st.com> wrote:
>>
>> This add missing parts for previous commit 06f94461a9f4
>> ("fdt: Allow indicating a node is for U-Boot proper only")
>>
>> At present it is not possible to specify that a node should be used before
>> relocation (in U-Boot proper) without it also ending up in SPL and TPL
>> device trees. Add a new "u-boot,dm-pre-proper" boolean property for this.
>>
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> There was discussion some time ago about using a property instead:
> 
> chosen {
>    u-boot,dm-spl = <&node1 &node2>;
>     u-boot,dm-tpl = <&node1>;
> };
> 
> At the time I decided that this was more painful since it separates
> out the tag from its node.
> 
> I wonder if that is still true? We do now in fact generally use a
> u-boot.dtsi file to hold these tags.
> 
> I'm not suggesting a change, just raising the question.

It's a good suggestion. In fact, you can then use some tool to walk back
up the tree and only retain the branches which are referenced by phandle
from u-boot,dm-spl/tpl node for U-Boot SPL/TPL DTs. I think that could
save a bit of space too. I wonder if we can even use /omit-if-no-ref/
DTC syntax somehow.

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2019-02-05  8:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 10:14 [U-Boot] [PATCH 1/2] fdt: Allow indicating a node is for U-Boot proper only Patrick Delaunay
2019-02-04 10:14 ` [U-Boot] [PATCH 2/2] dm: core: remove the duplicated function dm_ofnode_pre_reloc Patrick Delaunay
2019-02-04 14:40   ` Simon Glass
2019-02-06  9:26     ` Patrick DELAUNAY
2019-02-04 14:40 ` [U-Boot] [PATCH 1/2] fdt: Allow indicating a node is for U-Boot proper only Simon Glass
2019-02-05  8:54   ` Marek Vasut [this message]
2019-02-07 17:40     ` Patrick DELAUNAY
2019-02-07 17:47       ` Marek Vasut
2019-02-08 12:47         ` Patrick DELAUNAY
2019-02-11 11:56         ` Patrick DELAUNAY
2019-02-11 11:58           ` Marek Vasut
2019-02-11 14:34             ` Patrick DELAUNAY
2019-05-18 16:20               ` Simon Glass
2019-05-20  7:41                 ` Patrick DELAUNAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53f1641f-7c55-9a34-8655-7bc41bc01d26@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.