From: Felix Kuehling <felix.kuehling@amd.com>
To: Eric Huang <JinhuiEric.Huang@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd: change SDMA MQD memory type
Date: Wed, 26 Feb 2020 15:00:59 -0600 [thread overview]
Message-ID: <53f26edc-de4d-c66b-e585-635424e3d290@amd.com> (raw)
In-Reply-To: <1582745831-6902-1-git-send-email-JinhuiEric.Huang@amd.com>
On 2020-02-26 14:37, Eric Huang wrote:
> SDMA MQD memory type is NC that causes MQD data overwritten
> accidentally by an old stable cache line. Changing it to UC
> default for GART will fix the issue.
Maybe add a statement here, that the mqd_gfx9 parameter is meant for
control stacks that are allocated together with user mode queue MQDs.
Setting mqd_gfx9 to true maps the control stack pages as NC. Here it was
accidentally applied to SDMA MQDs, which are allocated together with the
HIQ MQD. Setting the mqd_gfx9 to false avoids that.
>
> Change-Id: If609f47c78cb97e2c8dc930df2ab5c10c29dfe56
> Signed-off-by: Eric Huang <jinhuieric.huang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 692abfd..77ea0f0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -1734,7 +1734,7 @@ static int allocate_hiq_sdma_mqd(struct device_queue_manager *dqm)
>
> retval = amdgpu_amdkfd_alloc_gtt_mem(dev->kgd, size,
> &(mem_obj->gtt_mem), &(mem_obj->gpu_addr),
> - (void *)&(mem_obj->cpu_ptr), true);
> + (void *)&(mem_obj->cpu_ptr), false);
>
> return retval;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-02-26 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 19:37 [PATCH] drm/amdkfd: change SDMA MQD memory type Eric Huang
2020-02-26 20:34 ` Zhao, Yong
2020-02-26 21:00 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f26edc-de4d-c66b-e585-635424e3d290@amd.com \
--to=felix.kuehling@amd.com \
--cc=JinhuiEric.Huang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.