All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] ccache: change default cache directory path to match config setting
Date: Thu, 01 May 2014 16:01:10 +0200	[thread overview]
Message-ID: <53f80af5-57d2-42f1-a383-e5df43bac90b@email.android.com> (raw)
In-Reply-To: <CANxTyt69TvC8xwbbuhgy+x70qRN4Xaq1Zx6=bLcTx+8TF0VVfA@mail.gmail.com>

Danomi Manchego <danomimanchego123@gmail.com> schreef:
>Thomas,
>
>On Thu, May 1, 2014 at 1:52 AM, Thomas De Schampheleire
><patrickdepinguin@gmail.com> wrote:
>> You  should have pasted my review and test tags here...
>>
>> Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>> Tested-by : Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
>Such tags survive the rev process?  In this case, this patch didn't
>change from v2 to v3, but in general, I thought it might be
>disingenuous to claim those fields on rev X, when they were granted on
>rev X-n ...

They only survive on unchanged revisions, which was the case on this first patch. Indeed for changed revisions, like the second patch, any tag should not be copy pasted as the content is different.

Best regards,
Thomas

  reply	other threads:[~2014-05-01 14:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01  2:05 [Buildroot] [PATCH v3 1/2] ccache: change default cache directory path to match config setting Danomi Manchego
2014-05-01  2:05 ` [Buildroot] [PATCH v3 2/2] ccache: provide capability to do initial ccache setup Danomi Manchego
2014-05-02  8:29   ` Thomas De Schampheleire
2014-06-14 18:01   ` Thomas Petazzoni
2014-05-01  5:52 ` [Buildroot] [PATCH v3 1/2] ccache: change default cache directory path to match config setting Thomas De Schampheleire
2014-05-01 13:40   ` Danomi Manchego
2014-05-01 14:01     ` Thomas De Schampheleire [this message]
2014-06-14 17:58 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53f80af5-57d2-42f1-a383-e5df43bac90b@email.android.com \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.