From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, nsoffer@redhat.com,
Markus Armbruster <armbru@redhat.com>,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v4 4/9] blockdev: Promote several bitmap functions to non-static
Date: Thu, 14 May 2020 09:10:21 -0500 [thread overview]
Message-ID: <53febccd-39b7-1326-7629-57f0b41b3ffa@redhat.com> (raw)
In-Reply-To: <d47772a1-7d95-74fb-4dab-fa0bad02a0cf@virtuozzo.com>
On 5/14/20 6:45 AM, Vladimir Sementsov-Ogievskiy wrote:
> 13.05.2020 04:16, Eric Blake wrote:
>> - HBitmap **backup, Error **errp)
>> +BdrvDirtyBitmap *block_dirty_bitmap_merge(const char *node, const
>> char *target,
>> +
>> BlockDirtyBitmapMergeSourceList *bitmaps,
>> + HBitmap **backup, Error
>> **errp)
>> {
>> BlockDriverState *bs;
>
> s/bitmaps/bms/ to match declaration and fit into 80 characters
Can do, although it has ripple effects to 5/9 (as I wanted that to be
pure code motion).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-14 14:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 1:16 [PATCH v4 0/9] qemu-img: Add convert --bitmaps Eric Blake
2020-05-13 1:16 ` [PATCH v4 1/9] docs: Sort sections on qemu-img subcommand parameters Eric Blake
2020-05-14 5:02 ` Vladimir Sementsov-Ogievskiy
2020-05-13 1:16 ` [PATCH v4 2/9] qemu-img: Fix stale comments on doc location Eric Blake
2020-05-14 5:06 ` Vladimir Sementsov-Ogievskiy
2020-05-13 1:16 ` [PATCH v4 3/9] block: Make it easier to learn which BDS support bitmaps Eric Blake
2020-05-14 5:19 ` Vladimir Sementsov-Ogievskiy
2020-05-14 14:09 ` Eric Blake
2020-05-13 1:16 ` [PATCH v4 4/9] blockdev: Promote several bitmap functions to non-static Eric Blake
2020-05-14 5:45 ` Vladimir Sementsov-Ogievskiy
2020-05-14 11:45 ` Vladimir Sementsov-Ogievskiy
2020-05-14 14:10 ` Eric Blake [this message]
2020-05-13 1:16 ` [PATCH v4 5/9] blockdev: Split off basic bitmap operations for qemu-img Eric Blake
2020-05-14 6:21 ` Vladimir Sementsov-Ogievskiy
2020-05-14 14:15 ` Eric Blake
2020-05-13 1:16 ` [PATCH v4 6/9] qemu-img: Add bitmap sub-command Eric Blake
2020-05-14 6:45 ` Vladimir Sementsov-Ogievskiy
2020-05-14 14:20 ` Eric Blake
2020-05-14 15:09 ` Vladimir Sementsov-Ogievskiy
2020-05-18 11:42 ` Vladimir Sementsov-Ogievskiy
2020-05-18 19:07 ` Eric Blake
2020-05-18 19:38 ` Vladimir Sementsov-Ogievskiy
2020-05-13 1:16 ` [PATCH v4 7/9] qcow2: Expose bitmaps' size during measure Eric Blake
2020-05-18 13:07 ` Vladimir Sementsov-Ogievskiy
2020-05-18 19:17 ` Eric Blake
2020-05-18 19:47 ` Vladimir Sementsov-Ogievskiy
2020-05-13 1:16 ` [PATCH v4 8/9] qemu-img: Add convert --bitmaps option Eric Blake
2020-05-18 13:33 ` Vladimir Sementsov-Ogievskiy
2020-05-13 1:16 ` [PATCH v4 9/9] iotests: Add test 291 to for qemu-img bitmap coverage Eric Blake
2020-05-18 14:43 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53febccd-39b7-1326-7629-57f0b41b3ffa@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.