All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
	Zhang Haoyu <zhanghy@sangfor.com>,
	qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>,
	Gleb Natapov <gleb@kernel.org>,
	"Michael S.Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofitscorrespondingioapic->irr bit always set
Date: Fri, 29 Aug 2014 12:28:06 +0800	[thread overview]
Message-ID: <54000156.9050401@redhat.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E0AB71066@SHSMSX104.ccr.corp.intel.com>

On 08/29/2014 12:07 PM, Zhang, Yang Z wrote:
> Zhang Haoyu wrote on 2014-08-29:
>> > Hi, Yang, Gleb, Michael,
>> > Could you help review below patch please?
> I don't quite understand the background. Why ioacpi->irr is setting before EOI? It should be driver's responsibility to clear the interrupt before issuing EOI.
>

This may happen when a interrupt was injected to guest when its irq
handler (driver) was not registered. So irr was still set even during
EOI broadcast, and then this irq will be injected to guest immediately.
This may cause a dead loop for guest who does not have the ability to
detect and disable interrupt storm.

This may be a bug of device model, but we want to know in real cpu, is
there a small time gap between the finish of EOI broadcast and the
interrupt raised by EOI? If yes, looks like KVM should emulate this
behaviour?

Thanks

  reply	other threads:[~2014-08-29  4:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-23 10:36 [question] e1000 interrupt storm happened because of its corresponding ioapic->irr bit always set Zhang Haoyu
2014-08-23 10:36 ` [Qemu-devel] " Zhang Haoyu
2014-08-25  3:07 ` Jason Wang
2014-08-25  7:17   ` [question] e1000 interrupt storm happened becauseof " Zhang Haoyu
2014-08-25  7:17     ` [Qemu-devel] " Zhang Haoyu
2014-08-25  7:29     ` Jason Wang
2014-08-25  7:29       ` [Qemu-devel] " Jason Wang
2014-08-25  8:27       ` [question] e1000 interrupt storm happened becauseof its correspondingioapic->irr " Zhang Haoyu
2014-08-25  8:27         ` [Qemu-devel] " Zhang Haoyu
2014-08-26  9:28       ` Zhang Haoyu
2014-08-26  9:28         ` [Qemu-devel] " Zhang Haoyu
2014-08-27  5:09         ` Jason Wang
2014-08-27  5:09           ` [Qemu-devel] " Jason Wang
2014-08-27  9:31           ` [Qemu-devel] [question] e1000 interrupt storm happened becauseofits " Zhang Haoyu
2014-08-28  7:12             ` Jason Wang
2014-08-28 12:55             ` [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofits " Zhang Haoyu
2014-08-29  2:50               ` Jason Wang
2014-08-29  3:14               ` [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofitscorrespondingioapic->irr " Zhang Haoyu
2014-08-29  4:07                 ` Zhang, Yang Z
2014-08-29  4:07                   ` [Qemu-devel] " Zhang, Yang Z
2014-08-29  4:28                   ` Jason Wang [this message]
2014-09-02 15:44               ` [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofits correspondingioapic->irr " Michael S. Tsirkin
2014-09-04  1:56                 ` [Qemu-devel] [question] e1000 interrupt stormhappenedbecauseofits " Zhang Haoyu
2014-09-04  4:57                   ` Jason Wang
2014-08-25  7:32     ` [question] e1000 interrupt storm happened becauseof its corresponding ioapic->irr " Jason Wang
2014-08-25  7:32       ` [Qemu-devel] " Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54000156.9050401@redhat.com \
    --to=jasowang@redhat.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yang.z.zhang@intel.com \
    --cc=zhanghy@sangfor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.