From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbaH3BZE (ORCPT ); Fri, 29 Aug 2014 21:25:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:46278 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbaH3BZB (ORCPT ); Fri, 29 Aug 2014 21:25:01 -0400 Message-ID: <540127AC.4040804@oracle.com> Date: Fri, 29 Aug 2014 21:23:56 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Mel Gorman CC: Hugh Dickins , "linux-mm@kvack.org" , Andrew Morton , Dave Jones , LKML , "Kirill A. Shutemov" , Peter Zijlstra , Rik van Riel , Johannes Weiner , Cyrill Gorcunov Subject: Re: mm: BUG in unmap_page_range References: <53DD5F20.8010507@oracle.com> <20140805144439.GW10819@suse.de> <53E17F06.30401@oracle.com> <53E989FB.5000904@oracle.com> <53FD4D9F.6050500@oracle.com> <20140827152622.GC12424@suse.de> In-Reply-To: <20140827152622.GC12424@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2014 11:26 AM, Mel Gorman wrote: > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index 281870f..ffea570 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -723,6 +723,9 @@ static inline pte_t pte_mknuma(pte_t pte) > > VM_BUG_ON(!(val & _PAGE_PRESENT)); > > + /* debugging only, specific to x86 */ > + VM_BUG_ON(val & _PAGE_PROTNONE); > + > val &= ~_PAGE_PRESENT; > val |= _PAGE_NUMA; Triggered again, the first VM_BUG_ON got hit, the second one never did. Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by kanga.kvack.org (Postfix) with ESMTP id 0749B6B0035 for ; Fri, 29 Aug 2014 21:24:56 -0400 (EDT) Received: by mail-pa0-f47.google.com with SMTP id hz1so7691453pad.34 for ; Fri, 29 Aug 2014 18:24:56 -0700 (PDT) Received: from userp1040.oracle.com (userp1040.oracle.com. [156.151.31.81]) by mx.google.com with ESMTPS id as4si2058530pbc.130.2014.08.29.18.24.55 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 29 Aug 2014 18:24:56 -0700 (PDT) Message-ID: <540127AC.4040804@oracle.com> Date: Fri, 29 Aug 2014 21:23:56 -0400 From: Sasha Levin MIME-Version: 1.0 Subject: Re: mm: BUG in unmap_page_range References: <53DD5F20.8010507@oracle.com> <20140805144439.GW10819@suse.de> <53E17F06.30401@oracle.com> <53E989FB.5000904@oracle.com> <53FD4D9F.6050500@oracle.com> <20140827152622.GC12424@suse.de> In-Reply-To: <20140827152622.GC12424@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Hugh Dickins , "linux-mm@kvack.org" , Andrew Morton , Dave Jones , LKML , "Kirill A. Shutemov" , Peter Zijlstra , Rik van Riel , Johannes Weiner , Cyrill Gorcunov On 08/27/2014 11:26 AM, Mel Gorman wrote: > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index 281870f..ffea570 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -723,6 +723,9 @@ static inline pte_t pte_mknuma(pte_t pte) > > VM_BUG_ON(!(val & _PAGE_PRESENT)); > > + /* debugging only, specific to x86 */ > + VM_BUG_ON(val & _PAGE_PROTNONE); > + > val &= ~_PAGE_PRESENT; > val |= _PAGE_NUMA; Triggered again, the first VM_BUG_ON got hit, the second one never did. Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org