From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. Date: Wed, 22 Jun 2016 12:18:33 +0200 Message-ID: <5402203.QaZloJIEAM@wuerfel> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-arm-kernel@lists.infradead.org Cc: "devicetree@vger.kernel.org" , Mark Langsdorf , Suman Tripathi , Jon Masters , Olof Johansson , patches , "linux-ide@vger.kernel.org" , Tejun Heo List-Id: linux-ide@vger.kernel.org On Tuesday, June 21, 2016 4:31:38 PM CEST Suman Tripathi wrote: > On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi wrote: > > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann wrote: > >> > >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > >> > This patch adds ACPI support for APM X-Gene AHCI controller in > >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > >> > v3 hardware is fully compliant with ahci_platform driver and requires > >> > no workaround quirk. > >> > > >> > Signed-off-by: Suman Tripathi > >> > --- > >> > drivers/ata/ahci_platform.c | 1 + > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > >> > index 62a04c8..3395baf 100644 > >> > --- a/drivers/ata/ahci_platform.c > >> > +++ b/drivers/ata/ahci_platform.c > >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > >> > > >> > static const struct acpi_device_id ahci_acpi_match[] = { > >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > >> > + { "APMC0D33", 0}, > >> > {}, > >> > }; > >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > >> > > >> > >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > > > > yeah it also works. Just thought that we need something different as > > our's is a non-PCI SATA. > > Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for > non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? This was specifically introduced for non-PCI devices, so it should just work. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 22 Jun 2016 12:18:33 +0200 Subject: [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. In-Reply-To: References: Message-ID: <5402203.QaZloJIEAM@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday, June 21, 2016 4:31:38 PM CEST Suman Tripathi wrote: > On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi wrote: > > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann wrote: > >> > >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > >> > This patch adds ACPI support for APM X-Gene AHCI controller in > >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > >> > v3 hardware is fully compliant with ahci_platform driver and requires > >> > no workaround quirk. > >> > > >> > Signed-off-by: Suman Tripathi > >> > --- > >> > drivers/ata/ahci_platform.c | 1 + > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > >> > index 62a04c8..3395baf 100644 > >> > --- a/drivers/ata/ahci_platform.c > >> > +++ b/drivers/ata/ahci_platform.c > >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > >> > > >> > static const struct acpi_device_id ahci_acpi_match[] = { > >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > >> > + { "APMC0D33", 0}, > >> > {}, > >> > }; > >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > >> > > >> > >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > > > > yeah it also works. Just thought that we need something different as > > our's is a non-PCI SATA. > > Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for > non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? This was specifically introduced for non-PCI devices, so it should just work. Arnd