From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbaHaRvw (ORCPT ); Sun, 31 Aug 2014 13:51:52 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:59494 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbaHaRvu (ORCPT ); Sun, 31 Aug 2014 13:51:50 -0400 Message-ID: <54036090.1050104@gmail.com> Date: Sun, 31 Aug 2014 13:51:12 -0400 From: Pranith Kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: David Herrmann CC: Geert Uytterhoeven , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Anton Blanchard , Fabian Frederick , Andrew Morton , "open list:LINUX FOR POWERPC..." , open list Subject: Re: [RFC PATCH] powerpc: Wire up three syscalls References: <1409369788-22563-1-git-send-email-bobby.prani@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/2014 10:34 AM, David Herrmann wrote: > The only arch-dependent code for memfd_test.c is the syscall invocation: > memfd_create(const char *name, unsigned int flags); > via glibc as: > syscall(__NR_memfd_create, name, flags); > > Can you debug your test-run (maybe via simple printk() in mm/shmem.c > memfd_create()) and see what's going wrong there? > Hi David, I figured out the problem. I am on a 32-bit system and using u64 for flags in fcntl() is the cause of the problem. Will you accept a patch making the test work on 32-bit systems as below? Thanks! -- Pranith From: Pranith Kumar Date: Sun, 31 Aug 2014 13:38:07 -0400 Subject: [PATCH] memfd_test: Make it work on 32-bit systems This test currently fails on 32-bit systems since we use u64 type to pass the flags to fcntl. This commit changes this to use u32 type for flags to fcntl making it work on 32-bit systems. Signed-off-by: Pranith Kumar --- tools/testing/selftests/memfd/memfd_test.c | 32 +++++++++++++++--------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c index 3634c90..77e56ff 100644 --- a/tools/testing/selftests/memfd/memfd_test.c +++ b/tools/testing/selftests/memfd/memfd_test.c @@ -59,9 +59,9 @@ static void mfd_fail_new(const char *name, unsigned int flags) } } -static __u64 mfd_assert_get_seals(int fd) +static __u32 mfd_assert_get_seals(int fd) { - long r; + int r; r = fcntl(fd, F_GET_SEALS); if (r < 0) { @@ -72,36 +72,36 @@ static __u64 mfd_assert_get_seals(int fd) return r; } -static void mfd_assert_has_seals(int fd, __u64 seals) +static void mfd_assert_has_seals(int fd, __u32 seals) { - __u64 s; + __u32 s; s = mfd_assert_get_seals(fd); if (s != seals) { - printf("%llu != %llu = GET_SEALS(%d)\n", - (unsigned long long)seals, (unsigned long long)s, fd); + printf("%lu != %lu = GET_SEALS(%d)\n", + (unsigned long)seals, (unsigned long)s, fd); abort(); } } -static void mfd_assert_add_seals(int fd, __u64 seals) +static void mfd_assert_add_seals(int fd, __u32 seals) { - long r; - __u64 s; + int r; + __u32 s; s = mfd_assert_get_seals(fd); r = fcntl(fd, F_ADD_SEALS, seals); if (r < 0) { - printf("ADD_SEALS(%d, %llu -> %llu) failed: %m\n", - fd, (unsigned long long)s, (unsigned long long)seals); + printf("ADD_SEALS(%d, %lu -> %lu) failed: %m\n", + fd, (unsigned long)s, (unsigned long)seals); abort(); } } -static void mfd_fail_add_seals(int fd, __u64 seals) +static void mfd_fail_add_seals(int fd, __u32 seals) { - long r; - __u64 s; + int r; + __u32 s; r = fcntl(fd, F_GET_SEALS); if (r < 0) @@ -111,8 +111,8 @@ static void mfd_fail_add_seals(int fd, __u64 seals) r = fcntl(fd, F_ADD_SEALS, seals); if (r >= 0) { - printf("ADD_SEALS(%d, %llu -> %llu) didn't fail as expected\n", - fd, (unsigned long long)s, (unsigned long long)seals); + printf("ADD_SEALS(%d, %lu -> %lu) didn't fail as expected\n", + fd, (unsigned long)s, (unsigned long)seals); abort(); } } -- 2.1.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-x231.google.com (mail-qa0-x231.google.com [IPv6:2607:f8b0:400d:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id D81B51A005A for ; Mon, 1 Sep 2014 03:51:52 +1000 (EST) Received: by mail-qa0-f49.google.com with SMTP id s7so166540qap.36 for ; Sun, 31 Aug 2014 10:51:49 -0700 (PDT) Message-ID: <54036090.1050104@gmail.com> Date: Sun, 31 Aug 2014 13:51:12 -0400 From: Pranith Kumar MIME-Version: 1.0 To: David Herrmann Subject: Re: [RFC PATCH] powerpc: Wire up three syscalls References: <1409369788-22563-1-git-send-email-bobby.prani@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Cc: open list , Fabian Frederick , Geert Uytterhoeven , Anton Blanchard , Paul Mackerras , Andrew Morton , "open list:LINUX FOR POWERPC..." List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/31/2014 10:34 AM, David Herrmann wrote: > The only arch-dependent code for memfd_test.c is the syscall invocation: > memfd_create(const char *name, unsigned int flags); > via glibc as: > syscall(__NR_memfd_create, name, flags); > > Can you debug your test-run (maybe via simple printk() in mm/shmem.c > memfd_create()) and see what's going wrong there? > Hi David, I figured out the problem. I am on a 32-bit system and using u64 for flags in fcntl() is the cause of the problem. Will you accept a patch making the test work on 32-bit systems as below? Thanks! -- Pranith From: Pranith Kumar Date: Sun, 31 Aug 2014 13:38:07 -0400 Subject: [PATCH] memfd_test: Make it work on 32-bit systems This test currently fails on 32-bit systems since we use u64 type to pass the flags to fcntl. This commit changes this to use u32 type for flags to fcntl making it work on 32-bit systems. Signed-off-by: Pranith Kumar --- tools/testing/selftests/memfd/memfd_test.c | 32 +++++++++++++++--------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c index 3634c90..77e56ff 100644 --- a/tools/testing/selftests/memfd/memfd_test.c +++ b/tools/testing/selftests/memfd/memfd_test.c @@ -59,9 +59,9 @@ static void mfd_fail_new(const char *name, unsigned int flags) } } -static __u64 mfd_assert_get_seals(int fd) +static __u32 mfd_assert_get_seals(int fd) { - long r; + int r; r = fcntl(fd, F_GET_SEALS); if (r < 0) { @@ -72,36 +72,36 @@ static __u64 mfd_assert_get_seals(int fd) return r; } -static void mfd_assert_has_seals(int fd, __u64 seals) +static void mfd_assert_has_seals(int fd, __u32 seals) { - __u64 s; + __u32 s; s = mfd_assert_get_seals(fd); if (s != seals) { - printf("%llu != %llu = GET_SEALS(%d)\n", - (unsigned long long)seals, (unsigned long long)s, fd); + printf("%lu != %lu = GET_SEALS(%d)\n", + (unsigned long)seals, (unsigned long)s, fd); abort(); } } -static void mfd_assert_add_seals(int fd, __u64 seals) +static void mfd_assert_add_seals(int fd, __u32 seals) { - long r; - __u64 s; + int r; + __u32 s; s = mfd_assert_get_seals(fd); r = fcntl(fd, F_ADD_SEALS, seals); if (r < 0) { - printf("ADD_SEALS(%d, %llu -> %llu) failed: %m\n", - fd, (unsigned long long)s, (unsigned long long)seals); + printf("ADD_SEALS(%d, %lu -> %lu) failed: %m\n", + fd, (unsigned long)s, (unsigned long)seals); abort(); } } -static void mfd_fail_add_seals(int fd, __u64 seals) +static void mfd_fail_add_seals(int fd, __u32 seals) { - long r; - __u64 s; + int r; + __u32 s; r = fcntl(fd, F_GET_SEALS); if (r < 0) @@ -111,8 +111,8 @@ static void mfd_fail_add_seals(int fd, __u64 seals) r = fcntl(fd, F_ADD_SEALS, seals); if (r >= 0) { - printf("ADD_SEALS(%d, %llu -> %llu) didn't fail as expected\n", - fd, (unsigned long long)s, (unsigned long long)seals); + printf("ADD_SEALS(%d, %lu -> %lu) didn't fail as expected\n", + fd, (unsigned long)s, (unsigned long)seals); abort(); } } -- 2.1.0