From: John Crispin <blogic@openwrt.org>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH 04/12] MIPS: GIC: Move MIPS_GIC_IRQ_BASE into platform irq.h
Date: Mon, 01 Sep 2014 11:05:05 +0200 [thread overview]
Message-ID: <540436C1.20805@openwrt.org> (raw)
In-Reply-To: <3341001.1Jsp173xyM@wuerfel>
On 01/09/2014 10:34, Arnd Bergmann wrote:
> On Sunday 31 August 2014 11:54:04 Andrew Bresticker wrote:
>> On Sat, Aug 30, 2014 at 12:57 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Friday 29 August 2014 15:14:31 Andrew Bresticker wrote:
>>>> Define a generic MIPS_GIC_IRQ_BASE which is suitable for Malta and
>>>> the upcoming Danube board in <mach-generic/irq.h>. Since Sead-3 is
>>>> different and uses a MIPS_GIC_IRQ_BASE equal to the CPU IRQ base (0),
>>>> define its MIPS_GIC_IRQ_BASE in <mach-sead3/irq.h>.
>>>>
>>>> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>>>>
>>>
>>> Why do you actually have to hardwire an IRQ base? Can't you move
>>> to the linear irqdomain code for DT based MIPS systems yet?
>>
>> Neither Malta nor SEAD-3 use device-tree for interrupts yet, so they
>> still require a hard-coded IRQ base. For boards using device-tree, I
>> stuck with a legacy IRQ domain as it allows most of the existing GIC
>> irqchip code to be reused.
>
> I see. Note that we now have irq_domain_add_simple(), which should
> do the right think in either case: use a legacy domain when a
> nonzero base is provided for the old boards, but use the simple
> domain when probed from DT without an irq base.
>
> This makes the latter case more memory efficient (it avoids
> allocating the irq descriptors for every possibly but unused
> IRQ number) and helps ensure that you don't accidentally rely
> on hardcoded IRQ numbers for the DT based machines, which would
> be considered a bug.
Hi,
for the mediatek mt7621/1004k we use the following code to load the gic
https://dev.openwrt.org/browser/trunk/target/linux/ramips/patches-3.14/0012-MIPS-ralink-add-MT7621-support.patch
(look for arch/mips/ralink/irq-gic.c)
we ended up using irq_domain_add_legacy()
i am planning to send these patches upstream in the near future.
John
John
>
> Arnd
>
>
next prev parent reply other threads:[~2014-09-01 9:05 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 22:14 [PATCH 00/12] MIPS: GIC device-tree support Andrew Bresticker
2014-08-29 22:14 ` [PATCH 01/12] MIPS: Provide a generic plat_irq_dispatch Andrew Bresticker
2014-08-31 17:34 ` Jonas Gorski
2014-08-31 17:34 ` Jonas Gorski
2014-08-29 22:14 ` [PATCH 02/12] MIPS: Set vint handler when mapping CPU interrupts Andrew Bresticker
2014-08-29 22:14 ` [PATCH 03/12] of: Add binding document for MIPS GIC Andrew Bresticker
2014-08-29 22:14 ` Andrew Bresticker
2014-08-30 7:53 ` Arnd Bergmann
2014-08-30 7:53 ` Arnd Bergmann
2014-08-31 18:34 ` Andrew Bresticker
2014-08-31 18:34 ` Andrew Bresticker
2014-09-01 11:01 ` Mark Rutland
2014-09-01 11:01 ` Mark Rutland
2014-09-01 12:11 ` James Hogan
2014-09-01 12:11 ` James Hogan
2014-09-02 0:53 ` Andrew Bresticker
2014-09-02 0:53 ` Andrew Bresticker
2014-09-02 9:33 ` Mark Rutland
2014-09-02 9:33 ` Mark Rutland
2014-09-02 16:36 ` Andrew Bresticker
2014-09-02 16:36 ` Andrew Bresticker
2014-09-02 17:27 ` David Daney
2014-09-02 17:27 ` David Daney
2014-09-02 19:36 ` Andrew Bresticker
2014-09-03 0:50 ` David Daney
2014-09-03 0:50 ` David Daney
2014-09-03 23:53 ` Andrew Bresticker
2014-09-03 23:53 ` Andrew Bresticker
2014-09-04 0:06 ` David Daney
2014-08-29 22:14 ` [PATCH 04/12] MIPS: GIC: Move MIPS_GIC_IRQ_BASE into platform irq.h Andrew Bresticker
2014-08-30 7:57 ` Arnd Bergmann
2014-08-30 7:57 ` Arnd Bergmann
2014-08-31 18:54 ` Andrew Bresticker
2014-09-01 8:34 ` Arnd Bergmann
2014-09-01 8:34 ` Arnd Bergmann
2014-09-01 9:05 ` John Crispin [this message]
2014-09-02 0:08 ` Andrew Bresticker
2014-09-02 22:22 ` Andrew Bresticker
2014-09-03 15:08 ` Arnd Bergmann
2014-08-29 22:14 ` [PATCH 05/12] MIPS: GIC: Add device-tree support Andrew Bresticker
2014-08-29 22:14 ` Andrew Bresticker
2014-08-30 7:54 ` Arnd Bergmann
2014-08-30 7:54 ` Arnd Bergmann
2014-08-31 18:42 ` Andrew Bresticker
2014-08-29 22:14 ` [PATCH 06/12] MIPS: GIC: Add generic IPI support when using DT Andrew Bresticker
2014-08-29 22:14 ` [PATCH 07/12] MIPS: GIC: Implement irq_set_type callback Andrew Bresticker
2014-08-29 22:14 ` [PATCH 08/12] MIPS: GIC: Implement generic irq_ack/irq_eoi callbacks Andrew Bresticker
2014-08-29 22:14 ` [PATCH 09/12] MIPS: GIC: Fix gic_set_affinity() return value Andrew Bresticker
2014-08-29 22:14 ` [PATCH 10/12] MIPS: GIC: Support local interrupts Andrew Bresticker
2014-08-29 22:14 ` [PATCH 11/12] MIPS: GIC: Use local interrupts for timer Andrew Bresticker
2014-08-29 22:14 ` [PATCH 12/12] MIPS: Malta: Map GIC local interrupts Andrew Bresticker
2014-08-30 6:33 ` [PATCH 00/12] MIPS: GIC device-tree support John Crispin
2014-08-30 6:33 ` John Crispin
2014-08-31 18:32 ` Andrew Bresticker
2014-08-31 18:32 ` Andrew Bresticker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540436C1.20805@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.