All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915: Don't restrict i915_wa_registers to BDW
Date: Mon, 01 Sep 2014 12:33:50 +0100	[thread overview]
Message-ID: <5404599E.7080208@linux.intel.com> (raw)
In-Reply-To: <1409413863-7681-6-git-send-email-damien.lespiau@intel.com>

On 30/08/2014 16:51, Damien Lespiau wrote:
> We have CHV code that already makes the test obsolete. Besides, when
> num_wa_regs is 0 (platforms not gathering that W/A data), we expose
> something sensible already.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fc3d582a..cd4f045 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2636,11 +2636,6 @@ static int i915_wa_registers(struct seq_file *m, void *unused)
>   	struct drm_device *dev = node->minor->dev;
>   	struct drm_i915_private *dev_priv = dev->dev_private;
>
> -	if (!IS_BROADWELL(dev)) {
> -		DRM_DEBUG_DRIVER("Workaround table not available !!\n");
> -		return -EINVAL;
> -	}
> -
>   	ret = mutex_lock_interruptible(&dev->struct_mutex);
>   	if (ret)
>   		return ret;
>
This can also be taken, so patches 1 and 5 in this series.
Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>

regards
Arun

  reply	other threads:[~2014-09-01 11:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30 15:50 [PATCH 0/5] A few fixes on top of the wa_regs patches Damien Lespiau
2014-08-30 15:50 ` [PATCH 1/5] drm/i915: Rename intel_wa_registers with a i915_ prefix Damien Lespiau
2014-09-01 11:06   ` Siluvery, Arun
2014-08-30 15:51 ` [PATCH 2/5] drm/i915: Don't overrun the intel_wa_regs array Damien Lespiau
2014-08-30 15:51 ` [PATCH 3/5] drm/i915: Don't silently discard workarounds Damien Lespiau
2014-08-30 15:51 ` [PATCH 4/5] drm/i915: Remove unneeded brackets Damien Lespiau
2014-08-30 15:51 ` [PATCH 5/5] drm/i915: Don't restrict i915_wa_registers to BDW Damien Lespiau
2014-09-01 11:33   ` Siluvery, Arun [this message]
2014-08-31 19:32 ` [PATCH 0/5] A few fixes on top of the wa_regs patches Siluvery, Arun
2014-09-01  9:08   ` Daniel Vetter
2014-09-01  9:29     ` Siluvery, Arun
2014-09-03  9:18 ` Siluvery, Arun
2014-09-03 10:40   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5404599E.7080208@linux.intel.com \
    --to=arun.siluvery@linux.intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.