From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOQLW-00035V-Uf for qemu-devel@nongnu.org; Mon, 01 Sep 2014 08:04:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOQLN-00054d-Tf for qemu-devel@nongnu.org; Mon, 01 Sep 2014 08:04:30 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:47784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOQLN-00054U-Md for qemu-devel@nongnu.org; Mon, 01 Sep 2014 08:04:21 -0400 Received: by mail-wi0-f178.google.com with SMTP id r20so5986178wiv.17 for ; Mon, 01 Sep 2014 05:04:20 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <540460C1.6090806@redhat.com> Date: Mon, 01 Sep 2014 14:04:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1409567710-26217-1-git-send-email-famz@redhat.com> <5404584D.9000702@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] rules.mak: Fix DSO build by pulling in archive symbols List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , hjl.tools@gmail.com, Fam Zheng , Michael Tokarev , QEMU Developers , Stefan Hajnoczi Il 01/09/2014 13:46, Peter Maydell ha scritto: > So we could fix this by not compiling empty files... Easy for int128, even easier for getauxval (it's not a fastpath, so we can move the "always return 0" version from include/qemu/osdep.h to util/getauxval.c). I'm not sure how to detect that there generated-tracers.c is empty. Stefan, is it used by anything except $(CONFIG_TRACE_SIMPLE)? > ranlib doesn't like that either (this one's a warning we've had for > a long time): Given this, do you consider th a blocker for this patch? Paolo