[PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[Chen Gang]

"entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it.
So need include "linux/linkage.h" to use generic one instead of.

The related error (with allmodconfig under microblaze):

    CC [M]  drivers/net/ethernet/emulex/benet/be_main.o
  In file included from ./arch/microblaze/include/asm/processor.h:17:0,
                   from include/linux/prefetch.h:14,
                   from drivers/net/ethernet/emulex/benet/be_main.c:18:
  ./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
   extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
                     ^

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/microblaze/include/asm/entry.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h
index b4a4cb1..596e485 100644
--- a/arch/microblaze/include/asm/entry.h
+++ b/arch/microblaze/include/asm/entry.h
@@ -15,6 +15,7 @@
 
 #include <asm/percpu.h>
 #include <asm/ptrace.h>
+#include <linux/linkage.h>
 
 /*
  * These are per-cpu variables required in entry.S, among other
-- 
1.7.11.7

Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[Chen Gang]

Hello maintainers:

Please help check the related 2 patches when you have time.

Thanks.

On 08/06/2014 09:32 PM, Chen Gang wrote:
> "entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it.
> So need include "linux/linkage.h" to use generic one instead of.
> 
> The related error (with allmodconfig under microblaze):
> 
>     CC [M]  drivers/net/ethernet/emulex/benet/be_main.o
>   In file included from ./arch/microblaze/include/asm/processor.h:17:0,
>                    from include/linux/prefetch.h:14,
>                    from drivers/net/ethernet/emulex/benet/be_main.c:18:
>   ./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
>    extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
>                      ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/microblaze/include/asm/entry.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h
> index b4a4cb1..596e485 100644
> --- a/arch/microblaze/include/asm/entry.h
> +++ b/arch/microblaze/include/asm/entry.h
> @@ -15,6 +15,7 @@
>  
>  #include <asm/percpu.h>
>  #include <asm/ptrace.h>
> +#include <linux/linkage.h>
>  
>  /*
>   * These are per-cpu variables required in entry.S, among other
> 


-- 
Chen Gang

Open share and attitude like air water and life which God blessed

Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[Chen Gang]

Hello All:

Is microblaze for Linux upstream kernel still alive?

Before I get confirmation, I should do nothing for microblaze to avoid
sending spams to kernel mailing list.


Thanks.


On 8/19/14 23:47, Chen Gang wrote:
> Hello maintainers:
> 
> Please help check the related 2 patches when you have time.
> 
> Thanks.
> 
> On 08/06/2014 09:32 PM, Chen Gang wrote:
>> "entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it.
>> So need include "linux/linkage.h" to use generic one instead of.
>>
>> The related error (with allmodconfig under microblaze):
>>
>>     CC [M]  drivers/net/ethernet/emulex/benet/be_main.o
>>   In file included from ./arch/microblaze/include/asm/processor.h:17:0,
>>                    from include/linux/prefetch.h:14,
>>                    from drivers/net/ethernet/emulex/benet/be_main.c:18:
>>   ./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
>>    extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
>>                      ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  arch/microblaze/include/asm/entry.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h
>> index b4a4cb1..596e485 100644
>> --- a/arch/microblaze/include/asm/entry.h
>> +++ b/arch/microblaze/include/asm/entry.h
>> @@ -15,6 +15,7 @@
>>  
>>  #include <asm/percpu.h>
>>  #include <asm/ptrace.h>
>> +#include <linux/linkage.h>
>>  
>>  /*
>>   * These are per-cpu variables required in entry.S, among other
>>
> 
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Hi Chen,

On 08/24/2014 10:06 AM, Chen Gang wrote:
> Hello All:
> 
> Is microblaze for Linux upstream kernel still alive?
> 
> Before I get confirmation, I should do nothing for microblaze to avoid
> sending spams to kernel mailing list.

Yes. Microblaze is alive. I am just busy over summer in Europe.

I will reply the patch you sent.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

On 08/06/2014 03:32 PM, Chen Gang wrote:
> "entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it.
> So need include "linux/linkage.h" to use generic one instead of.
> 
> The related error (with allmodconfig under microblaze):
> 
>     CC [M]  drivers/net/ethernet/emulex/benet/be_main.o
>   In file included from ./arch/microblaze/include/asm/processor.h:17:0,
>                    from include/linux/prefetch.h:14,
>                    from drivers/net/ethernet/emulex/benet/be_main.c:18:
>   ./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
>    extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
>                      ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/microblaze/include/asm/entry.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h
> index b4a4cb1..596e485 100644
> --- a/arch/microblaze/include/asm/entry.h
> +++ b/arch/microblaze/include/asm/entry.h
> @@ -15,6 +15,7 @@
>  
>  #include <asm/percpu.h>
>  #include <asm/ptrace.h>
> +#include <linux/linkage.h>
>  
>  /*
>   * These are per-cpu variables required in entry.S, among other
> 

Applied.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On 08/19/2014 05:47 PM, Chen Gang wrote:
> Hello maintainers:
> 
> Please help check the related 2 patches when you have time.

Can you resend that second one?
I have just this one.
arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

[Chen Gang]

On 09/01/2014 09:40 PM, Michal Simek wrote:
> Hi Chen,
> 
> On 08/24/2014 10:06 AM, Chen Gang wrote:
>> Hello All:
>>
>> Is microblaze for Linux upstream kernel still alive?
>>
>> Before I get confirmation, I should do nothing for microblaze to avoid
>> sending spams to kernel mailing list.
> 
> Yes. Microblaze is alive. I am just busy over summer in Europe.
> 
> I will reply the patch you sent.
> 

OK, thanks. And I shall continue to try to let microblaze pass
allmodconfig (hope I can finish within this month).

And I forward the other patch in an individual thread, please help check
when you have time.

Thanks.
-- 
Chen Gang

Open share and attitude like air water and life which God blessed